NEWS file needs update?

2005-05-12 Thread Jim Hyslop
According to this message, 
http://lists.gnu.org/archive/html/info-cvs/2004-10/msg00252.html, the 
Protocol error: uncounted data discarded error was scheduled to be 
fixed in 1.11.18, but there is no mention of that error in the NEWS file.

Is this simply an oversight in the NEWS file?
--
Jim

___
Bug-cvs mailing list
Bug-cvs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-cvs


Re: Build CVS (TRUNK) failed.

2005-05-07 Thread Jim Hyslop
Mark D. Baushke wrote:
Hi Jim,
Okay. Thanks for the clue. I have committed the patch given after my
.signature in hopes that it will be closer.
I think your patch still had some problems. I believe you need to quote
file names that contain a - character, the dep file for dup-safer
needed to make note of a few other files and the libcvs.mak needed to
learn how to build both dup-safer.obj as well as fd-safer.obj
Well, it did compile OK without the quoting, on my machine. Quoting 
certainly can't hurt, though.

--
Jim

___
Bug-cvs mailing list
Bug-cvs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-cvs


Re: Build CVS (TRUNK) failed.

2005-05-06 Thread Jim Hyslop
Mark D. Baushke wrote:
Hi Folks,
I suspect that something like the following patch is needed, but I don't
actually have any Windows box or development environment to test it.
Almost there - you need to add dup-safer as well.  For some reason, if I 
added the SOURCE= section for dup-safer in libcvs.mak, nmake couldn't 
build it - I have no clue why.

ccvs\libnmake -f libcvs.mak
Microsoft (R) Program Maintenance Utility   Version 6.00.8168.0
Copyright (C) Microsoft Corp 1988-1998. All rights reserved.
No configuration specified. Defaulting to libcvs - Win32 Debug.
NMAKE : fatal error U1073: don't know how to make '\'
Stop.
I could not get it to build. I even backed out all my changes, reverted 
to your patch and did a sed s/fd-safer/dup-safer/g and it *still* didn't 
build. Weird.

Anyway, here's a revised patch that compiles and links (I haven't tested 
it at all):

Index: lib/libcvs.dep
===
RCS file: /cvs/ccvs/lib/libcvs.dep,v
retrieving revision 1.19
diff -u -r1.19 libcvs.dep
--- lib/libcvs.dep  8 Mar 2005 05:16:29 -   1.19
+++ lib/libcvs.dep  6 May 2005 18:34:59 -
@@ -32,13 +32,23 @@
..\windows-NT\stdbool.h\
.\dirname.h\
.\xalloc.h\
-   
+
+.\dup-safer.c : \  
+   ..\windows-NT\config.h\
+   ..\windows-NT\stdbool.h
 .\exitfail.c : \
..\windows-NT\config.h\
.\exit.h\
.\exitfail.h\

+.\fd-safer.c : \
+   ..\windows-NT\config.h\
+   ..\windows-NT\stdbool.h\
+   ..\windows-NT\unistd.h\
+   .\unistd-safer.h\
+   .\error.h\
+   
 .\fncase.c : \
..\windows-NT\config.h\
Index: lib/libcvs.dsp
===
RCS file: /cvs/ccvs/lib/libcvs.dsp,v
retrieving revision 1.20
diff -u -r1.20 libcvs.dsp
--- lib/libcvs.dsp  8 Mar 2005 05:16:29 -   1.20
+++ lib/libcvs.dsp  6 May 2005 18:35:00 -
@@ -105,10 +105,18 @@
 # End Source File
 # Begin Source File
+SOURCE=.\dup-safer.c
+# End Source File
+# Begin Source File
+
 SOURCE=.\exitfail.c
 # End Source File
 # Begin Source File
+SOURCE=.\fd-safer.c
+# End Source File
+# Begin Source File
+
 SOURCE=.\fncase.c
 # End Source File
 # Begin Source File
Index: lib/libcvs.mak
===
RCS file: /cvs/ccvs/lib/libcvs.mak,v
retrieving revision 1.21
diff -u -r1.21 libcvs.mak
--- lib/libcvs.mak  8 Mar 2005 05:16:29 -   1.21
+++ lib/libcvs.mak  6 May 2005 18:35:01 -
@@ -45,7 +45,9 @@
[EMAIL PROTECTED] $(INTDIR)\basename.obj
[EMAIL PROTECTED] $(INTDIR)\closeout.obj
[EMAIL PROTECTED] $(INTDIR)\dirname.obj
+   [EMAIL PROTECTED] $(INTDIR)\dup-safer.obj
[EMAIL PROTECTED] $(INTDIR)\exitfail.obj
+   [EMAIL PROTECTED] $(INTDIR)\fd-safer.obj
[EMAIL PROTECTED] $(INTDIR)\fncase.obj
[EMAIL PROTECTED] $(INTDIR)\fnmatch.obj
[EMAIL PROTECTED] $(INTDIR)\fseeko.obj
@@ -101,8 +103,10 @@
$(INTDIR)\asnprintf.obj \
$(INTDIR)\basename.obj \
$(INTDIR)\dirname.obj \
+   $(INTDIR)\dup-safer.obj \
$(INTDIR)\exitfail.obj \
$(INTDIR)\fncase.obj \
+   $(INTDIR)\fd-safer.obj \
$(INTDIR)\fnmatch.obj \
$(INTDIR)\fseeko.obj \
$(INTDIR)\ftello.obj \
@@ -162,7 +166,9 @@
[EMAIL PROTECTED] $(INTDIR)\basename.obj
[EMAIL PROTECTED] $(INTDIR)\closeout.obj
[EMAIL PROTECTED] $(INTDIR)\dirname.obj
+   [EMAIL PROTECTED] $(INTDIR)\dup-safer.obj
[EMAIL PROTECTED] $(INTDIR)\exitfail.obj
+   [EMAIL PROTECTED] $(INTDIR)\fd-safer.obj
[EMAIL PROTECTED] $(INTDIR)\fncase.obj
[EMAIL PROTECTED] $(INTDIR)\fnmatch.obj
[EMAIL PROTECTED] $(INTDIR)\fseeko.obj
@@ -216,7 +222,9 @@
$(INTDIR)\asnprintf.obj \
$(INTDIR)\basename.obj \
$(INTDIR)\dirname.obj \
+   $(INTDIR)\dup-safer.obj \
$(INTDIR)\exitfail.obj \
+   $(INTDIR)\fd-safer.obj \
$(INTDIR)\fncase.obj \
$(INTDIR)\fnmatch.obj \
$(INTDIR)\fseeko.obj \
@@ -333,6 +341,11 @@
 $(INTDIR)\exitfail.obj : $(SOURCE) $(INTDIR)
+SOURCE=.\fd-safer.c
+
+$(INTDIR)\fd-safer.obj : $(SOURCE) $(INTDIR)
+
+
 SOURCE=.\fncase.c
 $(INTDIR)\fncase.obj : $(SOURCE) $(INTDIR)

--
Jim

___
Bug-cvs mailing list
Bug-cvs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-cvs


Recent checkins to lib/xgetcwd.c breaks Windows

2005-03-05 Thread Jim Hyslop
The recent checkin to lib/xgetcwd.c changes the implementation of 
xgetwd() from:

char *
xgetwd ()
{
  char *cwd;
  char *ret;
  unsigned path_max;
  errno = 0;
  path_max = (unsigned) PATH_MAX;
  path_max += 2;/* The getcwd docs say to do this. */
  cwd = xmalloc (path_max);
  errno = 0;
  while ((ret = getcwd (cwd, path_max)) == NULL  errno == ERANGE)
{
  path_max += PATH_INCR;
  cwd = xrealloc (cwd, path_max);
  errno = 0;
}
  if (ret == NULL)
{
  int save_errno = errno;
  free (cwd);
  errno = save_errno;
  return NULL;
}
  return cwd;
}
to:
char *
xgetcwd (void)
{
  char *cwd = getcwd (NULL, 0);
  if (! cwd  errno == ENOMEM)
xalloc_die ();
  return cwd;
}
While the new version is shorter, it doesn't work on Windows (Cygwin). 
It appears that Cygwin expects the parameter to getcwd() to be non-NULL. 
At least, 'getcwd()' always returns in the latest version of the file 
(trunk). Can we revert xgetcwd.c to its previous version? Why was it 
changed?

--
Jim

___
Bug-cvs mailing list
Bug-cvs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-cvs


Re: 'cvs watch on' patch (was: Changing passwords for CVS Users (pserver protocol)]

2005-02-24 Thread Jim Hyslop
Derek Price wrote:
The patch does what you said it would on stable, but something else is
wrong on feature.  The new watch6-2 test fails - basically, 
the previous
watch add appears to be failing without reporting the error.  I've
attached a revised patch, with the failing tests (which, 
again, pass on
stable).
I've investigated, and watch6-2 appears to fail as a result of a 
different bug in feature. The commands cvs watch [add/remove] (with no 
files specified) no longer create the default entry in the fileattr file.

The test cases should pass on feature if you:
sed 's/watch add/watch add .'
sed 's/watch remove/watch remove .'
I'll look into that other bug and see if I can track it down.
--
Jim

___
Bug-cvs mailing list
Bug-cvs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-cvs