Re: failure to append to .cvspass should always be fatal

2005-02-28 Thread Mark D. Baushke
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jim Meyering <[EMAIL PROTECTED]> writes: > > Hmmm... I wonder if it is possible to come up with a sanity.sh test case > > for this one? > > I considered it but, dismissed it as infeasible. > Of course, I would be happy to be proved wrong. > > It mig

Re: failure to append to .cvspass should always be fatal

2005-02-28 Thread Jim Meyering
> Hmmm... I wonder if it is possible to come up with a sanity.sh test case > for this one? I considered it but, dismissed it as infeasible. Of course, I would be happy to be proved wrong. It might work to use a tool like subterfugue, where you could presumably cause to fail the first write after

Re: failure to append to .cvspass should always be fatal

2005-02-28 Thread Mark D. Baushke
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jim Meyering <[EMAIL PROTECTED]> writes: > "Mark D. Baushke" <[EMAIL PROTECTED]> wrote: > > Your patch looks good to me. Go ahead and commit it. > > I've done so on the trunk. > cvs1-11-x-branch too? Yes, that would be good. Hmmm... I wonder if it

Re: failure to append to .cvspass should always be fatal

2005-02-28 Thread Jim Meyering
"Mark D. Baushke" <[EMAIL PROTECTED]> wrote: > Your patch looks good to me. Go ahead and commit it. I've done so on the trunk. cvs1-11-x-branch too? ___ Bug-cvs mailing list Bug-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/bug-cvs

Re: failure to append to .cvspass should always be fatal

2005-02-27 Thread Mark D. Baushke
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Jim, Your patch looks good to me. Go ahead and commit it. -- Mark Jim Meyering <[EMAIL PROTECTED]> writes: > When a `login' commands leads to appending to .cvspass, that file is > copied to a stream opened on a temporary file, and the ne

failure to append to .cvspass should always be fatal

2005-02-27 Thread Jim Meyering
When a `login' commands leads to appending to .cvspass, that file is copied to a stream opened on a temporary file, and the new entry is appended. While failing to open or fwrite the temporary file evokes an `error (1, ...', a failed fclose gets only a warning: if ((fp = CVS_FOPEN (passfi