RE: lib/xtime.h is included twice
Derek Price wrote: I'm ok with this if you'd like to apply it, Jim. Patch has been committed on 1.11 branch and on the trunk. Since this is such a small patch, should I still update ChangeLog and NEWS? ChangeLog doesn't seem to mention build fixes very much; there are one or two mentions in NEWS. I would be nice to give Georg credit for finding the problem and submitting the original patch, so I will put an entry in NEWS, but (to be consistent with other fix the build changes) not in ChangeLog. OK? -- Jim Hyslop Senior Software Designer Leitch Technology International Inc. ( http://www.leitch.com ) Columnist, C/C++ Users Journal ( http://www.cuj.com/experts ) ___ Bug-cvs mailing list Bug-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/bug-cvs
Re: lib/xtime.h is included twice
Jim.Hyslop writes: Since this is such a small patch, should I still update ChangeLog and NEWS? All changes go into ChangeLog, only significant user-visible changes go into NEWS. See the GNU coding standards for more details: http://www.gnu.org/prep/standards/ -Larry Jones The game's called on account of sudden death. -- Calvin ___ Bug-cvs mailing list Bug-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/bug-cvs
RE: lib/xtime.h is included twice
[EMAIL PROTECTED] wrote: All changes go into ChangeLog, only significant user-visible changes go into NEWS. See the GNU coding standards for more details: http://www.gnu.org/prep/standards/ Noted. And bookmarked for future reference - thanks for that information. -- Jim Hyslop Senior Software Designer Leitch Technology International Inc. ( http://www.leitch.com ) Columnist, C/C++ Users Journal ( http://www.cuj.com/experts ) ___ Bug-cvs mailing list Bug-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/bug-cvs
Re: lib/xtime.h is included twice
I cannot judge this. I was just following the example given in http://cvsweb.NetBSD.org/bsdweb.cgi/src/share/misc/style?rev=HEADcontent-type=text/x-cvsweb-markup If you think different naming conventions are more appropriate, I don't mind. [EMAIL PROTECTED] wrote: Dear cvs developers, for cvs 1.11.19 and earlier, lib/xtime.h is included twice, which breaks compiling on IRIX 5.3. The following patch prevents this: --- lib/xtime.h.orig2005-03-01 15:53:11.0 +0100 +++ lib/xtime.h 2005-03-01 15:54:20.0 +0100 @@ -12,6 +12,9 @@ * functions */ +#ifndef _XTIME_H_ +#define _XTIME_H_ ISO C Standard reserves names beginning with underscore and an uppercase character, or beginning with two underscores. I recommend changing this to something like: #ifndef XTIME_HEADER_INCLUDEd #define XTIME_HEADER_INCLUDEd (note: the lower-case d at the end is deliberate - it's my technique to reduce the chances of a name collision.) -- Jim Hyslop Senior Software Designer Leitch Technology International Inc. ( http://www.leitch.com ) Columnist, C/C++ Users Journal ( http://www.cuj.com/experts ) -- Georg Schwarzhttp://home.pages.de/~schwarz/ [EMAIL PROTECTED] +49 178 8545053 ___ Bug-cvs mailing list Bug-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/bug-cvs
RE: lib/xtime.h is included twice
Georg Schwarz wrote: I cannot judge this. I was just following the example given in http://cvsweb.NetBSD.org/bsdweb.cgi/src/share/misc/style?rev=H EADcontent-type=text/x-cvsweb-markup Oh, dear. Time to send NetBSD a note suggesting they change the example, if they want to remain ISO/ANSI compliant. Can anyone confirm if [EMAIL PROTECTED] is the correct contact for this? If you think different naming conventions are more appropriate, I don't mind. If you're referring to the leading underscore, then that's not just a naming convention, it's a violation of the ANSI/ISO C standard (paragraph 7.1.3, Reserved Identifiers). If you're referring to the lower-case d, then I have no strong attachment to it. -- Jim Hyslop Senior Software Designer Leitch Technology International Inc. ( http://www.leitch.com ) Columnist, C/C++ Users Journal ( http://www.cuj.com/experts ) ___ Bug-cvs mailing list Bug-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/bug-cvs
RE: lib/xtime.h is included twice
[EMAIL PROTECTED] wrote: Dear cvs developers, for cvs 1.11.19 and earlier, lib/xtime.h is included twice, which breaks compiling on IRIX 5.3. The following patch prevents this: --- lib/xtime.h.orig2005-03-01 15:53:11.0 +0100 +++ lib/xtime.h 2005-03-01 15:54:20.0 +0100 @@ -12,6 +12,9 @@ * functions */ +#ifndef _XTIME_H_ +#define _XTIME_H_ ISO C Standard reserves names beginning with underscore and an uppercase character, or beginning with two underscores. I recommend changing this to something like: #ifndef XTIME_HEADER_INCLUDEd #define XTIME_HEADER_INCLUDEd (note: the lower-case d at the end is deliberate - it's my technique to reduce the chances of a name collision.) -- Jim Hyslop Senior Software Designer Leitch Technology International Inc. ( http://www.leitch.com ) Columnist, C/C++ Users Journal ( http://www.cuj.com/experts ) ___ Bug-cvs mailing list Bug-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/bug-cvs
RE: lib/xtime.h is included twice
Derek Price wrote: Jim.Hyslop wrote: | [EMAIL PROTECTED] wrote: | | Dear cvs developers, | | for cvs 1.11.19 and earlier, lib/xtime.h is included twice, which | breaks compiling on IRIX 5.3. The following patch prevents this: | | --- lib/xtime.h.orig2005-03-01 15:53:11.0 +0100 +++ | lib/xtime.h 2005-03-01 15:54:20.0 +0100 @@ -12,6 +12,9 @@ | * functions */ | | +#ifndef _XTIME_H_ +#define _XTIME_H_ | | ISO C Standard reserves names beginning with underscore and an | uppercase character, or beginning with two underscores. I recommend | changing this to something like: | | #ifndef XTIME_HEADER_INCLUDEd #define XTIME_HEADER_INCLUDEd | | (note: the lower-case d at the end is deliberate - it's my | technique to reduce the chances of a name collision.) I'm ok with this if you'd like to apply it, Jim. Will do. Georg, have you tested your patch on any other platforms? It should be harmless, but I've been bitten by enough harmless-looking patches to be wary :-) -- Jim Hyslop Senior Software Designer Leitch Technology International Inc. ( http://www.leitch.com ) Columnist, C/C++ Users Journal ( http://www.cuj.com/experts ) ___ Bug-cvs mailing list Bug-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/bug-cvs
