Re: [PATCH] pagealign_alloc: don't loop endlessly

2005-05-06 Thread Thorsten Glaser
Derek Price dixit: My patch logs the actual error message to the syslog too (via the vsyslog() call), but if your chroot is preventing access to the syslog, that wouldn't help anyhow. Yes, that's why I was suggesting to print the error message to stderr so at least the client gets an idea about

Re: [PATCH] pagealign_alloc: don't loop endlessly

2005-05-06 Thread Thorsten Glaser
Derek Price dixit: Can you provide me with a test case that reproduces this behavior? Sorry, not at the moment, at least not without a great effort. I will do as soon as I've reinstalled my boxen. I could do a temporary test scenario, but we needed to be in sync for that. Join irc.oftc.net and

Re: [PATCH] pagealign_alloc: don't loop endlessly

2005-05-06 Thread Thorsten Glaser
Derek Price dixit: Yes, that's why I was suggesting to print the error message to stderr so at least the client gets an idea about what happened and can slap the server administrator. CVS does this for quite some occasions, for example no space available in the server's temporary directory.

Re: [PATCH] pagealign_alloc: don't loop endlessly

2005-05-04 Thread Derek Price
Does the attached, more general, patch do the trick for you? I think the problem is deeper - error() really needs a way to bypass the memory allocation of the buffer routines, but this should work around the problem for now. Cheers, Derek Thorsten Glaser wrote: Hello! Please apply the

Re: [PATCH] pagealign_alloc: don't loop endlessly

2005-05-04 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thorsten Glaser wrote: Derek Price dixit: Yes, that's why I was suggesting to print the error message to stderr so at least the client gets an idea about what happened and can slap the server administrator. CVS does this for quite some occasions,

Re: [PATCH] pagealign_alloc: don't loop endlessly

2005-05-04 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Thorsten Glaser wrote: Derek Price dixit: Does the attached, more general, patch do the trick for you? It does, but I do not get a diagnostic, neither on stderr (CVS output) nor in syslog on server or client. This is probably because the CVS

Re: [PATCH] pagealign_alloc: don't loop endlessly

2005-05-04 Thread Derek Price
I've attached a revised version of my earlier patch that preserves more information and avoids problems when the exit handlers call error() after error() calls exit(). Regards, Derek Index: src/ChangeLog === RCS file: