Re: Feature Branch Windows Build Broken - New GNULIB glob module

2005-05-18 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: I updated with the recent commit of the glob module and we have a new warning on line 1184 of lib/glob.c file (see below) Let's revisit this after you provide definitions for the following macros in windows-NT/config.h.in.in:

Re: Feature Branch Windows Build Broken - New GNULIB glob module

2005-05-17 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: The following patch lets me get this far in the Windows IDE build: Configuration: libcvs - Win32 Debug Compiling... glob.c H:\Conrad\Projects\cvs-1.12\lib\glob.c(253) : warning C4028:

RE: Feature Branch Windows Build Broken - New GNULIB glob module

2005-05-17 Thread Conrad T. Pino
The previous patch to lib/libcvs.dsp doesn't contain fix for the Win32 Release configuration so please don't commit this patch. I have a corrected patch which I plan to commit if that's what is indicated and will supply it if requested but haven't done so because it adds nothing to the debugging

RE: Feature Branch Windows Build Broken - New GNULIB glob module

2005-05-17 Thread Conrad T. Pino
Hi Derek, From: Derek Price [mailto:[EMAIL PROTECTED] I'm going to suggest something a little more general to the GNULIB maintainers: #ifndef __BEGIN_DECLS # define __BEGIN_DECLS #endif #ifndef __END_DECLS # define __END_DECLS #endif #ifndef __const # define __const const #endif

RE: Feature Branch Windows Build Broken - New GNULIB glob module

2005-05-17 Thread Conrad T. Pino
Hi Derek, From: Derek Price [mailto:[EMAIL PROTECTED] Well, basically. I created the glob module myself and added it to CVS and Paul has been reviewing it and I've been correcting it in ways to make it compatible with GNULIB GLIBC. Cool. Another budding published author in our midst. :)