Re: [Bug-dejagnu] BUG: improper format string construction in framework.exp

2018-11-04 Thread Ben Elliston
On Tue, Oct 30, 2018 at 08:58:46PM -0500, Jacob Bachmeyer wrote: > Lastly, is a soft dependency on GNU awk acceptable for DejaGnu or > would I need to rewrite my testsuite summarization tool in Tcl or > Expect before contributing it for use with the DejaGnu testsuite? I am happy for contributed

Re: [Bug-dejagnu] BUG: improper format string construction in framework.exp

2018-10-30 Thread Jacob Bachmeyer
Ben Elliston wrote: On Mon, Oct 29, 2018 at 11:17:33PM -0500, Jacob Bachmeyer wrote: Overwriting site.exp appears to actually be important, because the DejaGnu testsuite needs srcdir to be .../dejagnu/testsuite and Automake sets srcdir to .../dejagnu; thus the need for "--srcdir

Re: [Bug-dejagnu] BUG: improper format string construction in framework.exp

2018-10-30 Thread Jacob Bachmeyer
Andreas Schwab wrote: On Okt 29 2018, Jacob Bachmeyer wrote: Andreas Schwab wrote: On Okt 28 2018, Jacob Bachmeyer wrote: diff --git a/lib/framework.exp b/lib/framework.exp index 6cb93c5..50ac757 100644 --- a/lib/framework.exp +++ b/lib/framework.exp @@ -800,7 +800,7 @@

Re: [Bug-dejagnu] BUG: improper format string construction in framework.exp

2018-10-30 Thread Andreas Schwab
On Okt 29 2018, Jacob Bachmeyer wrote: > Andreas Schwab wrote: >> On Okt 28 2018, Jacob Bachmeyer wrote: >> >>> diff --git a/lib/framework.exp b/lib/framework.exp >>> index 6cb93c5..50ac757 100644 >>> --- a/lib/framework.exp >>> +++ b/lib/framework.exp >>> @@ -800,7 +800,7 @@ proc

Re: [Bug-dejagnu] BUG: improper format string construction in framework.exp

2018-10-29 Thread Andreas Schwab
On Okt 28 2018, Jacob Bachmeyer wrote: > diff --git a/lib/framework.exp b/lib/framework.exp > index 6cb93c5..50ac757 100644 > --- a/lib/framework.exp > +++ b/lib/framework.exp > @@ -800,7 +800,7 @@ proc record_test { type message args } { > > global multipass_name > if {

Re: [Bug-dejagnu] BUG: improper format string construction in framework.exp (follow-up)

2018-10-28 Thread Ben Elliston
On Sun, Oct 28, 2018 at 10:08:42PM -0500, Jacob Bachmeyer wrote: > On a related note, I note that the DejaGnu testsuite does not test > the multipass feature, nor does the feature seem to be properly > documented. Where would be the best place to insert something in > the manual describing

Re: [Bug-dejagnu] BUG: improper format string construction in framework.exp

2018-10-28 Thread Ben Elliston
On Sun, Oct 28, 2018 at 07:52:55PM -0500, Jacob Bachmeyer wrote: > corrected patch: (also relative to commit > 81651abb04defb181f9c98bfcc55e077dcaea452) Ugh, don't do that. :-) Just send patche against HEAD. Thanks, Ben ___ Bug-dejagnu mailing list

Re: [Bug-dejagnu] BUG: improper format string construction in framework.exp (follow-up)

2018-10-28 Thread Jacob Bachmeyer
Ben Elliston wrote: On Sat, Oct 27, 2018 at 11:48:08PM -0500, Jacob Bachmeyer wrote: A message that contains a '%' character will cause Tcl to raise an error at the format in record_test in lib/framework.exp on line 803 as of commit 81651abb04defb181f9c98bfcc55e077dcaea452. This is a

Re: [Bug-dejagnu] BUG: improper format string construction in framework.exp

2018-10-28 Thread Jacob Bachmeyer
Ben Elliston wrote: On Sat, Oct 27, 2018 at 11:48:08PM -0500, Jacob Bachmeyer wrote: A message that contains a '%' character will cause Tcl to raise an error at the format in record_test in lib/framework.exp on line 803 as of commit 81651abb04defb181f9c98bfcc55e077dcaea452. This is a

Re: [Bug-dejagnu] BUG: improper format string construction in framework.exp

2018-10-28 Thread Ben Elliston
On Sat, Oct 27, 2018 at 11:48:08PM -0500, Jacob Bachmeyer wrote: > A message that contains a '%' character will cause Tcl to raise an > error at the format in record_test in lib/framework.exp on line 803 > as of commit 81651abb04defb181f9c98bfcc55e077dcaea452. This is a > "classic" format string