bug#33821: dejagnu command should list available commands

[Ben Elliston]

At present, 'dejagnu' with no arguments gives:

ERROR: no command given

It would be good if it listed the available commands.



___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-dejagnu

bug#33817:

[Ben Elliston]

Fixed in master.



___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-dejagnu

bug#33599: PATCH: Fix Info links

[Ben Elliston]

Fixed in commit f6341032.

Ben



___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-dejagnu

Re: [Bug-dejagnu] PATCH: more whitespace cleanup in lib/framework.exp

[Ben Elliston]

On Sat, Nov 24, 2018 at 06:51:05PM -0600, Jacob Bachmeyer wrote:

> I am unsure how I missed this earlier.

Thanks; applied. I also took care of the config directory for you.

Cheers, Ben


signature.asc
Description: PGP signature
___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-dejagnu

Re: [Bug-dejagnu] PATCH: always restore variables in multipass mode

[Ben Elliston]

On Wed, Nov 21, 2018 at 06:29:05PM -0600, Jacob Bachmeyer wrote:

>   * runtest.exp: Ensure that multipass pass variables are always
>   restored.  Previously, they were only restored if the "Go
>   digging for tests" branch was taken near the end of
>   runtest.exp.

Applied, thanks!

Ben


signature.asc
Description: PGP signature
___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-dejagnu

Re: [Bug-dejagnu] PATCH: clean up whitespace in lib/

[Ben Elliston]

On Sat, Nov 10, 2018 at 10:39:30PM -0600, Jacob Bachmeyer wrote:

>   * lib/ssh.exp: Clean up whitespace.
> 
>   * lib/remote.exp: Clean up whitespace.
>   (remote_expect): Change literal tab to "\t" in regexp.

Thanks!

Ben


signature.asc
Description: PGP signature
___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-dejagnu

Re: [Bug-dejagnu] Minor issues after merging patch "Eureka! The testsuite can now test individual tools."

[Ben Elliston]

On Tue, Nov 06, 2018 at 06:20:39PM -0600, Jacob Bachmeyer wrote:

> Can this be added to documentation somewhere, like at
> http://www.gnu.org/software/dejagnu/> in the "Request an
> Enhancement" or "Report a Bug" sections?  The "Report a Bug" section
> in particular gives instructions (which should probably be amended
> to indicate that "git diff" and "git format-patch" produce
> acceptable patches) for sending patches, so it might fit well there?
> That could be helpful for others in the future.

Fixed on the DejaGnu home page. Thanks!

Ben


signature.asc
Description: PGP signature
___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-dejagnu

Re: [Bug-dejagnu] Minor issues after merging patch "Eureka! The testsuite can now test individual tools."

[Ben Elliston]

On Thu, Nov 01, 2018 at 12:03:50AM -0500, Jacob Bachmeyer wrote:

> First, Makefile.in needs to be regenerated as automake parameters
> have changed.  The configure script is fine; the earlier patch to
> configure.ac added only comments.

I fixed that, thanks.

> Second, it seems that my approach of including ChangeLog entries in
> the patch has resulted in a duplicated ChangeLog entry for this
> patch.  Is this to be considered an unavoidable error or is there
> some change in procedures that should be made to prevent this from
> recurring?  (In other words, what, if anything, should I do
> differently in the future?  There are more patches planned.)

Generally, just paste the ChangeLog text directly into the email with
the patch following below. Don't send diffs to the ChangeLog. They
apply so rarely. I also tend to update the date stamp on the ChangeLog
entry one day ahead to the date in the submittted patch due to my
position relative to the international date line. :-)

Cheers, Ben

___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-dejagnu

Re: [Bug-dejagnu] PATCH: add message reporting tool init file search

[Ben Elliston]

On Tue, Oct 30, 2018 at 08:31:42PM -0500, Jacob Bachmeyer wrote:

> This adds a message reporting the expected location of the tool init
> file.

Applied; thanks.

Ben


signature.asc
Description: PGP signature
___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-dejagnu

Re: [Bug-dejagnu] PATCH: add comments explaining DEJAGNU in configure.ac

[Ben Elliston]

On Tue, Oct 30, 2018 at 06:46:12PM -0500, Jacob Bachmeyer wrote:

> This may help someone in the future who ends up wondering why
> configure substitutes DEJAGNU.

Thanks; applied.

Ben


signature.asc
Description: PGP signature
___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-dejagnu

Re: [Bug-dejagnu] PATCH: Eureka! The testsuite can now test individual tools.

[Ben Elliston]

On Tue, Oct 30, 2018 at 08:24:00PM -0500, Jacob Bachmeyer wrote:

> This was isolated after considering what is different between a run
> for libdejagnu and for runtest, and the first difference I noticed
> was that the libdejagnu tests run "unit" using "host_execute", which
> uses "spawn" internally, so I added a simple "spawn echo ok; expect
> ok"-like sequence to the runtest tool init file.  When that caused a
> Tcl error due to closing an invalid spawn descriptor in
> runtest_exit, I knew I had found the problem.

Well spotted. Thanks!

Cheers,
Ben

___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-dejagnu

Re: [Bug-dejagnu] BUG: improper format string construction in framework.exp

[Ben Elliston]

On Tue, Oct 30, 2018 at 08:58:46PM -0500, Jacob Bachmeyer wrote:

> Lastly, is a soft dependency on GNU awk acceptable for DejaGnu or
> would I need to rewrite my testsuite summarization tool in Tcl or
> Expect before contributing it for use with the DejaGnu testsuite?

I am happy for contributed tools like this to be written in GNU
awk. Please try and use portal AWK if you can, but if not, then
perhaps give the file a .gawk extension to make it clear that you need
GNU awk?

Cheers,
Ben

___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-dejagnu

Re: [Bug-dejagnu] BUG: improper format string construction in framework.exp (follow-up)

[Ben Elliston]

On Sun, Oct 28, 2018 at 10:08:42PM -0500, Jacob Bachmeyer wrote:

> On a related note, I note that the DejaGnu testsuite does not test
> the multipass feature, nor does the feature seem to be properly
> documented.  Where would be the best place to insert something in
> the manual describing MULTIPASS?  (And where are the DocBook sources
> in Git, or is Texinfo the master format now?  If the latter, README
> and possibly more should be updated.)

The Texinfo documentation is the definitive source now.

It would be great to have a more complete functional testsuite for
DejaGnu. Patches welcome.

Cheers, Ben


signature.asc
Description: PGP signature
___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-dejagnu

Re: [Bug-dejagnu] BUG: improper format string construction in framework.exp

[Ben Elliston]

On Sun, Oct 28, 2018 at 07:52:55PM -0500, Jacob Bachmeyer wrote:

> corrected patch: (also relative to commit
> 81651abb04defb181f9c98bfcc55e077dcaea452)

Ugh, don't do that. :-) Just send patche against HEAD.

Thanks,
Ben

___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-dejagnu

Re: [Bug-dejagnu] BUG: improper format string construction in framework.exp

[Ben Elliston]

On Sat, Oct 27, 2018 at 11:48:08PM -0500, Jacob Bachmeyer wrote:

> A message that contains a '%' character will cause Tcl to raise an
> error at the format in record_test in lib/framework.exp on line 803
> as of commit 81651abb04defb181f9c98bfcc55e077dcaea452.  This is a
> "classic" format string vulnerability, except that Tcl catches it
> and raises an error.

Thanks!

Ben


signature.asc
Description: PGP signature
___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-dejagnu

Re: [Bug-dejagnu] close_wait_program, process groups and kill /bin/sh builtin

[Ben Elliston]

Hi Richard,

Long time, no talk!

On Thu, Jul 05, 2018 at 12:24:32PM +0200, Richard Biener wrote:

> So my suggestion is to first fix the pgid computation (which would
> probably solve my other issue as well), then to either avoid using
> shell builtins by doing && (env kill -15 ... or to not rely on the
> particular semantics of multiple process kills and somehow iterate
> over $pid/$pgid.

I agree with your approach. Would you care to work up a patch? :-)

Thanks, Ben


signature.asc
Description: PGP signature
___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-dejagnu

Re: [Bug-dejagnu] Dead link

[Ben Elliston]

On Fri, Apr 13, 2018 at 03:28:59PM -0700, Caleb Fujimori wrote:

> The Expect link on the DejaGnu homepage is dead and should point to
> http://expect.sourceforge.net/
>  instead.

Thanks, fixed!

Cheers,
Ben


signature.asc
Description: PGP signature
___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-dejagnu

Re: [Bug-dejagnu] runtest --xml doesn't escape C0 control codes in XML output

[Ben Elliston]

On Fri, Aug 18, 2017 at 06:00:41PM +0300, Andrey ``Bass'' Shcheglov wrote:

> Whenever there're C0 control codes
> 
> in the output of any of the tests, "runtest --xml" doesn't properly
> escape those, producing XML which is not well-formed, e.g.:

Thanks, will fix, but patches welcome!

Cheers, Ben


signature.asc
Description: PGP signature
___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-dejagnu

Re: [Bug-dejagnu] Add missing rx-sim.exp

[Ben Elliston]

Good catch, thanks!

Ben

___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-dejagnu

Re: [Bug-dejagnu] multilib_flags is placed with the wrong order

[Ben Elliston]

If you work up a patch for DejaGnu, I think this is the right place to
fix it.

Thanks,
Ben


signature.asc
Description: Digital signature
___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-dejagnu

Re: [Bug-dejagnu] multilib_flags is placed with the wrong order

[Ben Elliston]

Where's the patch?

Cheers, Ben


signature.asc
Description: Digital signature
___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-dejagnu

Re: [Bug-dejagnu] Test suite fails in chroots

[Ben Elliston]

On Thu, Oct 16, 2008 at 10:59:03PM +0200, Ludovic Court?s wrote:

 The send: spawn id exp0 not open appears to stem from the fact that
 the file descriptor used by `send_user' is closed at this point.
 Any idea how to fix it?

Thanks for the report.  I'll look into it.

Ben


signature.asc
Description: Digital signature
___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-dejagnu

Re: [Bug-dejagnu] dg-test doesn't support nested invocations

[Ben Elliston]

Hi Rainer

 2011-02-04  Rainer Orth  r...@cebitec.uni-bielefeld.de
 
   * lib/dg.exp (dg-test): Support nested calls.

Thanks; committed.

Cheers,
Ben

___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-dejagnu

Re: [Bug-dejagnu] [PATCH] testglue: drop duplicate prototypes

[Ben Elliston]

On Fri, Apr 09, 2010 at 04:30:57AM -0400, Mike Frysinger wrote:

 Looks like when this commit was made back in 2004, it was committed
 twice by two different people and no one noticed.

Actually, I was wrong and your patch is right.  Applied, thanks,

Ben


___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-dejagnu

Re: [Bug-dejagnu] [PATCH] gdb-comm: Script confusion with a pending breakpoint

[Ben Elliston]

  The following patch fixes the problem for me.

   * config/gdb-comm.exp (gdb_comm_add_breakpoint): Handle pending 
   breakpoints.

Thanks; applied.

Ben


___
Bug-dejagnu mailing list
Bug-dejagnu@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-dejagnu