[PATCH] Add SELinux support

2009-01-28 Thread Kamil Dudka
Mon Sep 17 00:00:00 2001 From: Kamil Dudka kdu...@redhat.com Date: Wed, 28 Jan 2009 15:00:34 +0100 Subject: [PATCH] Add SELinux support. * find/defs.h: Add SELinux definitions. * find/tree.c: Add -context predicate to lookup. * find/pred.c: Handle %Z printf directive. * find/parser.c: Parse -context

[patch #4848] Patch - Support for SELinux

2009-02-10 Thread Kamil Dudka
Additional Item Attachment, patch #4848 (project findutils): File name: 0001-Add-SELinux-support.patch Size:14 KB ___ Reply to this item at: http://savannah.gnu.org/patch/?4848 ___

[patch #4848] Patch - Support for SELinux

2009-02-24 Thread Kamil Dudka
Additional Item Attachment, patch #4848 (project findutils): File name: 0001-find-add-SELinux-support.patch Size:14 KB ___ Reply to this item at: http://savannah.gnu.org/patch/?4848 ___

[patch #4848] Patch - Support for SELinux

2009-02-24 Thread Kamil Dudka
Follow-up Comment #4, patch #4848 (project findutils): * It does not update the Texinfo documentation at all! It does. The -context predicate is mentioned in 'info Finding Files Mode Bits' and the %Z printf conversion is mentioned in 'info Actions Print File Information Format Directives Size

Re: [PATCH 1/2] find: add SELinux support

2009-07-11 Thread Kamil Dudka
On Saturday 11 of July 2009 17:05:18 James Youngman wrote: From: Kamil Dudka kdu...@redhat.com * find/defs.h: Add SELinux related definitions. * find/tree.c: Add -context predicate to lookup. * find/pred.c: Handle %Z printf directive. * find/parser.c: Parse -context predicate and %Z printf

Re: [PATCH 1/2] find: add SELinux support

2009-07-13 Thread Kamil Dudka
On Sat July 11 2009 18:10:49 James Youngman wrote: On Sat, Jul 11, 2009 at 4:58 PM, Kamil Dudkakdu...@redhat.com wrote: Thanks for digging up the SELinux patch! No problem. From memory, I think the SELinux kernel support in Debian doesn't play nicely with Xen. That means that if I turn on

Re: [PATCH 1/2] find: add SELinux support

2009-07-14 Thread Kamil Dudka
Hello, On Mon July 13 2009 17:48:15 Kamil Dudka wrote: As time permits I will keep on trying to zero in this. attached are strace outputs from Fedora and Debian. I can see one suspicious place in that - this is the first main difference between Fedora and Debian: Fedora strace: open(m4

Re: [PATCH 1/2] find: add SELinux support

2009-07-14 Thread Kamil Dudka
On Tue July 14 2009 14:02:36 Kamil Dudka wrote: attached are strace outputs from Fedora and Debian. I can see one suspicious place in that - this is the first main difference between Fedora and Debian: Oops, once again: Fedora strace: open(m4, O_RDONLY|O_NONBLOCK|O_DIRECTORY|O_CLOEXEC

Re: [PATCH 1/2] find: add SELinux support

2009-07-20 Thread Kamil Dudka
On Tue July 14 2009 21:31:22 Eric Blake wrote: Kamil Dudka kdudka at redhat.com writes: In other words on Debian find does not change the working directory before calling lgetxattr syscall. That's why lgetxattr does not see the file and returns ENOENT (No such file or directory). One

Re: [PATCH 1/2] find: add SELinux support

2009-07-20 Thread Kamil Dudka
On Mon July 20 2009 13:33:23 Kamil Dudka wrote: Sorry for confusion. My previous testing was completely wrong because I ran older version of findutils on Fedora. With the current git version it fails on Fedora, too. It means something has been changed within findutils and/or gnulib

Re: [PATCH 1/2] find: add SELinux support

2009-08-06 Thread Kamil Dudka
On Thu August 6 2009 12:36:06 Kamil Dudka wrote: On Thu August 6 2009 12:16:58 Jim Meyering wrote: Kamil Dudka wrote: On Thu July 30 2009 13:57:00 Jim Meyering wrote: The attached incremental patch fixes it. Now it works on both Fedora and Debian. But unfortunately it does not work

Re: [PATCH 1/2] find: add SELinux support

2009-08-06 Thread Kamil Dudka
On Thu August 6 2009 13:23:38 Jim Meyering wrote: Kamil Dudka wrote: On Thu August 6 2009 12:16:58 Jim Meyering wrote: Kamil Dudka wrote: On Thu July 30 2009 13:57:00 Jim Meyering wrote: The attached incremental patch fixes it. Now it works on both Fedora and Debian

Re: [PATCH 1/2] find: add SELinux support

2009-08-06 Thread Kamil Dudka
On Thursday 06 of August 2009 14:01:37 Jim Meyering wrote: ... I'll move them to gnulib. Thanks! Just let me note there is no explicit dependency on the openat module (namely lib/at-func.c). Is the dependency implied somehow? Good point. I'll add that module dependency. Thanks.

Re: [PATCH 1/2] find: add SELinux support

2009-08-11 Thread Kamil Dudka
On Thu August 6 2009 18:15:28 Jim Meyering wrote: Kamil Dudka wrote: Thanks for the quick response. An incremental patch is attached for review. I'll merge it with the original patch if the change is ok. I glanced through quickly, and didn't see anything fishy. Thanks for the review! I am

[PATCH] fts: do not fail on a submount during traversal

2009-11-10 Thread Kamil Dudka
please don't shout at me I screwed it up :-) Kamil From 239d400abe783ad297b547e4e5a281cc1613ef70 Mon Sep 17 00:00:00 2001 From: Kamil Dudka kdu...@redhat.com Date: Tue, 10 Nov 2009 14:26:56 +0100 Subject: [PATCH] fts: do not fail on a submount during traversal * lib/fts.c (fts_build): Read the stat

Re: [PATCH] fts: do not fail on a submount during traversal

2009-11-12 Thread Kamil Dudka
Hi Jim, On Thu November 12 2009 12:44:48 Jim Meyering wrote: I've applied and pushed that. thanks for considering it! I adjusted the comment, since I view this addition not as a feature, but rather as a kludge to work around brokenness in the NFS4 implementation. Even though it affects

[bug #29089] SELinux --context and %Z options

2010-03-06 Thread Kamil Dudka
Follow-up Comment #1, bug #29089 (project findutils): The bug is already filled at: https://savannah.gnu.org/patch/?4848 Latest git patches available at: http://lists.gnu.org/archive/html/bug-findutils/2009-11/msg00033.html ___ Reply

[bug #29435] fd_is_cloexec () does not work on Fedora buildhosts

2010-04-04 Thread Kamil Dudka
Follow-up Comment #3, bug #29435 (project findutils): Great! built for Fedora as findutils-4.5.7-3.fc14 http://koji.fedoraproject.org/koji/buildinfo?buildID=165369 ___ Reply to this item at: http://savannah.gnu.org/bugs/?29435

assertion failures of findutils 4.5.7

2010-04-05 Thread Kamil Dudka
Hello, Sami Farin (CC'd) discovered some flaws in recent findutils and reported them at Red Hat bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=579476#c0 https://bugzilla.redhat.com/show_bug.cgi?id=579476#c2 Here are proposed patches: https://bugzilla.redhat.com/attachment.cgi?id=404487

Re: assertion failures of findutils 4.5.7

2010-04-05 Thread Kamil Dudka
On Monday 05 of April 2010 22:01:22 James Youngman wrote: I attach a set of patches. They're the same as the patches I emailed yesterday, but rebased against current head. The patches look good! I've applied all of them and built as findutils-4.5.7-4.fc14. Thanks! Kamil

[PATCH] fix bugs in run_in_dir ()

2010-05-06 Thread Kamil Dudka
Hello, attached is a patch fixing bugs of run_in_dir () which I encountered while doing backport of #19593 for stable findutils. Thanks in advance for considering the patch! Kamil diff --git a/lib/dircallback.c b/lib/dircallback.c index 8497bee..ed36ee2 100644 --- a/lib/dircallback.c +++

Re: [PATCH] fix bugs in run_in_dir ()

2010-05-06 Thread Kamil Dudka
On Thursday 06 of May 2010 15:03:32 Kamil Dudka wrote: Hello, attached is a patch fixing bugs of run_in_dir () which I encountered while doing backport of #19593 for stable findutils. Thanks in advance for considering the patch! Folow-up: diff --git a/lib/dircallback.c b/lib/dircallback.c

Re: [PATCH] fix bugs in run_in_dir ()

2010-05-07 Thread Kamil Dudka
On Friday 07 of May 2010 10:41:03 James Youngman wrote: I have applied and pushed your patch as the two attached git patches (if you could send your changes in git format-patch format in future, ideally with a ChangeLog entry too, that would streamline things for me). Sure, will do.

Re: [PATCH] fix bugs in run_in_dir ()

2010-05-07 Thread Kamil Dudka
On Friday 07 of May 2010 10:56:52 Kamil Dudka wrote: If you'd like to supply a backported format-patch patch against the 4.4.x tree, I can apply that too. It may sound stupid, but where can I get the upstream 4.4.x branch from? Hopefully I got the right one: $ git pull origin rel-4-4-fixes

[bug #29949] find -execdr does not change working directory

2010-05-24 Thread Kamil Dudka
Additional Item Attachment, bug #29949 (project findutils): File name: 0001-Fix-Savannah-bug-29949-execdir-does-not-change-worki.patch Size:2 KB ___ Reply to this item at: http://savannah.gnu.org/bugs/?29949

[PATCH 1/3] Eliminate a misleading message of import-gnulib.sh

2013-02-03 Thread Kamil Dudka
a/ChangeLog b/ChangeLog index 5bdc656..c61da2e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2013-02-03 Kamil Dudka kdu...@redhat.com + + Eliminate a misleading message of import-gnulib.sh on a fresh + repository obtained by 'git clone --recursive'. + * import-gnulib.sh

Re: [PATCH 3/3] Fix compile-time warnings.

2013-02-04 Thread Kamil Dudka
On Sunday 03 February 2013 23:07:42 Kamil Dudka wrote: diff --git a/find/exec.c b/find/exec.c index aa69fe3..f731d82 100644 --- a/find/exec.c +++ b/find/exec.c @@ -324,7 +324,7 @@ launch (struct buildcmd_control *ctl, void *usercontext, int argc, char **argv

[PATCH] Prevent 'make clean' from removing git-tracked files in lib/.

2013-02-04 Thread Kamil Dudka
/ChangeLog index d96adc0..18e44f0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2013-02-04 Kamil Dudka kdu...@redhat.com + + Prevent 'make clean' from removing git-tracked files in lib/. + * lib/Makefile.am (libfind_a_SOURCES): Move header files to EXTRA_DIST + in order

Re: [PATCH] Prevent 'make clean' from removing git-tracked files in lib/.

2013-03-25 Thread Kamil Dudka
On Sunday, March 24, 2013 14:13:23 James Youngman wrote: Thanks for the patch. However, since we used the same idiom elsewhere in the code, I thought that a more extensive change was justified. I committed the fix as

Re: I need help to use find and curl together to upload a directory

2013-08-13 Thread Kamil Dudka
On Tuesday 13 August 2013 01:35:02 Christoph Roland Murauer wrote: Am 12.08.2013 um 18:46 schrieb James Youngman j...@gnu.org: I don't clearly understand the problem you are trying to describe (you might find it helpful to review http://www.catb.org/esr/faqs/smart-questions.html). Are you

Re: Announcing the release of GNU findutils 4.5.12

2014-07-07 Thread Kamil Dudka
the following people for their contributions to this release: Andreas Metzler David Gilbert Bernhard Voelker Kamil Dudka Peter Breitenlohner Karl Berry Paul Eggert Benedikt Morbach Dmitry V. Levin Dan Jidanni Jacobson * Major changes in release 4.5.12, 2013-09-22 ** Functional

[bug #44221] Spurious warning about non-option arguments is spurious

2015-02-12 Thread Kamil Dudka
Follow-up Comment #3, bug #44221 (project findutils): That might be true in your simple case, but it does not hold in general. What about the following command for instance? find -type f -ls -a -mindepth 4 -delete ___ Reply to this item

[bug #44221] Spurious warning about non-option arguments is spurious

2015-02-10 Thread Kamil Dudka
Follow-up Comment #1, bug #44221 (project findutils): -mindepth and -maxdepth are options whereas -type is a test. You need to specify options before non-optionos (tests and actions). ___ Reply to this item at:

[PATCH] clarify exit status handling of -exec command {} +

2016-04-13 Thread Kamil Dudka
* find(-exec): Explain how exit status is propagated if the -exec command {} + syntax is used. Reported at https://bugzilla.redhat.com/1325049 --- find/find.1 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/find/find.1 b/find/find.1 index c948b4b..2c228f8 100644 --- a/find/find.1 +++

Re: [PATCH] clarify exit status handling of -exec command {} +

2016-04-18 Thread Kamil Dudka
On Sunday, April 17, 2016 22:46:22 Bernhard Voelker wrote: > On 04/13/2016 03:07 PM, Kamil Dudka wrote: > > * find(-exec): Explain how exit status is propagated if the > > -exec command {} + syntax is used. > > > > Reported at https://bugzilla.redhat.com/1325049

Re: Fwd: help us to resolve this command

2017-08-11 Thread Kamil Dudka
On Friday, August 11, 2017 16:17:30 Aman ulla wrote: > how can i run this command in our centos 7 server to get results..? It depends on which results you want to get. My suggestion is not to run commands as root unless you really understand what they do ;-) > # find /root/home/ -mindepth 1

Re: [bug #51345] find shows different results despite using same command

2017-07-07 Thread Kamil Dudka
On Wednesday, July 05, 2017 16:01:53 James Youngman wrote: > Follow-up Comment #4, bug #51345 (project findutils): > > Try again, passing also the option -noleaf to find. The -noleaf option of find is silently ignored if find is built with FTS. I proposed a gnulib patch that would allow us to

Re: Several changes made to fts.c in Gnulib

2017-07-25 Thread Kamil Dudka
On Tuesday, July 25, 2017 02:16:30 Paul Eggert wrote: > I found some subtle bugs in Gnulib fts.c, and created a test case that > reliably fails in reiserfs due to confusion with st_nlink. I added this > test case to Gnulib and fixed the bugs I found. As far as I can see, the > only problems that

Re: Several changes made to fts.c in Gnulib

2017-07-25 Thread Kamil Dudka
On Tuesday, July 25, 2017 09:10:09 Paul Eggert wrote: > Kamil Dudka wrote: > > Any chance to make the (still documented) -noleaf option of find work > > again? > I'm inclined to agree with Pádraig, in thinking that fts should Just Work > without the complexity of an ex

Re: Several changes made to fts.c in Gnulib

2017-07-26 Thread Kamil Dudka
On Wednesday, July 26, 2017 09:31:47 Paul Eggert wrote: > Kamil Dudka wrote: > > You even admitted that they could have introduced new bugs. Now you are > > refusing to push a tiny commit that would significantly help to debug them > > in environments where only binaries a

Re: Several changes made to fts.c in Gnulib

2017-07-28 Thread Kamil Dudka
On Friday, July 28, 2017 11:38:12 Paul Eggert wrote: > The only thing I'd add to that is to suggest using a high value like > 0x4000 for FTS_NOLEAF. I am fine with my current patch. If gnulib upstream introduces new flags later on, it will be not that difficult to find a free bit for

SIGSEGV in partial_quotearg_n()

2017-08-18 Thread Kamil Dudka
We have multiple occurrences of automated crash reports: https://retrace.fedoraproject.org/faf/reports/1209278/ ... about SIGSEGV in partial_quotearg_n() at this location in the source code: http://git.savannah.gnu.org/cgit/findutils.git/tree/find/ftsfind.c?h=v4.6.0#n219 I guess it crashes

Re: "find: '/usr/...': Too many open files" when using -execdir

2017-06-03 Thread Kamil Dudka
On Saturday, June 03, 2017 09:03:54 Dale R. Worley wrote: > I know I've seen something about this before: When I use -execdir, I > get a message like: > > find: '/usr/share/texlive/texmf-dist/tex4ht/ht-fonts/alias/kurier/sy-iwona': > Too many open files find: Failed to save working directory in

[bug #51841] find buffer-overflow with -printf '%T+'

2017-08-25 Thread Kamil Dudka
Follow-up Comment #1, bug #51841 (project findutils): I think that both the bug and the fix are obvious. After the mentioned patch, the code writes 12 bytes into a stack-allocated array of size 6 bytes: char fmt[6]; // [...] /* Format the main part of the time. */ if (kind == '+')

Re: SIGSEGV in partial_quotearg_n()

2017-08-29 Thread Kamil Dudka
On Monday, August 28, 2017 11:51:08 PM CEST Bernhard Voelker wrote: > On 08/18/2017 04:23 PM, Kamil Dudka wrote: > > We have multiple occurrences of automated crash reports: > > > > https://retrace.fedoraproject.org/faf/reports/1209278/ > > > > ... ab

Re: [PATCH] find: properly support -noleaf in ftsfind.

2017-09-05 Thread Kamil Dudka
On Saturday, September 2, 2017 5:35:31 PM CEST James Youngman wrote: > * gnulib-local/lib/fts.c.diff: incorporated from a patch by Kamil > Dudka <kdu...@redhat.com>. This patch introduces an FTS_NOLEAF option > to fts. > * gnulib-local/lib/fts_.h.diff: Likewise. > * find/

Re: next release version of findutils?

2018-08-09 Thread Kamil Dudka
On Thursday, August 9, 2018 8:30:39 AM CEST Bernhard Voelker wrote: > On 08/08/2018 09:49 AM, Karl Nordström wrote: > > Hi, > > > > I wanted to ask whether there is a new release for findutils comming up? > > > > I want to add it to conda-forge and am having trouble passing make > > check.

Re: next release version of findutils?

2018-08-09 Thread Kamil Dudka
in the master branch) Kamil > When the new version comes out I will update the conda recipe. > > Again, thank you for your help. > > Best, > > Karl > > On 09.08.2018 08:40, Kamil Dudka wrote: > > On Thursday, August 9, 2018 8:30:39 AM CEST Bernhard Voelk

Re: [bug #54509] `-execdir command ;` returns 0 when it should not

2018-08-15 Thread Kamil Dudka
On Tuesday, August 14, 2018 10:43:44 PM CEST Bernhard Voelker wrote: > Update of bug #54509 (project findutils): > > Status:None => In Progress > Assigned to:None => berny > >

[bug #54591] gnulib components in findutils do not compile with glibc 2.28

2018-08-29 Thread Kamil Dudka
Follow-up Comment #3, bug #54591 (project findutils): ... and the other error was fixed by http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=4af4a4a7 ___ Reply to this item at:

Re:

2018-07-23 Thread Kamil Dudka
On Sunday, July 22, 2018 10:09:49 PM CEST James Youngman wrote: > On Thu, Jul 12, 2018 at 10:37 PM, Jonathan M. Wilbur > > wrote: > > “find: ../../find/util.c:297: get_info: Assertion `p->st_ino' failed.” > > Let's start by checking the symptom directly. Assuming the problem > is easily

Re: [PATCH 5/6] fts: three levels of leaf optimization

2018-04-11 Thread Kamil Dudka
On Tuesday, April 10, 2018 9:54:26 PM CEST Bernhard Voelker wrote: > Hi Kamil, > > On 04/06/2018 09:29 AM, Kamil Dudka wrote: > > On Friday, April 6, 2018 8:08:55 AM CEST Bernhard Voelker wrote: > >> On 04/05/2018 02:44 PM, Kamil Dudka wrote: > >>> The same '

Re: [PATCH 5/6] fts: three levels of leaf optimization

2018-04-06 Thread Kamil Dudka
On Friday, April 6, 2018 8:08:55 AM CEST Bernhard Voelker wrote: > CCing bug-findutils. > original post https://lists.gnu.org/r/bug-gnulib/2018-04/msg00015.html > > On 04/05/2018 02:44 PM, Kamil Dudka wrote: > > We have a bug report where find aborts while traversing

[PATCH] find -samedev NAME: true for files on the same device as NAME

2018-11-01 Thread Kamil Dudka
There is no easy way to exclude mount points from the output of `find`. The options -xdev or -mount prevent `find` from traversing over the mount points but do not exclude the mount points themselves. It could be scripted by AWK on Linux as in the following example: $ find / -xdev -maxdepth 1

[bug #54591] gnulib components in findutils do not compile with glibc 2.28

2018-08-30 Thread Kamil Dudka
Follow-up Comment #5, bug #54591 (project findutils): I agree but I am not the one who schedules releases here. ___ Reply to this item at: ___ Message

[bug #57762] Test fail of find.posix/sv-bug-54171.exp

2020-02-10 Thread Kamil Dudka
Follow-up Comment #2, bug #57762 (project findutils): This was also reported in Red Hat Bugzilla: https://bugzilla.redhat.com/1799064 The proposed patch works for me: The test is now skipped when running with root privileges. Thank you for taking care of it!

Re: [PATCH] find.1: avoid misunderstanding of `-prtinf %Ak` description

2020-10-07 Thread Kamil Dudka
On Wednesday, October 7, 2020 12:36:56 AM CEST Bernhard Voelker wrote: > Hi Kamil, > > On 2020-10-06 17:10, Kamil Dudka wrote: > > * find/find.1 (-printf): Make it clear that strftime() format > > description in this man page is incomplete and refer to the > > strft

[PATCH] find.1: avoid misunderstanding of `-prtinf %Ak` description

2020-10-06 Thread Kamil Dudka
* find/find.1 (-printf): Make it clear that strftime() format description in this man page is incomplete and refer to the strftime() documentation instead. Suggested in https://bugzilla.redhat.com/1882695 --- find/find.1 | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

Re: findutils-4.8.0-2.fc34.x86_64

2021-08-31 Thread Kamil Dudka
On Tuesday, August 31, 2021 11:26:15 AM CEST Ricky Tigg wrote: > Tested on Fedora; findutils-4.8.0-2.fc34.x86_64 > > Hello.As noticeable in output resulting from 'find -name > ""'' , paths are duplicated. > > $ find /usr/share/icons/ -name "battery*" | head -1 >

[bug #61327] Support for birth time

2021-11-28 Thread Kamil Dudka
Follow-up Comment #3, bug #61327 (project findutils): > This directive produces an empty string if the underlying > operating system or filesystem does not support birth times. I do not think the above statement is accurate. On Linux, `find -printf %BT` produces empty string even if the