Re: [bug-gnulib] Re: [patch] byteswap module fails when building from subdir

2005-07-30 Thread Ben Pfaff
Bruno Haible <[EMAIL PROTECTED]> writes: > Oskar Liljeblad wrote: >> > byteswap.h: byteswap_.h >> > - cp $(srcdir)/$< [EMAIL PROTECTED] >> > + cp $(srcdir)/byteswap_.h [EMAIL PROTECTED] >> > mv [EMAIL PROTECTED] $@ >> >> Can you please explain why this is necessary, >> so that

Re: [bug-gnulib] some headers prevent later code from using __attribute__

2005-07-30 Thread Ben Pfaff
Bruno Haible <[EMAIL PROTECTED]> writes: > Ben Pfaff wrote: >> I would suggest using a different identifier, but if not, then it >> seems like the various versions should be the same, at least. >> Some make use of __attribute__ conditional on GCC 2.5 or later, >> others on GCC 2.8 or later. The r

Re: [bug-gnulib] some headers prevent later code from using __attribute__

2005-07-30 Thread Bruno Haible
Ben Pfaff wrote: > I would suggest using a different identifier, but if not, then it > seems like the various versions should be the same, at least. > Some make use of __attribute__ conditional on GCC 2.5 or later, > others on GCC 2.8 or later. The results are thus going to vary > based on the ord

Re: gcc 3.4.4 cast warnings?

2005-07-30 Thread James Youngman
On Sat, Jul 30, 2005 at 10:38:28AM +0200, Oskar Liljeblad wrote: > He *was* compiling it using g++. Is there a GNU coding standard > statement for 'void *' casts? No, http://www.gnu.org/prep/standards/standards.html says nothing on this subject. While some code in there does show a cast to char

Re: [bug-gnulib] Re: [patch] byteswap module fails when building from subdir

2005-07-30 Thread Bruno Haible
Oskar Liljeblad wrote: > > byteswap.h: byteswap_.h > > - cp $(srcdir)/$< [EMAIL PROTECTED] > > + cp $(srcdir)/byteswap_.h [EMAIL PROTECTED] > > mv [EMAIL PROTECTED] $@ > > Can you please explain why this is necessary, > so that I won't make the same mistake in the future again?

Re: [bug-gnulib] gcc 3.4.4 cast warnings?

2005-07-30 Thread Bruno Haible
Oskar Liljeblad wrote: > > My first guess is that the module is wrongly being compiled as C++, > > which does require the cast. > > He *was* compiling it using g++. User error. C is not a subset of C++. A C++ compiler is not a C compiler. > Is there a GNU coding standard statement for 'void *' ca

Re: $(top_builddir)/lib should also be in the include path

2005-07-30 Thread Karl Berry
$(top_builddir)/lib should also be added to the include path. Thanks Ben, I added your info to the manual. BTW, Bruno, I see you wrote a separate file documenting the visibility module. Any reason not to @include it into the manual? ___ bug-g

Re: [patch] byteswap module fails when building from subdir

2005-07-30 Thread Oskar Liljeblad
On Friday, July 29, 2005 at 21:58, Ben Pfaff wrote: Hi Ben! > This is a fix for incorrect use of $<. [..] > byteswap.h: byteswap_.h > - cp $(srcdir)/$< [EMAIL PROTECTED] > + cp $(srcdir)/byteswap_.h [EMAIL PROTECTED] > mv [EMAIL PROTECTED] $@ [..] I wrote that module. Can yo

Re: gcc 3.4.4 cast warnings?

2005-07-30 Thread Oskar Liljeblad
On Thursday, July 28, 2005 at 16:55, James Youngman wrote: > > > char *dir = xmalloc (length + append_dot + 1); > > or that it warned about it unless you change it to > > char *dir = (char *) xmalloc (length + append_dot + 1); > [...] > > Does anyone know more about this? > > My first guess