Re: yet another hello pretest

2006-11-09 Thread Ben Pfaff
Eric Blake [EMAIL PROTECTED] writes: + /* Even exiting has subtleties. The /dev/full device on GNU/Linux + can be used for testing whether writes are checked properly. For + instance, hello /dev/null should exit unsuccessfully. On exit, s%dev/null%dev/full% + if any writes

Re: yet another hello pretest

2006-11-09 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Karl Berry on 11/8/2006 5:55 PM: In case anyone is not totally bored already, one more time for gettext 0.16 (thanks Bruno)... ftp://alpha.gnu.org/gnu/hello/hello-2.1.95.tar.bz2 (or .gz) Alas, it fails to build with 'gcc -Wall

Re: [bug-gnulib] yet another hello pretest

2006-11-09 Thread Bruno Haible
Eric Blake wrote: 2006-11-09 Eric Blake [EMAIL PROTECTED] * hello.c (main): Use atexit, to avoid warning with 'gcc -Wall -Werror'. (my_exit): Delete, no longer needed. I support this patch. Using 'atexit' leads to more maintainable code than pervasive use of 'my_exit'.

Re: yet another hello pretest

2006-11-09 Thread Karl Berry
A quick review. Thanks Paul, I installed that.

Re: use of __gen_tempname

2006-11-09 Thread Eric Blake
Eric Blake ebb9 at byu.net writes: I think it is preferable to build a binary that is 1 KB bigger but continues working after an OS upgrade. Hence this proposed patch. 2006-11-06 Bruno Haible bruno at clisp.org * lib/tempname.c (gen_tempname): Remove variant that invokes

Re: yet another hello pretest

2006-11-09 Thread Karl Berry
Attached is a patch for hello.c. Thanks Eric, that's much cleaner. I installed it. the gnulib module exit, to ensure the existence of EXIT_SUCCESS. Isn't it part of some sufficiently-old standard so that it's not necessary/recommended? Solaris release that didn't support atexit

Re: yet another hello pretest

2006-11-09 Thread Paul Eggert
ftp://alpha.gnu.org/gnu/hello/hello-2.1.95.tar.bz2 (or .gz) A quick review. 1. Here's a warning I observed on Solaris 8 with Sun C 5.8: source='hello.c' object='hello.o' libtool=no \ DEPDIR=.deps depmode=none /bin/bash ../build-aux/depcomp \ cc -xarch=v9

Re: yet another hello pretest

2006-11-09 Thread Matthew Woehlke
Karl Berry wrote: the gnulib module exit, to ensure the existence of EXIT_SUCCESS. Isn't it part of some sufficiently-old standard so that it's not necessary/recommended? What is it? Using EXIT_SUCCESS, using gnulib to ensure that you have EXIT_*, using EXIT_* in general? I'm less sure

Re: yet another hello pretest

2006-11-09 Thread Ben Pfaff
Matthew Woehlke [EMAIL PROTECTED] writes: Karl Berry wrote: the gnulib module exit, to ensure the existence of EXIT_SUCCESS. Isn't it part of some sufficiently-old standard so that it's not necessary/recommended? What is it? Using EXIT_SUCCESS, using gnulib to ensure that you have EXIT_*,

Re: yet another hello pretest

2006-11-09 Thread Karl Berry
What is it? Using EXIT_SUCCESS, using gnulib to ensure that you have EXIT_*, using EXIT_* in general? It = Using EXIT_SUCCESS without using the gnulib exit module. Isn't EXIT_SUCCESS part of stdlib.h (or something) for a couple of decades now? Obviously it's no particular problem to

Re: yet another hello pretest

2006-11-09 Thread Matthew Woehlke
Ben Pfaff wrote: Matthew Woehlke writes: Karl Berry wrote: the gnulib module exit, to ensure the existence of EXIT_SUCCESS. Isn't it part of some sufficiently-old standard so that it's not necessary/recommended? What is it? Using EXIT_SUCCESS, using gnulib to ensure that you have EXIT_*,

Re: lib/gettext.h breaks --enable-gcc-warnings

2006-11-09 Thread Paul Eggert
Joel E. Denny [EMAIL PROTECTED] writes: Several functions in Gnulib's gettext.h don't use their domain and category parameters. Bison won't build with --enable-gcc-warnings as a result. Thanks for reporting this. I reproduced the problem with CVS Bison by configuring it with

Re: proposed patch to allocsa, vasnprintf for Tandem NSK (OSS)

2006-11-09 Thread Matthew Woehlke
Paul Eggert wrote: Bruno Haible [EMAIL PROTECTED] writes: Can you agree to that, Paul? I know you worked several hours on this patch, but if we carry it forward, it will cost many more hours of brain cycles in other code, like gnulib, coreutils etc. - for the sole purpose of unoptimized

Re: proposed patch to allocsa, vasnprintf for Tandem NSK (OSS)

2006-11-09 Thread Paul Eggert
Matthew Woehlke [EMAIL PROTECTED] writes: Actually, while trying to compile m4, it looks like this may indeed be a problem. OSS's sys/stat.h bombs if int64_t is not defined, Can you please explain exactly why this problem occurs? gnulib's stdint.h replacement should include the relevant system

Re: stdint_.h incorrectly assumes unsigned of 'int64_t'

2006-11-09 Thread Paul Eggert
Matthew Woehlke [EMAIL PROTECTED] writes: ...which I assume those who have been following my NSK woes will immediately spot the flaw in? :-) Thanks, I installed this patch into gnulib: 2006-11-09 Paul Eggert [EMAIL PROTECTED] * lib/stdint_.h (uintmax_t): Fix typo: int64_t -

Re: coreutils-6.4 released (stable)

2006-11-09 Thread Paul Eggert
Matthew Woehlke [EMAIL PROTECTED] writes: FYI: You probably know this, but the patch you pointed me at did not apply at all (I think one hunk in total went through), so I had to apply the changes by hand. No, I didn't know that. What happens if you omit that patch entirely? If it works

Re: lib/gettext.h breaks --enable-gcc-warnings

2006-11-09 Thread Joel E. Denny
On Thu, 9 Nov 2006, Paul Eggert wrote: Here is a proposed patch to gnulib/lib/gettext.h, which works for me: 2006-11-09 Paul Eggert [EMAIL PROTECTED] * lib/gettext.h (dgettext, dcgettext, ngettext) [! ENABLE_NLS]: (dngettext, dcngettext, bindtextdomain) [! ENABLE_NLS]: