FYI: fts.c minor readability improvement

2007-01-08 Thread Jim Meyering
I've just checked in this change: Slight readability improvement: use an assert-like macro in place of literal abort () uses. * lib/fts.c (fts_assert): Define. (fts_set_stat_required, cwd_advance_fd, fts_read, fd_ring_check): Use this macro instead of a

Re: clean-temp and large files

2007-01-08 Thread Bruno Haible
Eric Blake asks: Should we just make GL_EARLY always invoke AC_SYS_LARGEFILE, so that any application that uses gnulib automatically also supports large files? Yes. The 32-bit off_t is nowadays only historical baggage. There is normally no good reason to _not_ use AC_SYS_LARGEFILE. I'd even

Re: [PATCH] modules/error: depend on progname module

2007-01-08 Thread Bruno Haible
Eric Blake wrote: The error function uses program_name, which is defined in the progname module. Thanks for the patch; however, the current state of things in this area is intentional. error is LGPL, whereas progname is GPL. RMS does not want additional baggage accompanying the error

Re: wctype failure

2007-01-08 Thread Ralf Wildenhues
Hello Karl, * Karl Berry wrote on Mon, Jan 08, 2007 at 06:30:40PM CET: After gnulib-tool --update, texinfo cvs fails to build: gcc -DHAVE_CONFIG_H -I. -I../.. -I../../intl -g -MT mbchar.o -MD -MP -MF .deps/mbchar.Tpo -c -o mbchar.o mbchar.c In file included from mbchar.h:158,

Re: havelib: better support for OpenBSD

2007-01-08 Thread Bruno Haible
This patch simplifies the previous change. 2007-01-08 Bruno Haible [EMAIL PROTECTED] * m4/lib-link.m4 (AC_LIB_LINKFLAGS_BODY): Simplify the sorting command. --- m4/lib-link.m4 2 Jan 2007 20:53:28 - 1.18 +++ m4/lib-link.m4 8 Jan 2007 18:51:24 - @@ -1,5 +1,5 @@

Re: havelib: better support for OpenBSD

2007-01-08 Thread Ralf Wildenhues
Hello Bruno, * Bruno Haible wrote on Tue, Jan 02, 2007 at 09:50:51PM CET: The --with-libxyz-prefix option did not actually work on OpenBSD. This patch should fix it. This patch breaks building CVS M4 on GNU/Linux/x86. More generally, I think this will break all applications that use

Re: [bug-gnulib] Re: changing configure to default to gcc -g -O2 -fwrapv ...

2007-01-08 Thread Bruno Haible
Richard Kenner wrote: (3) How many programs are known to rely on wrap semantics? For each: (a) How hard was it to determine there was a problem with that assumption? A piece of data for GNU clisp and cln: - For clisp, it was easy to find out and fix all problems, because the

Re: gnulib-tool: indicating the presence of gnulib modules

2007-01-08 Thread Bruno Haible
Following Simon's comments, I backed this out and instead introduce a macro gl_MODULE_INDICATOR, for use in the module description. 2007-01-08 Bruno Haible [EMAIL PROTECTED] * m4/gnulib-common.m4: New file. * gnulib-tool (func_get_autoconf_snippet): Undo last change.

Re: canonicalize: remove redundant macro definitions

2007-01-08 Thread Bruno Haible
Hello Jim, I'd rather defer this sort of change, since it introduces a hard dependency on gnulib-tool, with only marginal added value. With this sort of change, a project that uses this module without going through gnulib-tool will not work properly. If/once we all agree that it's ok to

Re: remove redundant macro definitions

2007-01-08 Thread Bruno Haible
I applied this instead: 2007-01-08 Bruno Haible [EMAIL PROTECTED] * m4/close-stream.m4 (gl_CLOSE_STREAM): Remove GNULIB_CLOSE_STREAM macro definition. * m4/fcntl-safer.m4 (gl_FCNTL_SAFER): Remove GNULIB_FCNTL_SAFER macro definition. * m4/stdio-safer.m4

Re: gc: remove redundant macro definitions

2007-01-08 Thread Bruno Haible
Simon Josefsson wrote: It seems fine, please install it and I'll test it. I installed this instead: 2007-01-08 Bruno Haible [EMAIL PROTECTED] * m4/gc-arcfour.m4 (gl_GC_ARCFOUR): Remove GC_USE_ARCFOUR macro definition. * m4/gc-arctwo.m4 (gl_GC_ARCTWO): Remove

Re: havelib: better support for OpenBSD

2007-01-08 Thread Bruno Haible
Ralf Wildenhues wrote: This patch breaks building CVS M4 on GNU/Linux/x86. Thanks for reporting this. Does this patch (already applied to gnulib CVS) fix the problem? Bruno 2007-01-08 Bruno Haible [EMAIL PROTECTED] Avoid variable names that conflict with those from libtool.

new module unitypes

2007-01-08 Thread Bruno Haible
Here's the beginning of the Unicode library modules: the basic types. 2006-12-25 Bruno Haible [EMAIL PROTECTED] * modules/unitypes: New file. * lib/unitypes.h: New file. * MODULES.html.sh (func_all_modules): New section Unicode string functions. Move ucs4-utf8,

reorganize ucs4-utf* and utf*-ucs4 modules

2007-01-08 Thread Bruno Haible
This moves the body of the inline functions of these 4 modules to separate compilation units (rather than 'static' functions declared in a header file). 2006-12-25 Bruno Haible [EMAIL PROTECTED] * modules/utf8-ucs4 (Files, lib_SOURCES): Add unistr/utf8-ucs4.c. (Depends-on): Add

new modules utf8-ucs4-safe, utf16-ucs4-safe

2007-01-08 Thread Bruno Haible
The parsing primitives for UTF-8 and UTF-16 strings have optional (compile-time configurable) safety checks. For some purposes, variants with the safety checks always compiled in are needed. Here they are. 2006-12-25 Bruno Haible [EMAIL PROTECTED] * modules/utf8-ucs4-safe: New file.

Re: canonicalize: remove redundant macro definitions

2007-01-08 Thread Jim Meyering
Bruno Haible [EMAIL PROTECTED] wrote: I've now removed the magic from gnulib-tool's func_get_autoconf_snippet function, and instead created a gnulib-common.m4 that people not using gnulib-tool can use in their project. Hi Bruno, I'm glad you found a better way. Now we can have our cake and

Re: canonicalize: remove redundant macro definitions

2007-01-08 Thread Simon Josefsson
Bruno Haible [EMAIL PROTECTED] writes: There are actually 3 ways to use gnulib: 1) manual file copies, considering the contents of the module descriptions, 2) using a script based on the elementary --extract-... accessors of gnulib-tool, 3) using gnulib-tool --import. Do we want

Re: canonicalize: remove redundant macro definitions

2007-01-08 Thread Bruno Haible
Simon Josefsson wrote: There are actually 3 ways to use gnulib: 1) manual file copies, considering the contents of the module descriptions, 2) using a script based on the elementary --extract-... accessors of gnulib-tool, 3) using gnulib-tool --import. Do we want to

Re: fts: remove redundant macro definitions

2007-01-08 Thread Bruno Haible
2007-01-01 Bruno Haible [EMAIL PROTECTED] * m4/fts.m4 (gl_FUNC_FTS_LGPL): Remove _LGPL_PACKAGE macro definition. * lib/fts_.h (_LGPL_PACKAGE): Remove macro. Use !GNULIB_FTS instead of _LGPL_PACKAGE. * lib/fts.c: Likewise. I applied this instead. 2007-01-08 Bruno

Re: canonicalize: remove redundant macro definitions

2007-01-08 Thread Bruno Haible
2007-01-01 Bruno Haible [EMAIL PROTECTED] * m4/canonicalize.m4 (AC_FUNC_CANONICALIZE_FILE_NAME): Remove PROVIDE_CANONICALIZE_FILENAME_MODE macro definition. * lib/canonicalize.h: Test GNULIB_CANONICALIZE instead of PROVIDE_CANONICALIZE_FILENAME_MODE. I applied

Re: wctype failure

2007-01-08 Thread Paul Eggert
Ralf Wildenhues [EMAIL PROTECTED] writes: http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/8709/focus=8711 Yes, basically the problem is that you need to do a 'make distclean' after a gnulib-tool update, or after a bunch of other fairly-normal things. 'make clean' does not suffice. The

Re: [PATCH] modules/error: depend on progname module

2007-01-08 Thread Karl Berry
Documentation is indeed lacking for this topic. Sven, care to write some? I rewrote the previous msg as doc/error.texi, and just added your point about program_name and main to it. Cheers, k

Re: Building m4 on BSDI 4.0.1

2007-01-08 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Chris McGuire on 1/8/2007 12:59 PM: The second one is for you - can you locate a system header that defines wchar_t on your platform? Something like the following will be a good start, $ grep -E '(typedef|define).*wchar_t'

Re: Building m4 on BSDI 4.0.1

2007-01-08 Thread Paul Eggert
Eric Blake [EMAIL PROTECTED] writes: BSD/OS 4.1 has a bug: stdio.h and time.h must be included before - wchar.h. */ + wchar.h. + BSDI 4.0.1 has a bug: stddef.h must be included before wchar.h. */ +# include stddef.h That patch looks fine to me, except that the comment should say