Re: [Libvir] make syntax-check fails with bzr checkouts

Soren Hansen [EMAIL PROTECTED] wrote: The bzr problem was obviously that vc-list-files didn't support bzr. Failing with CVS was caused by a bashism in vc-list-files. In Ubuntu, /bin/sh points to dash instead of bash, but vc-list-files had #!/bin/sh. This patch fixes both issues: Hi Soren,

Re: [Libvir] make syntax-check fails with bzr checkouts

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 4/30/2008 4:19 AM: | - $(find ${*-*} -name Entries -print) /dev/null; | + $(find ${*:-*} -name Entries -print) /dev/null; | | Thanks for reporting that. | Note though that POSIX appears to require the behavior

Re: speed up getndelim2

Eric Blake [EMAIL PROTECTED] wrote: Wow! Check out the speedup with this patch, comparing an -O2 /bin/cut pre-patch against an unoptimized -g cut post-patch, and that's even with running /bin/cut second so it benefits from any file system caching effects. ... And all I did was make getndelim2

Re: provide inet_?to? declarations in arpa_inet.h

Bruno Haible [EMAIL PROTECTED] writes: Simon Josefsson wrote: diff --git a/m4/arpa_inet_h.m4 b/m4/arpa_inet_h.m4 index 8f530c5..baddf0d 100644 --- a/m4/arpa_inet_h.m4 +++ b/m4/arpa_inet_h.m4 @@ -32,4 +32,7 @@ AC_DEFUN([gl_ARPA_INET_H_DEFAULTS], [ GNULIB_INET_NTOP=0;

[PATCH] add tests for vc-list-files

I'm slightly leery of adding a test for a non-essential tool like vc-list-files, since everyone who uses the module will now pull in this test, and possibly get a test failure. Such a failure doesn't really matter in general -- most people don't run make syntax-check or make distcheck -- so a

[PATCH] getndelim2.c: avoid a warning from gcc

Hi Eric, This warning causes coreutils' make distcheck to fail, so I propose to fix it like this. cc1: warnings being treated as errors getndelim2.c: In function 'getndelim2': getndelim2.c:103: error: 'c' may be used uninitialized in this function make[6]: *** [getndelim2.o]

Re: [PATCH] getndelim2.c: avoid a warning from gcc

Jim Meyering jim at meyering.net writes: getndelim2.c: In function 'getndelim2': getndelim2.c:103: error: 'c' may be used uninitialized in this function You are correct that this warning is spurious - the use of c in question is guarded by a NULL buffer, and c was guaranteed to be set

Re: [PATCH] add tests for vc-list-files

Jim Meyering [EMAIL PROTECTED] wrote: I'm slightly leery of adding a test for a non-essential tool like vc-list-files, since everyone who uses the module will now pull in this test, and possibly get a test failure. Such a failure doesn't really matter in general -- most people don't run make