Bruno Haible br...@clisp.org writes:
You are right. In summary:
- GetComputerNameEx(ComputerNameDnsHostname,...) returns the right
hostname,
but it hard to use portably:
- It requires defining _WIN32_WINNT to at least 0x0500.
- With mingw, it also requires
Bruno Haible br...@clisp.org writes:
I've applied it with a few tweaks, as follows:
- Document the problem under problems fixed by Gnulib, not under
problems not fixed by Gnulib.
- Move the AC_DEFINE out of gl_PREREQ_GETHOSTNAME, since it's the
user who wants HOST_NAME_MAX; the
Bruno Haible br...@clisp.org writes:
Hi Simon,
On mingw, the gethostname test fails for me:
gethostname failed, rc -1 errno 10093
FAIL: test-gethostname.exe
The reason is that the WSAStartup function has not been called. Why not make
this initialization implicitly in the gethostname
Sergey,
the self test fails like this when used in a project:
*** ave-expected.tmpMon Aug 3 15:37:29 2009
--- - Mon Aug 3 15:37:29 2009
***
*** 1,4
! test-argp-version-etc (dummy) 0
COPYRIGHT
License GPLv3+: GNU GPL version 3 or later
Hi Simon,
the self test fails like this when used in a project:
Thanks for noticing.
How about this patch?
Nice, please push it.
Regards,
Sergey
-./test-argp-version-etc --version |
+./test-argp-version-etc${EXEEXT} --version |
sed '2s/Copyright (C) [0-9]\{4,4\} Free Software Foundation,
Inc\./COPYRIGHT/' |
+ sed '1s/test-argp-version-etc (.*) .*/test-argp-version-etc
(PROJECT) VERSION/' |
diff -c $TMP - || ERR=1
A nit: rather
one test -- test-dup2 -- recently added to the findutils test suite
is
inherently broken and may fail.
Thanks for the report.
The test (from gnulib) assumes that after (test-dup2.c line 68)
int fd = open (file, O_CREAT | O_RDWR, 0600);
fd is an open file (correct), and that fd+1,
Hi Bruno,
On Sun, Aug 2, 2009 at 5:01 AM, Bruno Haiblebr...@clisp.org wrote:
Sam Steingold wrote:
./string.h:54:5: error: #if with no expression
The 'string' module occurs as dependency of the 'memchr' module or 'mbsrtowcs'
modules.
so I added 'string' to GNULIB_MODULES and now...
Somehow
Simon Josefsson wrote:
Looks fine to me, please push it.
Pushed.
Likewise, the 'sys_utsname' and 'uname' modules are pushed as well.
Bruno
Sam Steingold wrote:
so I added 'string' to GNULIB_MODULES and now...
[all fine]
- why do I have to do that?
I have no idea why you had a half, not working 'string' module earlier.
Without a tarball with all files included, I can't tell.
Bruno
On Mon, Aug 3, 2009 at 4:11 PM, Bruno Haiblebr...@clisp.org wrote:
Sam Steingold wrote:
so I added 'string' to GNULIB_MODULES and now...
[all fine]
- why do I have to do that?
I have no idea why you had a half, not working 'string' module earlier.
Without a tarball with all files included,
The output from AM_ICONV looks like this with autoconf 2.64:
checking for iconv declaration... install-shextern size_t iconv (iconv_t cd,
char * *inbuf, size_t *inbytesleft, char * *outbuf, size_t *outbytesleft);
The reason is the use of an obsolete variable ac_t (from autoconf 2.13!).
In build-aux/update-copyright it says:
# You may wish to place a target like the following in your top-level
# makefile in your project:
#
# .PHONY: update-copyright
# update-copyright:
# if test -d .git; then \
# git grep -l -w Copyright
On Mon, 3 Aug 2009, Simon Josefsson wrote:
# You may wish to place a target like the following in your top-level
# makefile in your project:
#
# .PHONY: update-copyright
# update-copyright:
# if test -d .git; then \
# git grep -l -w
I'd rather not have to manually add this snippet to 5+ projects,
and
keep it synchronized in case of changes.
Ditto.
I thought the second grep would be specific to the project. For
example,
Bison won't exclude ChangeLog. Any files that should be left alone
for
every project could
15 matches
Mail list logo
