Re: gettimeofday in c++

2009-08-09 Thread Bruno Haible
Jim Meyering wrote: While I don't like adding casts, in this case, (accommodating C++) there is no alternative. Agreed. Applied and pushed. Bruno

Re: no-c++

2009-08-09 Thread Bruno Haible
Sam Steingold wrote in http://lists.gnu.org/archive/html/bug-gnulib/2009-08/msg00112.html: my suggestion eliminates two expensive steps: now: import the non-C++ module regenerate all autoconf files try to compile with c++, fail import no-c++ regenerate all autoconf files add NO_CXX to

avoid warnings from 'aclocal'

2009-08-09 Thread Bruno Haible
This snippet from modules/error m4_ifdef([AM_XGETTEXT_OPTION], [AM_XGETTEXT_OPTION([--flag=error:3:c-format]) AM_XGETTEXT_OPTION([--flag=error_at_line:5:c-format])]) can lead to warnings by 'aclocal'. Ralf Wildenhues kindly explained the cause of the problem [1]. It's not a problem in

[PATCH] tests: avoid warnings due to implicit declaration of memset

2009-08-09 Thread Jim Meyering
Hi Bruno, Building coreutils on Solaris 10, I saw these two warnings: test-select-fd.c: In function 'main': test-select-fd.c:47: warning: implicit declaration of function 'memset' test-select-fd.c:47: warning: incompatible implicit declaration of built-in function 'memset' CCLD

[PATCH] Exclude optimization

2009-08-09 Thread Sergey Poznyakoff
Hello, The proposed patch considerably speed-ups the exclude module for large exclusion lists of non-wildcard patterns. Ok to push? From 5421774438de3a67d89f988a0cd735e19a4cafd4 Mon Sep 17 00:00:00 2001 From: Sergey Poznyakoff g...@gnu.org.ua Date: Mon, 10 Aug 2009 00:14:45 +0300 Subject:

Re: [PATCH] Exclude optimization

2009-08-09 Thread Bruno Haible
Hello Sergey, The proposed patch considerably speed-ups the exclude module for large exclusion lists of non-wildcard patterns. Great idea! 'is_fnmatch_pattern' is probably a misnomer, because its argument is by definition already an fnmatch pattern. What the function is testing is whether it