Re: [PATCH] ignore-value() tweaks

2009-08-26 Thread Jim Meyering
Pádraig Brady wrote: > Jim Meyering wrote: >> Hmm... I guess you could be thinking about >> warnings from non-gcc compilers. Yes, that's another way in which >> (void)i is better. > > Right. > > BTW, I'm annoyed that one can't always do: (void) function(); > but I presume gcc must have a _very_ g

Re: test-parse-duration link failure

2009-08-26 Thread Bruce Korb
On Wed, Aug 26, 2009 at 2:54 PM, Bruno Haible wrote: > Hi, > > On Solaris/x86 with Sun C 5.9, test-parse-duration fails to link: > > cc -xc99=all  -g  -Wl,-z,ignore -o test-parse-duration test-parse-duration.o > ../gllib/libgnu.a -lm > ld: fatal: symbol `xstrdup' is multiply-defined: >        (fil

test-parse-duration link failure

2009-08-26 Thread Bruno Haible
Hi, On Solaris/x86 with Sun C 5.9, test-parse-duration fails to link: cc -xc99=all -g -Wl,-z,ignore -o test-parse-duration test-parse-duration.o ../gllib/libgnu.a -lm ld: fatal: symbol `xstrdup' is multiply-defined: (file test-parse-duration.o type=FUNC; file ../gllib/libgnu.a(xmall

Re: [PATCH] ignore-value() tweaks

2009-08-26 Thread Pádraig Brady
Jim Meyering wrote: > Hmm... I guess you could be thinking about > warnings from non-gcc compilers. Yes, that's another way in which > (void)i is better. Right. BTW, I'm annoyed that one can't always do: (void) function(); but I presume gcc must have a _very_ good reason for that. > How about t

Re: [PATCH] ignore-value() tweaks

2009-08-26 Thread Jim Meyering
Pádraig Brady wrote: > I noticed the use of ignore-value() recently and > was a little confused by it. How about the attached tweaks > to make it explicit it doesn't handle all return types > and also remove the use of __attribute__ ((__unused__)) > which I don't think is required. I think you're

[PATCH] ignore-value() tweaks

2009-08-26 Thread Pádraig Brady
I noticed the use of ignore-value() recently and was a little confused by it. How about the attached tweaks to make it explicit it doesn't handle all return types and also remove the use of __attribute__ ((__unused__)) which I don't think is required. cheers, Pádraig. >From c0cf06236aba3886d61272a