Re: cosl test failure

2010-03-15 Thread Paolo Bonzini
On Sun, Mar 14, 2010 at 23:18, Bruno Haible br...@clisp.org wrote: Hi Paolo, On 2010-01-18, in http://lists.gnu.org/archive/html/bug-gnulib/2010-01/msg00256.html, I observed that gnulib's cosl replacement function does not have the necessary accuracy. This was due to a wrong formula: The

Re: poll test failure on Cygwin

2010-03-15 Thread Paolo Bonzini
On Sun, Mar 14, 2010 at 23:33, Bruno Haible br...@clisp.org wrote: Hi Paolo, Eric, On Cygwin 1.5.x the 'poll' test fails like this:  Unconnected socket test... passed  Connected sockets test... passed  General socket test with fork... passed  Pipe test... failed (expecting POLLHUP after

Re: iconv_open: Build failure with gperf 2.7.2

2010-03-15 Thread Ludovic Courtès
Hi Bruno, Bruno Haible br...@clisp.org writes: Ludovic Courtès wrote: The ‘-m’ gperf option used by the ‘iconv_open’ module isn’t available in the ancient gperf 2.7.2: It is documented in gnulib's DEPENDENCIES file: Oops, right, I missed that. What should be done about it? Run

Re: iconv_open: Build failure with gperf 2.7.2

2010-03-15 Thread Ralf Wildenhues
* Ludovic Courtès wrote on Mon, Mar 15, 2010 at 10:13:45AM CET: Surprisingly, using BSD make (on FreeBSD) it tries to run gperf, whereas using GNU make it doesn’t try to (for the same build tree on the same machine). Ideas? Without checking the current issue at all, that's almost always due

Re: iconv_open: Build failure with gperf 2.7.2

2010-03-15 Thread Ludovic Courtès
Hi, Ralf Wildenhues ralf.wildenh...@gmx.de writes: * Ludovic Courtès wrote on Mon, Mar 15, 2010 at 10:13:45AM CET: Surprisingly, using BSD make (on FreeBSD) it tries to run gperf, whereas using GNU make it doesn’t try to (for the same build tree on the same machine). Ideas? Without

Re: [PATCH] (x)memcoll: performance improvement when input is known to be NUL delimited.

2010-03-15 Thread Paolo Bonzini
On 03/14/2010 03:15 PM, Bruno Haible wrote: Here, the calling convention of providing a string with a size, and the size must include the trailing NUL byte, is so unusual that the probability of a mis-use of the API is likely 10% or more. You can always use assert so that #define NDEBUG would

Petr Sumbera: [Bug-tar] tar 1.23 + verify() macro vs old compiler

2010-03-15 Thread Sergey Poznyakoff
Hello, Forwarded is a user report and a proposed patch. OK to apply? Regards, Sergey --- Forwarded message Date: Mon, 15 Mar 2010 16:37:00 +0100 From: Petr Sumbera petr.sumb...@sun.com To: bug-...@gnu.org This is a multi-part message in MIME format. -

Re: Petr Sumbera: [Bug-tar] tar 1.23 + verify() macro vs old compiler

2010-03-15 Thread Jim Meyering
Sergey Poznyakoff wrote: Hello, Forwarded is a user report and a proposed patch. OK to apply? Regards, Sergey From: Petr Sumbera petr.sumb...@sun.com To: bug-...@gnu.org Date: Mon, 15 Mar 2010 16:37:00 +0100 This is a multi-part message in MIME format. -

Re: unlink test failure on MacOS X

2010-03-15 Thread Jim Meyering
Bruno Haible wrote: Hi Jim, Eric, On MacOS X 10.5, the unlink() and unlinkat() tests fail: test-unlink.h:49: assertion failed /bin/sh: line 1: 17670 Abort trap EXEEXT='' srcdir='.' ${dir}$tst FAIL: test-unlink test-unlink.h:49: assertion failed /bin/sh: line 1:

Re: Petr Sumbera: [Bug-tar] tar 1.23 + verify() macro vs old compiler

2010-03-15 Thread Sergey Poznyakoff
Jim Meyering j...@meyering.net ha escrit: However, it'd be slightly better not to separate the declaration of p and that first use, so please move it one line higher, so that the verify stmt is the first in the block. That's what I thought. Pushed. Regards, Sergey

Re: [PATCH] (x)memcoll: performance improvement when input is known to be NUL delimited.

2010-03-15 Thread Jim Meyering
Paolo Bonzini wrote: On 03/14/2010 03:15 PM, Bruno Haible wrote: Here, the calling convention of providing a string with a size, and the size must include the trailing NUL byte, is so unusual that the probability of a mis-use of the API is likely 10% or more. You can always use assert so

Re: abort vs. assert

2010-03-15 Thread Bruno Haible
Jim Meyering wrote: These days, I prefer to use assert(e) over if (!e) abort();. We used to have to avoid using assert due to portability issues, but those went away many years ago. I disagree. The reason why I never use 'assert(e)' is to make sure the safety checks are actually present.

Re: abort vs. assert

2010-03-15 Thread Jim Meyering
Bruno Haible wrote: Jim Meyering wrote: These days, I prefer to use assert(e) over if (!e) abort();. We used to have to avoid using assert due to portability issues, but those went away many years ago. I disagree. The reason why I never use 'assert(e)' is to make sure the safety checks are

Re: lib-ignore: link error with Sun C++ compiler

2010-03-15 Thread Ralf Wildenhues
Hi Bruno, * Bruno Haible wrote on Sun, Mar 14, 2010 at 05:07:33PM CET: But this does not fix the problem with coreutils, as long as it has some source files in C++. I would therefore find it useful to change lib-ignore.m4 so that it sets an AC_SUBSTed variable IGNORE_UNUSED_LIBS, and

Re: abort vs. assert

2010-03-15 Thread Bruno Haible
Hi Jim, You might just as well define and use your own macro, #define ASSERT(e) do { if (!(e)) abort (); } while (0) Oh yes, this one is perfectly fine with me. you assert a condition rather than testing its negation. Good point. Yes, I too get confused when reading through a bunch of

Re: bootstrap: allow more than one submodule

2010-03-15 Thread Eric Blake
On 03/14/2010 07:14 AM, Bruno Haible wrote: Hi Eric, As I understand it, 'bootstrap' currently updates all submodules when it wants to update only the gnulib submodule. Correct. What about packages that will have other submodules? What's the use case for updating some, but not all,

Re: [PATCH] Clean environment for GIT test

2010-03-15 Thread Eric Blake
On 03/15/2010 09:20 AM, Bert Wesarg wrote: Unset GIT_DIR and GIT_WORK_TREE environment variable in test test-vc-list-files-git.sh. --- diff --git i/tests/test-vc-list-files-git.sh w/tests/test-vc-list-files-git.sh --- i/tests/test-vc-list-files-git.sh +++ w/tests/test-vc-list-files-git.sh

Re: unlink test failure on MacOS X

2010-03-15 Thread Eric Blake
On 03/14/2010 06:16 PM, Bruno Haible wrote: Hi Jim, Eric, On MacOS X 10.5, the unlink() and unlinkat() tests fail: test-unlink.h:49: assertion failed /bin/sh: line 1: 17670 Abort trap EXEEXT='' srcdir='.' ${dir}$tst FAIL: test-unlink Thanks for investigating. This