Re: [PATCH] Fix use of ENABLE_NLS (which is not always defined)

2010-03-16 Thread Grégoire Sutre
Hi, I just discovered your answers [1, 2] on this subject (I'm not registered to the bug-gnulib mailing list). Thanks for the explanations. I take note that Gnulib does not support use of -Wundef. I just want to add that I find it good practice to avoid evaluating undefined identifiers in #if

Re: ‘pty’ module fails on FreeBSD 7.2

2010-03-16 Thread Ralf Wildenhues
Hello Ludovic, * Ludovic Courtès wrote on Tue, Mar 16, 2010 at 10:52:11AM CET: > checking whether forkpty is declared... no > checking whether forkpty is declared... (cached) no > Looking at pty.m4, I’m wondering whether the second > ‘AC_CHECK_DECL([forkpty]...])’ is actually performed; it seems

Re: warn-on-use Makefile.am: $$p

2010-03-16 Thread Ralf Wildenhues
Hello Sam, * Sam Steingold wrote on Tue, Mar 16, 2010 at 08:04:36PM CET: > warn-on-use.h: $(build_aux)/warn-on-use.h > $(AM_V_GEN)rm -f $...@-t $@ && \ > sed -n -e '/^.ifndef/,$$p' \ > < $(build_aux)/warn-on-use.h \ > > $...@-t && \ > what is "$$p"? Part of a sed comm

warn-on-use Makefile.am: $$p

2010-03-16 Thread Sam Steingold
modules/warn-on-use has this: Makefile.am: BUILT_SOURCES += warn-on-use.h # The warn-on-use.h that gets inserted into generated .h files is the same as # build-aux/warn-on-use.h, except that it has the copyright header cut off. warn-on-use.h: $(build_aux)/warn-on-use.h $(AM_V_GEN)rm -f $.

Re: arg-nonnull.h & warn-on-use.h in build-aux

2010-03-16 Thread Sam Steingold
Eric Blake wrote: On 03/08/2010 11:34 AM, Sam Steingold wrote: Sam Steingold wrote: Alternatively, I would be reasonably happy with sed -i -e 's/_GL_ARG_NONNULL/GL_ARG_NONNULL/' arg-nonnull.h sed -i -e 's/_GL_WARN_ON_USE/GL_WARN_ON_USE/' warn-on-use.h similar to GL_LINK_WARNING in link-warning.

Re: status of new 'c++defs' module?

2010-03-16 Thread John W. Eaton
An additional problem showed up on OS X systems: libtool: compile: g++-4.2 -DHAVE_CONFIG_H -I. -I.. -I/sw/lib/flex/include -I/sw/include -O0 -g -m32 -I/sw/include/freetype2 -I/sw/include/qhull -I/usr/include -I../libgnu -I../libgnu -I../libcruft/misc -I../liboctave -I../liboctave -I. -I. -I/

Re: status of new 'c++defs' module?

2010-03-16 Thread John W. Eaton
On 13-Mar-2010, Bruno Haible wrote: | Good point. I'm adding this as an extra check in the testsuite: Thanks for the additional changes. I modified the Octave sources so that GNULIB_NAMESPACE is defined to gnulib and tagged all the uses that were reported by GCC warnings. Everything worked fine

Re: bootstrap: allow more than one submodule

2010-03-16 Thread Eric Blake
On 03/16/2010 04:16 AM, Bruno Haible wrote: > Hi Eric, > >> What's the use case for updating some, but not all, submodules? > > Imagine a package that has submodules 'gnulib', 'libxml', 'libcroco' > (like GNU gettext might have). It would be perfectly normal for the > developer to stay with the l

Re: bootstrap: allow more than one submodule

2010-03-16 Thread Bruno Haible
Hi Eric, > What's the use case for updating some, but not all, submodules? Imagine a package that has submodules 'gnulib', 'libxml', 'libcroco' (like GNU gettext might have). It would be perfectly normal for the developer to stay with the last known good libxml and libcroco but try the newest gnu

‘pty’ module fails on FreeBSD 7.2

2010-03-16 Thread Ludovic Courtès
Hi Simon, [Adding bug-gnu...@gnu.org.] Simon Josefsson writes: > Simon Josefsson writes: > >> l...@gnu.org (Ludovic Courtès) writes: >> >>> Next one is this (FreeBSD): >>> >>> gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -I.. -I../lib -I../lib >>> -I../libinetutils-g -O2 -c pty.c >>> pty.c

[PATCH v2] Clean environment for GIT test

2010-03-16 Thread Bert Wesarg
Unset GIT_DIR and GIT_WORK_TREE environment variable in test test-vc-list-files-git.sh. --- tests/test-vc-list-files-git.sh |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/tests/test-vc-list-files-git.sh b/tests/test-vc-list-files-git.sh index 7b7ff1a..102bdec 100755 ---

Re: abort vs. assert

2010-03-16 Thread Paolo Bonzini
On Mon, Mar 15, 2010 at 22:36, Bruno Haible wrote: > Hi Jim, > >> You might just as well define and use your own macro, >> >>     #define ASSERT(e) do { if (!(e)) abort (); } while (0) > > Oh yes, this one is perfectly fine with me. But it wouldn't protect you from #define abort __builtin_unreac

Re: poll test failure on Cygwin

2010-03-16 Thread Paolo Bonzini
>> On the other hand, poll/select are broken on Windows for pipes anyway >> (and not fixable), so they probably shouldn't be tested in >> test-poll/test-select. > > Maybe for native Windows pipes, but cygwin can implement Unix pipes > using something other than native Windows pipes and get correct