Re: bug#6331: [sshfs] df reports wrong disk space usage on solaris

2010-06-16 Thread Miklos Szeredi
On Wed, 16 Jun 2010, Jim Meyering wrote: Miklos Szeredi wrote: On Thu, 03 Jun 2010, Miklos Szeredi wrote: Hmm, actually struct statfs on linux does have f_frsize, only the manpage doesn't document it. So correct thing would be to use that, no? Here's a patch that allows df(1) to

Re: bug#6331: [sshfs] df reports wrong disk space usage on solaris

2010-06-16 Thread Jim Meyering
Miklos Szeredi wrote: On Wed, 16 Jun 2010, Jim Meyering wrote: Miklos Szeredi wrote: On Thu, 03 Jun 2010, Miklos Szeredi wrote: Hmm, actually struct statfs on linux does have f_frsize, only the manpage doesn't document it. So correct thing would be to use that, no? Here's a patch

Re: bug#6331: [sshfs] df reports wrong disk space usage on solaris

2010-06-16 Thread Jim Meyering
Bruno Haible wrote: Hi Jim, However, I'm not sure it's portable enough. Do you know when the f_frsize member began to be useful? Without knowing that, I cannot judge whether this introduces a portability problem on older glibc, kernels or file systems. There are also other platforms than

Re: [sshfs] bug#6331: df reports wrong disk space usage on solaris

2010-06-16 Thread Miklos Szeredi
On Wed, 16 Jun 2010, Jim Meyering wrote: Miklos Szeredi wrote: On Wed, 16 Jun 2010, Jim Meyering wrote: Miklos Szeredi wrote: On Thu, 03 Jun 2010, Miklos Szeredi wrote: Hmm, actually struct statfs on linux does have f_frsize, only the manpage doesn't document it. So correct thing