Re: msvc-inval: more options

2011-09-28 Thread Jim Meyering
Bruno Haible wrote: FAIL: test-fgetc.exe FAIL: test-fputc.exe FAIL: test-fread.exe FAIL: test-fwrite.exe All these fail on a stream whose file descriptor has been closed. Most libraries won't do such a thing. Therefore I don't find it worth to fix this. Just document it. But two of the

Fwd: Getting AC_PROG_CC_C99

2011-09-28 Thread Gary V. Vaughan
From a private discussion about preventing CFLAGS getting -std=gnu99 twice, that leads to a bug report for gnulib and maybe autoconf too... Begin forwarded message: From: Gary V. Vaughan g...@gnu.org Subject: Re: Getting AC_PROG_CC_C99 Date: 28 September 2011 12:38:33 GMT+07:00 To: Reuben

Re: msvc-inval: more options

2011-09-28 Thread Bruno Haible
Hi Jim, I noticed that the latest from gnulib's tests gets some new warnings when compiled on Fedora 15: test-fread.c: In function 'main': test-fread.c:43:3: error: implicit declaration of function 'gl_msvc_inval_ensure_handler' [-Werror=implicit-function-declaration] Oops, yes,

Re: msvc-inval: more options

2011-09-28 Thread Jim Meyering
Bruno Haible wrote: I noticed that the latest from gnulib's tests gets some new warnings when compiled on Fedora 15: test-fread.c: In function 'main': test-fread.c:43:3: error: implicit declaration of function gl_msvc_inval_ensure_handler' [-Werror=implicit-function-declaration]

Re: msvc-inval: more options

2011-09-28 Thread Bruno Haible
Jim Meyering wrote: -#if MSVC_INVALID_PARAMETER_HANDLING == DEFAULT_HANDLING +#if HAVE_MSVC_INVALID_PARAMETER_HANDLER \ + MSVC_INVALID_PARAMETER_HANDLING == DEFAULT_HANDLING gl_msvc_inval_ensure_handler (); #endif That is a detail specific to MSVC. Why impose the readability

Re: msvc-inval: more options

2011-09-28 Thread Jim Meyering
Bruno Haible wrote: Jim Meyering wrote: -#if MSVC_INVALID_PARAMETER_HANDLING == DEFAULT_HANDLING +#if HAVE_MSVC_INVALID_PARAMETER_HANDLER \ + MSVC_INVALID_PARAMETER_HANDLING == DEFAULT_HANDLING gl_msvc_inval_ensure_handler (); #endif That is a detail specific to MSVC. Why

Re: Fwd: Getting AC_PROG_CC_C99

2011-09-28 Thread Paul Eggert
On 09/28/11 01:52, Gary V. Vaughan wrote: Might as well try to fix it right in gnulib though, and maybe in autoconf too if the latest release hasn't made it multi-call safe yet. The simplest fix would be something like the patch at the end of this message. This matches common practice anyway;

Re: Fwd: Getting AC_PROG_CC_C99

2011-09-28 Thread Bruno Haible
Paul Eggert wrote: The simplest fix would be something like the patch at the end of this message. diff --git a/modules/stdarg b/modules/stdarg index 84d3e7b..ab3436e 100644 --- a/modules/stdarg

Re: Fwd: Getting AC_PROG_CC_C99

2011-09-28 Thread Paul Eggert
On 09/28/11 09:45, Bruno Haible wrote: If the package's configure.ac already invokes AC_PROG_CC_STDC, early on (i.e. usually right after AC_PROG_CC), then gnulib's AC_REQUIRE([AC_PROG_CC_STDC]) will be a no-op. Ah, sorry, then we're fine as-is, since it's normal practice to put the

Re: Getting AC_PROG_CC_C99

2011-09-28 Thread Gary V. Vaughan
On 29 Sep 2011, at 00:58, Paul Eggert wrote: On 09/28/11 09:45, Bruno Haible wrote: If the package's configure.ac already invokes AC_PROG_CC_STDC, early on (i.e. usually right after AC_PROG_CC), then gnulib's AC_REQUIRE([AC_PROG_CC_STDC]) will be a no-op. Ah, sorry, then we're fine as-is,