warning: case value '0' not in enumerated

2015-02-07 Thread Bruce Korb
gc-gnulib.c: In function 'gc_hash_open': gc-gnulib.c:669:5: warning: case value '0' not in enumerated type 'Gc_hash_mode' [-Wswitch] case 0: ^ diff --git a/lib/gc-gnulib.c b/lib/gc-gnulib.c index a1276c9..ee60f85 100644 --- a/lib/gc-gnulib.c +++ b/lib/gc-gnulib.c @@ -664,15 +664,8 @@

Re: warning: case value '0' not in enumerated

2015-02-07 Thread Paul Eggert
Thanks, I installed the attached slightly-different patch. From 00b5abcff31d86a9831b586421bfe89d36dbeda9 Mon Sep 17 00:00:00 2001 From: Paul Eggert egg...@cs.ucla.edu Date: Sat, 7 Feb 2015 15:09:00 -0800 Subject: [PATCH] crypto/gc: fix a -Wswitch warning Reported by Bruce Korb in:

Re: diffseq: Segfault if two vectors are entirely different

2015-02-07 Thread Paul Eggert
Philip Chimento wrote: ctxt.bdiag = work_buffer + expected_limit + actual_limit + 3; That should be ctxt.bdiag = ctxt.fdiag + expected_limit + actual_limit + 3;, and I expect that explains your trouble.

[PATCH 2/2] fstrcmp: don't assume strlen INT_MAX

2015-02-07 Thread Paul Eggert
* lib/fstrcmp.c: Include stddef.h and stdint.h. (uintptr_t): Remove, as we're now assuming stdint. (OFFSET, EXTRA_CONTEXT_FIELDS, fstrcmp_bounded): Prefer ptrdiff_t to int when the value could exceed INT_MAX if the input string is long. (fstrcmp_bounded): Check for size-calculation overflow.

[PATCH 1/2] diffseq: prefer ptrdiff_t to ssize_t

2015-02-07 Thread Paul Eggert
* lib/diffseq.h: In commentary, prefer ptrdiff_t to ssize_t. ptrdiff_t is the natural type for signed indexes. On a few older platforms, ssize_t is narrower than size_t. --- ChangeLog | 5 + lib/diffseq.h | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/ChangeLog

[PATCH] xalloc: fix typo that suppressed warnings

2015-02-07 Thread Paul Eggert
* lib/xalloc.h: Add missing _GL_INLINE_HEADER_END. This typo, introduced a couple of years ago, mistakenly suppressed some -Wsuggest-attribute=const, -Wmissing-prototypes, and -Wmissing-declarations warnings. --- ChangeLog| 6 ++ lib/xalloc.h | 1 + 2 files changed, 7 insertions(+) diff

Re: bug#19808: Typo in lib/full-read.h license notice.

2015-02-07 Thread Paul Eggert
Thanks for reporting that problem. I fixed it by installing the attached patch into gnulib; this should eventually percolate into the next coreutils release. I guess an old s/write/read/ substitution bled into the copyright notice, and when we updated notices to point to www.gnu.org we didn't