FYI: dfa: add an assertion to avoid coverity false positive

2016-12-13 Thread Jim Meyering
It took me a few minutes to convince myself that a coverity warning was unwarranted, so I've added an assert that should suppress it. If someone sees a better way (i.e., with no assertion), please suggest a patch. From 744c745300fa7b1c73dd9f6b323d3bf4823857e6 Mon Sep 17 00:00:00 2001 From: Jim

Re: [Grep-devel] patches for removing DFA_CASE_FOLD

2016-12-13 Thread arnold
Paul Eggert wrote: > On 12/13/2016 12:26 PM, Arnold Robbins wrote: > > - dfa->syntax.case_fold = (dfaopts & DFA_CASE_FOLD) != 0; > > + dfa->syntax.case_fold = (bits & RE_ICASE) != 0 > > I'm afraid that didn't work, due to a missing semicolon. I fixed that > up, fiddled

Re: [Grep-devel] patches for removing DFA_CASE_FOLD

2016-12-13 Thread Jim Meyering
On Tue, Dec 13, 2016 at 2:51 PM, Paul Eggert wrote: > On 12/13/2016 12:26 PM, Arnold Robbins wrote: >> >> - dfa->syntax.case_fold = (dfaopts & DFA_CASE_FOLD) != 0; >> + dfa->syntax.case_fold = (bits & RE_ICASE) != 0 > > > I'm afraid that didn't work, due to a missing

Re: [Grep-devel] patches for removing DFA_CASE_FOLD

2016-12-13 Thread Paul Eggert
On 12/13/2016 12:26 PM, Arnold Robbins wrote: - dfa->syntax.case_fold = (dfaopts & DFA_CASE_FOLD) != 0; + dfa->syntax.case_fold = (bits & RE_ICASE) != 0 I'm afraid that didn't work, due to a missing semicolon. I fixed that up, fiddled with the commit messages, updated grep submodules, and

Re: Small change needed for link.m4

2016-12-13 Thread Pádraig Brady
On 13/12/16 17:43, John W. Eaton wrote: > The test in link.m4 needs to include to provide a declaration > for the rename function. The test fails if building with GCC's > -Werror=implicit-function-declaration option. > > This was reported as part of a bug with building Octave on Fedora, which

Small change needed for link.m4

2016-12-13 Thread John W. Eaton
The test in link.m4 needs to include to provide a declaration for the rename function. The test fails if building with GCC's -Werror=implicit-function-declaration option. This was reported as part of a bug with building Octave on Fedora, which now uses -Werror=implicit-function-declaration

Re: MSVC and fseeko.c

2016-12-13 Thread Bruno Haible
Gisle Vanem wrote: > Bruno Haible wrote: > > > $ ./gnulib-tool --create-testdir --dir=/tmp/testdir-stdioext --with-tests \ > > --single-configure --avoid=havelib-tests \ > > fseterr freadable fwritable fbufmode freading fwriting \ > > freadptr

Re: MSVC and fseeko.c

2016-12-13 Thread Gisle Vanem
Bruno Haible wrote: > $ ./gnulib-tool --create-testdir --dir=/tmp/testdir-stdioext --with-tests \ > --single-configure --avoid=havelib-tests \ > fseterr freadable fwritable fbufmode freading fwriting \ > freadptr freadseek freadahead fpurge fseeko

Re: MSVC and fpending

2016-12-13 Thread Bruno Haible
Jim Meyering wrote: > That sounds good, and your patch looks fine. > Thanks for taking that on. OK. Pushed. Bruno -- In memoriam the victims of the Massacre of Margarita Belén