Re: Unused parameter in binary-io.h?

On 5 March 2018 at 23:32, Paul Eggert wrote: > On 03/05/2018 01:50 PM, Reuben Thomas wrote: >> >> Is there some reason that the unused parameter is not suitably >> decorated for gcc? > > > I expect it is because nobody has gotten around to it. I installed the > attached.

Re: Unused parameter in binary-io.h?

On 03/05/2018 01:50 PM, Reuben Thomas wrote: Is there some reason that the unused parameter is not suitably decorated for gcc? I expect it is because nobody has gotten around to it. I installed the attached. >From 746fe7d6c56f87e9f51679acf2f7b8464520baac Mon Sep 17 00:00:00 2001 From: Paul

Unused parameter in binary-io.h?

I get the following warnings when compiling with that header on a GNU system: ../lib/binary-io.h: In function ‘__gl_setmode_check’: ../lib/binary-io.h:62:25: warning: unused parameter ‘fd’ [-Wunused-parameter] __gl_setmode_check (int fd) { return 0; } Is there some reason that the unused

Re: fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

On 03/05/2018 11:20 AM, Daniel P. Berrangé wrote: Yes, this worked on rawhide when I tested with libvirt. Thanks, I installed it into Gnulib since it was breaking builds. Bruno's the expert here, and perhaps he can come up with something better.

Re: fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

On Mon, Mar 05, 2018 at 11:00:40AM -0800, Paul Eggert wrote: > On 03/05/2018 04:19 AM, Daniel P. Berrangé wrote: > > I'm curious why we're trying to replace fseeko impl at all, since I > > would expect the modern glibc impl to be suitable to use as-is. > > It's to work around glibc bug#12799, a

Re: fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

On 03/05/2018 04:19 AM, Daniel P. Berrangé wrote: I'm curious why we're trying to replace fseeko impl at all, since I would expect the modern glibc impl to be suitable to use as-is. It's to work around glibc bug#12799, a longstanding bug with ungetc and fflush. See the bug-gnulib thread that

Re: [libvirt] fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

On Mon, Mar 05, 2018 at 12:19:24PM +, Daniel P. Berrangé wrote: > Fedora rawhide has just upgraded to the latest glibc git master snapshot, > of what will become the 2.28 release, and this has exposed bugs in gnulib's > fseeko.c implementation (and probably more macros) besides. > > The issue

fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)

Fedora rawhide has just upgraded to the latest glibc git master snapshot, of what will become the 2.28 release, and this has exposed bugs in gnulib's fseeko.c implementation (and probably more macros) besides. The issue starts are line 50: