Re: hash, xhash: modernize

2020-10-16 Thread Jim Meyering
On Fri, Oct 16, 2020 at 7:32 PM Bruno Haible wrote: > Hi Jim, > > > > I tried to make it clear the last time we discussed this (long ago!) > > > that I prefer to keep certain comments very near the function > > > definition (and implementation). > > Yes, I sort of remembered this. Therefore I

Re: hash, xhash: modernize

2020-10-16 Thread Bruno Haible
Hi Jim, > > I tried to make it clear the last time we discussed this (long ago!) > > that I prefer to keep certain comments very near the function > > definition (and implementation). Yes, I sort of remembered this. Therefore I asked for objections, and put you in CC. > > I disagree with the

Re: hash, xhash: modernize

2020-10-16 Thread Jim Meyering
On Fri, Oct 16, 2020 at 6:07 PM Jim Meyering wrote: > [I wrote this two or so days ago, but see now somehow I failed to send it] > On Sun, Oct 11, 2020 at 2:58 PM Bruno Haible wrote: > > It has been reported today that looking at the 'hash' module made Marc guess > > incorrectly what is desired

Re: hash, xhash: modernize

2020-10-16 Thread Jim Meyering
[I wrote this two or so days ago, but see now somehow I failed to send it] On Sun, Oct 11, 2020 at 2:58 PM Bruno Haible wrote: > It has been reported today that looking at the 'hash' module made Marc guess > incorrectly what is desired coding style and terminology in Gnulib. I do not desire to

Re: hash, xhash: modernize

2020-10-16 Thread Bruno Haible
I wrote 5 days ago: > Here are proposed patches to modernize the 'hash' and 'xhash' modules in > this respect. > > > Objections? There were no objections. So I pushed this. Bruno