Re: warnings from MacOS clang

2021-05-27 Thread arnold
Paul Eggert wrote: > On 5/27/21 1:46 PM, Eric Blake wrote: > > > Yet another portable solution is: > > > > static mbstate_t s1; > > mbstate_t s = s1; > > > > also with its own form of ugliness. > > I did that years ago, but compilers complained about it when I made s1 > 'const', and I vaguely

Re: warnings from MacOS clang

2021-05-27 Thread Paul Eggert
On 5/27/21 1:46 PM, Eric Blake wrote: Yet another portable solution is: static mbstate_t s1; mbstate_t s = s1; also with its own form of ugliness. I did that years ago, but compilers complained about it when I made s1 'const', and I vaguely recall complaints even when it wasn't 'const' ("W

Re: warnings from MacOS clang

2021-05-27 Thread Eric Blake
On Wed, May 12, 2021 at 12:16:54PM +0200, Bruno Haible wrote: > > > dfa.c:1627:19: warning: suggest braces around initialization of subobject > > > [-Wmissing-braces] > > > mbstate_t s = { 0 }; > > > ^ > > > {} > > > 1 warning generated. > > { 0 } is the

Re: test suite failure caused by check-copyright script

2021-05-27 Thread Maxim Cournoyer
Hi Bruno, Bruno Haible writes: >> Sounds good! >> >> /Simon > > Thanks for all your voices. > > I plan to start implementing this decision this week-end. Yay! I'll be happy to test it again after then, and report any remaining problem there may be with running the test suite, so feel free to

Re: test suite failure caused by check-copyright script

2021-05-27 Thread Bruno Haible
> Sounds good! > > /Simon Thanks for all your voices. I plan to start implementing this decision this week-end. Bruno

Re: test suite failure caused by check-copyright script

2021-05-27 Thread Simon Josefsson via Gnulib discussion list
Bruno Haible writes: > Maxim Cournoyer wrote: >> I'm discovering this project and attempted to run 'make check'. It >> seems to be finding problems, failing with: >> >> --8<---cut here---start->8--- >> [...] >> GPL?? lib/xstrtoull.c >>

Re: test suite failure caused by check-copyright script

2021-05-27 Thread Jim Meyering
On Sun, May 23, 2021, 8:05 AM Bruno Haible wrote: > Does everyone still agree > - to put into the source files a license header that is consistent > with the module description, and > - to remove the statement from the documentation > "The source files always say "GPL", but the real l