Re: [PATCH] lib/getrandom.c: fix build with uclibc < 1.0.35

2021-11-30 Thread Paul Eggert
Thanks for checking; I installed the attached.From 217f0da0ed9bc24792791ad83133c6547acfc899 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Tue, 30 Nov 2021 17:50:01 -0800 Subject: [PATCH] sys_random: port better to uClibc < 1.0.35 Problem reported by Fabrice Fontaine in:

Re: [PATCH] lib/getrandom.c: fix build with uclibc < 1.0.35

2021-11-30 Thread Fabrice Fontaine
Le mar. 30 nov. 2021 à 22:46, Paul Eggert a écrit : > > On 11/30/21 13:36, Fabrice Fontaine wrote: > > Should I send a new patch ? > > Would something like the following work? Yes, I can confirm that the build failure is fixed with this patch. > > diff --git a/lib/sys_random.in.h

Re: [PATCH] lib/getrandom.c: fix build with uclibc < 1.0.35

2021-11-30 Thread Paul Eggert
On 11/30/21 13:36, Fabrice Fontaine wrote: Should I send a new patch ? Would something like the following work? diff --git a/lib/sys_random.in.h b/lib/sys_random.in.h index 1abd6c544e..fdc84e0806 100644 --- a/lib/sys_random.in.h +++ b/lib/sys_random.in.h @@ -23,8 +23,10 @@ #if

Re: [PATCH] lib/getrandom.c: fix build with uclibc < 1.0.35

2021-11-30 Thread Fabrice Fontaine
Le mar. 30 nov. 2021 à 22:00, Paul Eggert a écrit : > > On 11/30/21 09:29, Fabrice Fontaine wrote: > > > > +#include > > #include > > This surely isn't the right fix, as is supposed to > include on uClibc. See gnulib/lib/sys_random.in.h's comment > about uClibc. Could you investigate why

Re: [PATCH] lib/getrandom.c: fix build with uclibc < 1.0.35

2021-11-30 Thread Paul Eggert
On 11/30/21 09:29, Fabrice Fontaine wrote: +#include #include This surely isn't the right fix, as is supposed to include on uClibc. See gnulib/lib/sys_random.in.h's comment about uClibc. Could you investigate why that part of sys/random.h isn't working on your platform?

[PATCH] lib/getrandom.c: fix build with uclibc < 1.0.35

2021-11-30 Thread Fabrice Fontaine
Fix the following build failure with uclibc < 1.0.35 which is raised since the addition of getrandom module in https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=682cc4e678aceff32dea2a84b6e5147bdf5a20a7: In file included from ./sys/random.h:40, from getrandom.c:22:

Re: compiling with tcc fails on regex.c since commit 56b32251

2021-11-30 Thread Benno Schulenberg
Op 27-11-2021 om 10:01 schreef Paul Eggert: > tcc is failing because it claims to support C99 (it > defines __STDC_VERSION__ to 199901L), but it doesn't support variable length > arrays as C99 requires. Perhaps you could file a bug report with the tcc > folks? Reported as