Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-02-20 Thread George Valkov
> On 2023-02-20, at 11:14 PM, Pádraig Brady wrote: > > On 20/02/2023 19:35, George Valkov wrote: >>> On 2023-02-20, at 7:49 PM, Pádraig Brady wrote: >>> >>> On 20/02/2023 15:02, George Valkov wrote: Hi Paul, the following tests fail after your patch: FAIL: tests/split/filter.sh

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-02-20 Thread Pádraig Brady
On 20/02/2023 19:35, George Valkov wrote: On 2023-02-20, at 7:49 PM, Pádraig Brady wrote: On 20/02/2023 15:02, George Valkov wrote: Hi Paul, the following tests fail after your patch: FAIL: tests/split/filter.sh FAIL: tests/split/b-chunk.sh FAIL: tests/split/l-chunk.sh These look

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-02-20 Thread George Valkov
> On 2023-02-20, at 7:49 PM, Pádraig Brady wrote: > > On 20/02/2023 15:02, George Valkov wrote: >> Hi Paul, the following tests fail after your patch: >> FAIL: tests/split/filter.sh >> FAIL: tests/split/b-chunk.sh >> FAIL: tests/split/l-chunk.sh > > These look unrelated and may be due to some

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-02-20 Thread Pádraig Brady
On 20/02/2023 15:02, George Valkov wrote: Hi Paul, the following tests fail after your patch: FAIL: tests/split/filter.sh FAIL: tests/split/b-chunk.sh FAIL: tests/split/l-chunk.sh These look unrelated and may be due to some other change in your environment. Specifically lseek() is failing on

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-02-20 Thread George Valkov
Hi Paul, the following tests fail after your patch: FAIL: tests/split/filter.sh FAIL: tests/split/b-chunk.sh FAIL: tests/split/l-chunk.sh FAIL: tests/cp/sparse-perf.sh Before patch

Re: bug#61386: [PATCH] cp,mv,install: Disable sparse copy on macOS

2023-02-20 Thread George Valkov
> On 2023-02-19, at 8:08 AM, Paul Eggert wrote: > > George, given what you've written I suppose we should give up the idea of > copying sparse files efficiently on macOS (and on FreeBSD 13.0-RELEASE, as it > has a similar bug with SEEK_HOLE and SEEK_DATA), in cases where fclonefileat > does