Re: Possible bug in qcopy-acl.c

2023-09-01 Thread Paul Eggert
On 2023-09-01 11:47, Ondrej Valousek wrote: If it returns 1, then we probably don't care about few more syscalls because in most cases we copy files w/o acls. I think I'd care about unnecessary syscalls if I were using a filesystem with ACLs.

Re: Possible bug in qcopy-acl.c

2023-09-01 Thread Ondrej Valousek
I am not sure if I understand. I mean, we have to call file-has-acl() function there anyway right? If it returns 0, then we are can also return the function as there is nothing else to do (well unless the dst file exists and has ACLs on it already). If it returns 1, then we probably don't care

Re: Possible bug in qcopy-acl.c

2023-09-01 Thread Paul Eggert
On 2023-09-01 04:24, Ondrej Valousek wrote: The disadvantage of it would be the additional call for file-has-acl() so hence few more kernel calls. Can the extra syscalls be avoided by migrating/copying some of file-has-acl.c's functionality into qcopy-acl.c? The idea would be to invoke

crypto/{sha*,md5}-buffer: Add comment

2023-09-01 Thread Bruno Haible
2023-09-01 Bruno Haible crypto/{sha*,md5}-buffer: Add comment. * m4/gl-openssl.m4 (gl_CRYPTO_CHECK): Add comment regarding license. diff --git a/m4/gl-openssl.m4 b/m4/gl-openssl.m4 index 7eab4e102e..637803b814 100644 --- a/m4/gl-openssl.m4 +++ b/m4/gl-openssl.m4 @@ -1,4 +1,4

Re: Build failure with

2023-09-01 Thread Bruno Haible
Sam James wrote: > Forwarding a downstream report at https://bugs.gentoo.org/913368 > of coreutils-9.4 failing to build with openssl-1.1.x: > """ > x86_64-pc-linux-gnu-gcc -I. -I./lib -DHASH_ALGO_BLAKE2=1 -DHAVE_CONFIG_H > -Ilib -I./lib -Isrc -I./src-O2 -march=x86-64 -pipe -pipe >

Possible bug in qcopy-acl.c

2023-09-01 Thread Ondrej Valousek
Hi all, I think we might have a bug in qcopy-acl.c as currently, when we copy files from say NFSv4 to ext4 filesystems, then "cp -p" produces warning that it could not preserve permissions. That makes a sense, but perhaps we should issue "attr_copy_file()" only if the file has a non-trivial

Build failure with

2023-09-01 Thread Sam James
Hello, Forwarding a downstream report at https://bugs.gentoo.org/913368 of coreutils-9.4 failing to build with openssl-1.1.x: """ x86_64-pc-linux-gnu-gcc -I. -I./lib -DHASH_ALGO_BLAKE2=1 -DHAVE_CONFIG_H -Ilib -I./lib -Isrc -I./src-O2 -march=x86-64 -pipe -pipe -frecord-gcc-switches