ftello: Prefer stdckdint to intprops.

2024-05-08 Thread Collin Funk
I've pushed this patch using stdckdint.h instead of intprops.h in ftello. I think this should be the last occurrence of the INT_*_OK/INT_*_WRAPV that wasn't yet converted. Also, nice work on the stdio.h / stdio_ext.h replacements. They look like they took a while. :) CollinFrom ee4be3987b5bfb87a2

sigsegv, c-stack tests: Avoid test failures with ASAN

2024-05-08 Thread Bruno Haible
With the clang 17 address sanitizer, I see these 4 test failures: FAIL: test-c-stack.sh = FAIL test-c-stack.sh (exit status: 1) FAIL: test-c-stack2.sh == FAIL test-c-stack2.sh (exit status: 1) FAIL: test-sigsegv-catch-stackoverflow1 =

Re: test-argp and clang's ASAN

2024-05-08 Thread Bruno Haible
In I wrote: > What should we do? > (A) Ensure that glibc and gnulib argp behave the same: > - Push Sergey's lowercase commit into glibc? > - Revert Sergey's lowercase commit in gnulib? > or > (B) Ensure that gnuli

gnulib-tool.py: Make --megatest behaviour more similar to shell impl

2024-05-08 Thread Bruno Haible
When using --megatest, I see a directory name with a space: drwxrwxr-x 6 bruno bruno4096 Mai 8 10:56 testdir1658193 drwxrwxr-x 6 bruno bruno4096 Mai 8 10:56 'testdir 3482' I had done a fix of this for --test in commit 1639b8598d86b3d8c7fc3c7a0afaed93c67cbb93. --megatest needs the sam

Re: gnulib-tool.py: Fix behavior of --test when a subprocess fails.

2024-05-08 Thread Bruno Haible
Hi Collin, > I've pushed the attached patch. In gnulib-tool.sh the following is > done: > > ../configure || func_exit 1 > $MAKE || func_exit 1 > [...] > > So here we can just use sp.run([command, arg], check=True) and exit if > an exception occurs. Thanks. I confirm that --test now

gnulib-tool.py: Fix behavior of --test when a subprocess fails.

2024-05-08 Thread Collin Funk
On 5/8/24 12:47 AM, Collin Funk wrote: >> With .sh, both fail. With .py, both succeed. Looks like a bug in >> gnulib-tool.py: When the 'make' or 'make check' step fails, the entire >> command should fail. > > I see what you mean. I'll have a look at fixing that right now. I've pushed the attached

Re: base32, base64: Prefer stdckdint to intprops.

2024-05-08 Thread Collin Funk
Hi Bruno, On 5/8/24 12:25 AM, Bruno Haible wrote: >> I noticed Gnulib changed most of the *_WRAPV to the ckd_* variants at >> some point. Is there a reason that INT_MULTIPLY_OK is still used in >> base32 and base64 or can I apply the following patch? > > No particular reason. The patch is OK to p

Re: base32, base64: Prefer stdckdint to intprops.

2024-05-08 Thread Bruno Haible
Hi Collin, > I noticed Gnulib changed most of the *_WRAPV to the ckd_* variants at > some point. Is there a reason that INT_MULTIPLY_OK is still used in > base32 and base64 or can I apply the following patch? No particular reason. The patch is OK to push. > It looks like the module description w