[PATCH] c-strtod: include

* lib/c-strtod.c: Include , since we call sprintf. Problem found by Oracle Developer Studio 12.6 on Solaris 10. --- ChangeLog | 6 ++ lib/c-strtod.c | 1 + 2 files changed, 7 insertions(+) diff --git a/ChangeLog b/ChangeLog index f94a39a2bb..1c85c92f9f 100644 --- a/ChangeLog +++ b/Change

Re: getusershell: Split file by lines instead of spaces.

Hi Bruno, On 5/21/24 5:43 PM, Bruno Haible wrote: > The new patch is good. OK to push. Done, thanks. >> Interesting way to think about it, thanks. Do you have a strong math >> background? It has been a while since I looked at that interval >> notation. > > Oh, I learned the interval notation at

Re: getusershell: Split file by lines instead of spaces.

Hi Collin, The new patch is good. OK to push. > However with this in my /etc/shells: > > > /bin/bash > / > === > > When printing all shells glibc prints both lines. Mine only prints > "/bin/bash". > > Strange function, in my opinion. However, lets trust the BSD and

Re: getusershell: Split file by lines instead of spaces.

On 5/21/24 5:32 AM, Bruno Haible wrote: > * If the file ends with a non-empty line without a newline, getline() > returns a string that does not end in a newline. > Quoting > https://pubs.opengroup.org/onlinepubs/9699919799/functions/getline.html: >"including the delimiter character if one

[PATCH] boot-time: port to Alpine 3.20.0_rc2

* lib/boot-time-aux.h (get_openbsd_boot_time): Port to Alpine Linux, which had bogus timestamps on /var/run/utmp. --- ChangeLog | 6 ++ lib/boot-time-aux.h | 12 ++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 099a249271..0baf

Re: access, euidaccess tests: Avoid test failure for root user on Solaris

Collin Funk wrote: > I didn't know they were run as root (CI is new to me). That's why I start all CI runs with these commands: uname -a id env | LC_ALL=C sort pwd It helps understanding the environment :) Sometimes I need to add echo $PA

Re: OmniOS CI failure for test-fnmatch-5.sh

Hi Collin, > Looking into the __illumos__ macro it appears to be relatively new. > The original bug report is 3 years old [1]. The change was added to > OmniOS in version r15038s in 2021 [2]. Yes, I also noticed it: My copy of Solaris 11 OmniOS (r151036) does not have it, as can be seen by $ :

Re: [PATCH] getopt-posix: port better to Alpine 3.20.0_rc1

On 5/21/24 10:10 AM, Paul Eggert wrote: > Sometimes I wish 'bootstrap' and 'configure' were less chatty. +1, but I can't think of a way to do so without hiding bugs. Usually I just redirect it to a file since it is easier to read there. Collin

Re: OmniOS CI failure for test-fnmatch-5.sh

Hi Bruno, On 5/21/24 2:13 PM, Bruno Haible wrote: >> I pushed the attached patch adding the #if defined __illumos__. > > It apparently has the desired effect. So, let me do the same thing with > the test-trim3.sh test, that fails like this: > > FAIL: test-trim3.sh > === > > ../..

Re: access, euidaccess tests: Avoid test failure for root user on Solaris

On 5/21/24 6:45 AM, Bruno Haible wrote: > The CI runs the Solaris 11 and Solaris 11 OmniOS tests as root, and shows > these two test failures: > > FAIL: test-access > FAIL: test-euidaccess > > This occurs because although the file does not have the 'x' bit set, > for root faccessat() returns 0. >

Re: OmniOS CI failure for test-fnmatch-5.sh

Collin Funk wrote: > I pushed the attached patch adding the #if defined __illumos__. It apparently has the desired effect. So, let me do the same thing with the test-trim3.sh test, that fails like this: FAIL: test-trim3.sh === ../../gltests/test-trim.c:150: assertion 'strcmp (res

mcel tests: Run the test in several locales

The CI tests on Solaris 11 show a test failure of test-mcel. The cause is: 1) The program test-mcel is run in a single locale only, namely the locale of the user. This means that the behaviour in the EUC-JP and GB18030 locales have never been tested. 2) On the CI machine for Solaris 11, LANG

flock tests: Mark as expected failure on Solaris 11

On Solaris 11.4, which doesn't have flock() in libc, the test-flock test fails. Whereas on Solaris 11 OmniOS and Solaris 11 OpenIndiana, which have flock() support in the kernel, it succeeds. Last time I read about locking mechanisms, it convinced me that an flock() on lockf() emulation would not

Re: [PATCH] getopt-posix: port better to Alpine 3.20.0_rc1

On 2024-05-21 09:34, Bruno Haible wrote: configure.ac:43: warning: AC_REQUIRE: 'gl_CHECK_HEADER_SYS_CDEFS_H' was expanded before it was required configure.ac:43:https://www.gnu.org/software/autoconf/manual/autoconf.html#Expanded-Before-Required Thanks, I had missed that in all the 'bootstrap'

Re: [PATCH] getopt-posix: port better to Alpine 3.20.0_rc1

Paul Eggert wrote: > + * m4/getopt.m4 (gl_GETOPT_SUBSTITUTE_HEADER): > + * m4/sched_h.m4 (gl_SCHED_H): Use the new macro > + gl_CHECK_HEADER_SYS_CDEFS_H instead of checking independently. > + * m4/sys_cdefs_h.m4: New file. Running './bootstrap' in diffutils, I see a warning: autor

Re: platforms

Collin Funk wrote: > I feel like MacOS will probably be problematic. I can see that it > already caused you a lot of trouble [1]. > > [1] https://lists.gnu.org/archive/html/bug-gnulib/2024-05/msg00330.html macOS has some amount of problems, roughly like AIX or Android. What we try to do (in Gnul

access, euidaccess tests: Avoid test failure for root user on Solaris

The CI runs the Solaris 11 and Solaris 11 OmniOS tests as root, and shows these two test failures: FAIL: test-access FAIL: test-euidaccess This occurs because although the file does not have the 'x' bit set, for root faccessat() returns 0. POSIX

Re: getusershell: Split file by lines instead of spaces.

Hi Collin, > I tried to do that originally but I don't think you > would have liked the patch. :) > > At the start of 'readname' there is a loop to skip spaces: > > while ((c == getc (stream)) != EOF > && isspace ((unsigned char) c)) >/* Do nothing. */; > > Essentially

Re: OmniOS CI failure for test-fnmatch-5.sh

On 5/21/24 1:39 AM, Bruno Haible wrote: >> I was taking a look at the CI stuff you wrote. Nice work, it seems >> really helpful. > > Thanks for helping! The goal here being to get all FAILs either fixed > or declared as XFAIL, this really helps. Sounds like a good plan. I can help with fixing the

Re: OmniOS CI failure for test-fnmatch-5.sh

Hi Collin, > I was taking a look at the CI stuff you wrote. Nice work, it seems > really helpful. Thanks for helping! The goal here being to get all FAILs either fixed or declared as XFAIL, this really helps. > The tests pass with that one check #ifdef'd out. Here is the diff I > used: > > $ di

OmniOS CI failure for test-fnmatch-5.sh

Hi Bruno, I was taking a look at the CI stuff you wrote. Nice work, it seems really helpful. I saw this test failure: FAIL: test-fnmatch-5.sh === ../../gltests/test-fnmatch.c:898: assertion 'fnmatch ("x[[:punct:]]y", "x\241\301y", 0) == 0' failed Stack trace: 0x410355 main