Re: bug#40634: Massive pattern list handling with -E format seems very slow since 2.28.

On Fri, Sep 11, 2020 at 2:47 PM Jim Meyering wrote: > On Sun, Apr 19, 2020 at 4:10 AM Norihiro Tanaka wrote: > > On Sun, 19 Apr 2020 07:41:49 +0900 > > Norihiro Tanaka wrote: > > > On Sat, 18 Apr 2020 00:22:26 +0900 > > > Norihiro Tanaka wrote: > > >

Re: bug#40634: Massive pattern list handling with -E format seems very slow since 2.28.

On Sun, Apr 19, 2020 at 4:10 AM Norihiro Tanaka wrote: > On Sun, 19 Apr 2020 07:41:49 +0900 > Norihiro Tanaka wrote: > > On Sat, 18 Apr 2020 00:22:26 +0900 > > Norihiro Tanaka wrote: > > > > > > > > On Fri, 17 Apr 2020 10:24:42 +0900 > > > Norihiro Tanaka wrote: > > > > > > > > > > > On Fri, 17

Re: problems with "make install" directory permissions

On Mon, Jul 27, 2020 at 3:03 PM Paul Eggert wrote: > > On 7/27/20 2:24 PM, Karl Berry wrote: > > https://lists.gnu.org/r/bug-bison/2020-07/msg00042.html > > > > I can understand increasing permissions to allow +rx on installation > > directories, but why force 755, thus disallowing group writ

Re: use O_CLOEXEC in more places

On Wed, May 27, 2020, 11:44 Bruno Haible wrote: > The gnulib module 'open' supports O_CLOEXEC since 2017-08-14. We can use it > to make multithreaded application that call fork() and exec() more robust. > > Here are proposed patches. > > How about module 'fts'? Should the directory fds that it al

Re: relicense module 'group-member'

On Thu, May 21, 2020 at 7:44 AM Eric Blake wrote: > On 5/21/20 9:22 AM, Bruno Haible wrote: > > Hi Jim, Paul, Eric, > > > > You are the contributors of the module 'group-member', which is under > > GPLv3+. > > Can you agree to relicensing it under LGPLv2+? > > > > Rationale: > > > > The 'euidacce

Re: list, set, oset, map, omap: avoid imperative voice in documentation

On Sun, Feb 2, 2020 at 4:17 AM Bruno Haible wrote: > Each time I read the function specifications in gl_list.h, the use of > imperative voice ("Return true if ...") feels wrong. "Returns true if ..." is > the correct grammar. > > Why? Because imperative form is used to instruct someone. In the con

Re: Your gnulib patch

On Tue, Jan 7, 2020 at 4:41 PM Cong Wang wrote: > > On Fri, Jan 3, 2020 at 3:31 PM Jim Meyering wrote: > > > > On Fri, Jan 3, 2020 at 2:43 PM Cong Wang wrote: > > > > > > On Wed, Jan 1, 2020 at 7:41 PM Jim Meyering wrote: > > > > &g

Re: [PATCH] stdlib: avoid canonicalize_file_name contradiction

On Sun, Jan 5, 2020 at 12:47 PM Bruno Haible wrote: > > Jim Meyering wrote: > > > The question is: Is passing NULL to canonicalize_file_name valid? If not, > > > then the nonnull attribute should stay. > > > > > > On one hand, in glibc&#

[PATCH] tests: skip thread-using tests when threading is disabled

I noticed this while preparing for a new release of sed. I don't like copying the 4-term #if into so many files, but it already appears in ten others. Note that this covers only the gnulib tests used by sed. This probably deserves a full audit and/or auto-run tests with gl_DISABLE_THREADS, but I a

Re: [PATCH] update-copyright: reenable its always-skipped test

On Sat, Jan 4, 2020 at 11:15 PM Bruno Haible wrote: > > Here's another that I'll push tomorrow: > > Oops, right. My mistake. Like in build-aux/update-copyright, you might also > want to restore the -0777 option that was lost on 2019-06-15. Thanks, but while that option is critical for the tool in

Re: [PATCH] stdlib: avoid canonicalize_file_name contradiction

On Sun, Jan 5, 2020 at 8:41 AM Jim Meyering wrote: ... > > Does the attached patch fix the problem for you? > > Thanks for working on that. However, it did not help, because at least > on Fedora 30, we're using the system declaration, per this: (run from > a test dir pre

Re: [PATCH] stdlib: avoid canonicalize_file_name contradiction

On Sun, Jan 5, 2020 at 12:16 AM Bruno Haible wrote: > Hi Jim, Hi Bruno, Thanks for investigating. > > stdlib: avoid canonicalize_file_name contradiction > > * lib/stdlib.in.h (canonicalize_file_name): Remove the nonnull > > attribute from its declaration. > > I'm not sure this is right. The patc

[PATCH] update-copyright: reenable its always-skipped test

Here's another that I'll push tomorrow: always-skipped-update-copyright-test.diff Description: Binary data

[PATCH] stdlib: avoid canonicalize_file_name contradiction

I expect to push something like the attached tomorrow: stdlib: avoid canonicalize_file_name contradiction * lib/stdlib.in.h (canonicalize_file_name): Remove the nonnull attribute from its declaration. tests/test-canonicalize-lgpl.c passes null_ptr () to it, which (via this contradiction) would pro

Re: Your gnulib patch

On Fri, Jan 3, 2020 at 2:43 PM Cong Wang wrote: > > On Wed, Jan 1, 2020 at 7:41 PM Jim Meyering wrote: > > > > On Tue, Dec 24, 2019 at 11:13 AM Cong Wang wrote: > > > Hello, Jim > > > > > > We found your gnulib patch > > > (http://gi

Re: Your gnulib patch

On Tue, Dec 24, 2019 at 11:13 AM Cong Wang wrote: > Hello, Jim > > We found your gnulib patch > (http://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=47cb657e) > quite useful for us, as we encountered a same issue with a few million > files under one directory. > > Is it possible for you to inte

[PATCH] localeinfo: ->simple would be wrong for LC_ALL=C

I noticed a serious performance degradation in grep and tracked it down to the following, which I've just pushed: localeinfo-logic.diff Description: Binary data

Re: grep-3.3.42-088f test results on AIX

n/sh on AIX 7.2 due to its printf > built-in. > Reported by Paul Eggert in > <https://lists.gnu.org/archive/html/grep-devel/2019-12/msg00020.html>. > Simplification by Jim Meyering. > * tests/init.sh (gl_shell_test_script_): Add a test of printf of an >

Re: grep-3.3.42-088f test results on AIX

On Thu, Dec 26, 2019 at 10:11 AM Bruno Haible wrote: > > Here's a slightly tighter test, albeit relying on tr working with octals: > > > > case `LC_ALL=en_US.UTF-8 printf '\351'| tr '\351' x` in x) ;; *) exit 1;; > > esac > > You're right, it's probably better to rely on 'tr' than on 'od'. Hi

Re: grep-3.3.42-088f test results on AIX

On Thu, Dec 26, 2019 at 9:45 AM Paul Eggert wrote: > On 12/26/19 3:32 AM, Bruno Haible wrote: > > The respawning condition > > in init.sh lines 159..175 could be extended to include printf '\351'. > > I've verified that the attached patch fixes the two reported tests from the > > 'grep' test suite

Re: grep-3.3.42-088f test results on AIX

On Thu, Dec 26, 2019 at 3:32 AM Bruno Haible wrote: > > I'm thinking we should install the attached patch into Gnulib. The basic > > idea is > > that running these test scripts in random locales is likely more trouble > > than > > it's worth. > > No no no. Applied to grep's init.sh, it would red

Re: bug#34951: [PATCH] grep: a kwset matcher not work in a grep matcher

On Fri, Dec 13, 2019 at 4:08 AM wrote: > arn...@skeeve.com write: > > > But I really don't want ptrdiff_t in the API. > > I see that Paul has made the change to the API over my objections. > > Jim --- do you have an opinion on this? Hi Aharon, I used to feel the way you do. However, given the wa

Re: gnupload with gpg>=v2.1 fails due to missing TTY

On Tue, Sep 17, 2019 at 4:14 PM Bruno Haible wrote: > Hi Assaf, > > > Possibe work-arounds: > > I would vote for 3, because it makes gnupload work out-of-the-box, and > I don't see limitations regarding the set of environments in which it > works. Nice! Thanks for reporting that and working on th

Re: make autoconf tests work with -Werror=implicit-function-declaration

On Sat, Sep 14, 2019 at 10:51 AM Bruno Haible wrote: > There are indications that future GCC versions may be stricter regarding > invocations of undeclared functions. [1] Configuring with > CC="gcc -Werror=implicit-function-declaration" > is a way to exercise similar functionality with released

Re: hash: provide hash_xinitialize

On Mon, Sep 9, 2019 at 12:16 PM Bruno Haible wrote: ... > > And I shamelessly decided to put the maintenance burden on Jim's shoulders. > > Don't be shy :) Indeed. Feel free to add your name. Thank you both for the addition and improvements.

Re: sc_prohibit_magic_number_exit false positive on string

On Sun, Sep 8, 2019 at 6:06 AM Darshit Shah wrote: > I just realized that the syntax check rule sc_prohibit_magic_number_exit will > cause a false positive when it finds the relevant tokens within a string as > well. > > For example, in Wget, we have the following snippet in our tests which trips

Re: [PATCH] areadlink-with-size: guess a lower bound with 0 size

On Thu, Jul 4, 2019 at 4:24 AM Pádraig Brady wrote: > BTW this would allocate more for empty symlinks, > but they're rare: https://lwn.net/Articles/551224/ Interesting (re)reading. Patch looks fine. Thanks.

Re: argmatch.h: new "_" definition may conflict with that of callers

On Tue, Jul 2, 2019 at 9:48 PM Akim Demaille wrote: > Bummer :( Sorry about that. I installed the following commit. ... > + argmatch: don't define _ in the header. > + Reported by Jim Meyering. > + * lib/argmatch.h (N_, _): Don't define. > +

argmatch.h: new "_" definition may conflict with that of callers

Hi Akim, I tried to build grep using latest gnulib and it failed with these errors: CC grep.o In file included from grep.c:30: ../lib/argmatch.h:35: error: "_" redefined [-Werror] 35 | # define _(Msgid) gettext (Msgid) | In file included from grep.c:28: system.h:43: note: this is

Re: include when needed

Nice. Thank you.

Re: Alpine: useless-if-before-free: Exec format error

On Wed, Jun 19, 2019 at 3:12 AM Bruno Haible wrote: ... > Done like this: > > 2019-06-19 Bruno Haible > > Reorder pieces of header in perl scripts. > The desired order is > - Prologue part 1 (2 lines with #!) > - Program short description > - Copyright an

Re: Emacs time stamp hook

Fine with me, too.

Re: strtold: Fix typo

On Tue, Mar 26, 2019 at 1:34 PM Bruno Haible wrote: > A small copy-and-paste mistake, visible only when cross-compiling. > > 2019-03-23 Bruno Haible > > strtold: Fix typo. > * m4/strtold.m4 (gl_FUNC_STRTOLD): Fix typo in variable name. ... > - [gl_cv_func_strtod_works=

Re: unlink-busy does not support cross-compilation

On Sat, Mar 23, 2019 at 10:26 AM Bruno Haible wrote: > Hi Jim, > > The module 'unlink-busy' does not support cross-compilation: It uses > AC_RUN_IFELSE, thus calling the compiler for the host, and then sets > INSTALL, which is meant to point to a command to execute on the build machine. > > It sho

Re: is_dotdot confusion in Gnulib fts's fts_safe_changedir?

On Sun, Mar 17, 2019 at 4:16 PM Paul Eggert wrote: > I installed the attached patch into Gnulib to remove an unnecessary > assignment in fts_safe_changedir. > > Jim, could you please check this? My patch does not change behavior, but > I worry that there's a bug in fts_safe_changedir that the unne

Re: Colored output

On Sun, Mar 17, 2019 at 9:30 AM Bruno Haible wrote: > Hi Jim, > > You wrote in > : > > > I too would start with coreutils, noting that one must be careful to > > handle signals, so that the terminal is not left in a bad state whe

[PATCH] test-userspec.c: don't print NULL

I tried to build the latest coreutils using latest gcc, and it warned about a real bug in gnulib's userspec-test.c. Fixed with this just-pushed patch. userspec-test.diff Description: Binary data

Re: [bug-libunistring] Unistring 0.9.10 and Undefined Behavior sanitizer findings

On Fri, Mar 8, 2019 at 5:30 PM Jeffrey Walton wrote: Thanks for the UBSAN testing and report, and to Bruno for all the fixes. > On Fri, Mar 8, 2019 at 6:36 PM Bruno Haible wrote: > > ... > > I'm pushing the attached patches. > > Thanks Bruno, got them. 0.9.10 tested good with them. > > (I shou

Re: shell variable references - coding style

On Tue, Feb 19, 2019 at 10:02 AM Bruno Haible wrote: > > Hi Pavel, > > > > [...] > > > This patch fixes both issues, and makes the IFS handling a bit more > > > robust. > > > [...] > > > > > -case $_fpf_arg in > > > +case "$_fpf_arg" in > > > [...] > > > - fpf_dirs=$1 ; shift > > > - fp

Re: Colored output

On Sun, Jan 27, 2019 at 7:53 AM Akim Demaille wrote: > I'd like to have colored diagnostics in Bison, I do feel on occasion it would > make it easier to spot errors and warnings for instance. > > AFAICT, gnulib does not feature any module to help do this. Coreutils (ls) > and GCC (maybe diffuti

Re: mountlist: Merge two .m4 files

On Sat, Jan 26, 2019 at 3:45 PM Bruno Haible wrote: > It is strange (and hampers maintenance) that the main macros for module > 'mountlist' are not found in mountlist.m4 but in a file with a > hard-to-remember > name 'ls-mntd-fs.m4'. > > I propose to merge ls-mntd-fs.m4 into mountlist.m4, to alig

Re: diacrit: mark deprecated

On Sun, Jan 20, 2019 at 5:11 PM Bruno Haible wrote: > Hi Jim, > > You are listed as the maintainer of the 'diacrit' module. It doubt anyone is > still using this module, because it assumes an 8-bit character set, whereas > most systems have switched to UTF-8 10 to 18 years ago. Do you agree to mar

Re: bootstrap: clean only gnulib's stray links

On Fri, Jan 4, 2019 at 7:42 AM Akim Demaille wrote: ... > > Le 2 janv. 2019 à 06:27, Jim Meyering a écrit : > > > > Hi Akim, > > > > My only concern is that `pwd` may sometimes fail to match the link > > name when it should. E.g., when mount points or

Re: bootstrap: clean only gnulib's stray links

On Mon, Dec 31, 2018 at 11:25 PM Akim Demaille wrote: ... > In Bison we have another submodule, and symlinks pointing > into. Occasionally, some users launch ./bootstrap before having > initialized the submodules, in which case the symlink is removed > by bootstrap. When this happens, it takes q

Re: [Grep-devel] Changed behavior in sed 4.6

On Thu, Dec 20, 2018 at 9:30 PM Jim Meyering wrote: > I've attached the patch I expect to push in less than 30 minutes, in > case someone wants to review or test quickly. > I've also created a snapshot here: > > sed snapshot: > https://meyering.net/sed/sed-ss.

Re: [Grep-devel] Changed behavior in sed 4.6

I've attached the patch I expect to push in less than 30 minutes, in case someone wants to review or test quickly. I've also created a snapshot here: sed snapshot: https://meyering.net/sed/sed-ss.tar.xz 1.3 MB https://meyering.net/sed/sed-ss.tar.xz.sig https://meyering.net/sed/sed-4.6.2

Re: [Grep-devel] Changed behavior in sed 4.6

On Thu, Dec 20, 2018 at 9:13 PM wrote: > > I expect to revert the mentioned mentioned gnulib commits, and then to > > make new releases of both grep and sed. > > Please add a test case ... You should know me better by now. I didn't mention the required NEWS update either.

Re: Changed behavior in sed 4.6

On Thu, Dec 20, 2018 at 2:49 PM Jan Palus wrote: > I've just happened to notice a difference in behavior between sed 4.5 and 4.6 > when building VirtualBox. It seems to be locale dependent: > > $ echo 'foo(bar '|LC_ALL=C sed -e 's/\([^*] *\)\bbar\b/\1foo */g' > foo(bar > > $ echo 'foo(bar '|LC_ALL

Re: [Grep-devel] handling of non-BMP characters

On Tue, Dec 18, 2018 at 11:51 PM Bruno Haible wrote: > Corinna Vinschen wrote in > : > > it would be > > pretty nice if that code could get reverted back in to support > > non-BMP charsets even on Cygwin. > > I agree that support

Re: localename: Fix test failure on AIX 7

On Tue, Dec 18, 2018 at 12:57 AM Bruno Haible wrote: > > Hi, > > Assaf Gordon wrote in > : > > > On AIX 7.1 and 7.2, one gnulib failure (FAIL: test-localename) - > > not a show-stopper. > > This patch fixes it. > > Jim: To avoid r

Re: c-stack: Fix for Linux/sparc

On Sun, Dec 16, 2018 at 2:38 PM Bruno Haible wrote: > While testing a 'grep' snapshot on Linux/sparc64, I noticed that this > test failure (both in 32-bit and 64-bit mode): > > FAIL: test-c-stack2.sh > == > > cannot tell stack overflow from crash, in spite of libsigsegv > FAIL

Re: [Grep-devel] regex and grep severely broken on HP-UX

On Sun, Dec 16, 2018 at 11:34 AM Bruno Haible wrote: > > So grep worked on HP-UX before because it was using the system regex code? > > I don't know. Maybe GNU grep never worked on HP-UX hppa? Or maybe it worked > only when compiled by gcc? Or maybe the machine I have access to has a > particularl

Re: [Grep-devel] regex and grep severely broken on HP-UX

On Sun, Dec 16, 2018 at 9:16 AM Bruno Haible wrote: > > More on this: > > On HP-UX hppa (both 32-bit and 64-bit mode), regex and grep are broken. > > The result in different gnulib versions is the same (HP-UX hppa, 32-bit): > > Version Result > - > 20

Re: openat-safer: Avoid test failure on NetBSD 8

On Sat, Dec 15, 2018 at 3:50 PM Bruno Haible wrote: > While testing a grep snapshot on NetBSD 8, I see that the gnulib test > 'test-openat-safer' fails: > > FAIL: test-openat-safer > === > > ../../gnulib-tests/test-openat-safer.c:101: assertion 'STDERR_FILENO < fd' > failed >

Re: new snapshot available: grep-3.1.46-504af

On Sat, Dec 15, 2018 at 2:08 PM Bruno Haible wrote: > Hi Jim, > > > I guess the fix should be to detect the glibc bug in m4/regex.m4 ? > > > > Exactly. That's what I'm doing now. > > I'm expecting to insert something like this, probably reusing the > > result value of "64": > > > > /*

[PATCH] dfa: avoid new warnings from gcc

FYI: I've just pushed this: >From 95cd86dd7aa4425037b9c710f88fd59e38601ff1 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sat, 15 Dec 2018 10:09:35 -0800 Subject: [PATCH] dfa: avoid new warnings from gcc These would prevent building with -Werror and a Dec snapshot of gcc. * l

Re: localtime-buffer: Avoid endless recursion in localtime and gmtime

On Thu, Dec 13, 2018 at 3:12 AM Bruno Haible wrote: > When running the gnulib unit tests in sed-4.5.48-58eb on Cygwin, I see > a crash of the test-gettimeofday.exe program. It is caused by endless > recursion: rpl_localtime and rpl_gmtime are compiled into endless > recursions. > > You don't see t

Re: gnupload: Support -h

On Sat, Dec 1, 2018 at 7:32 AM Bruno Haible wrote: > > Ben Elliston wrote: > > The first time I ran gnupload, I used -h and got an error. ;-) This > > patch adds -h as an alias for --help. > > Normally it's Jim who reviews patches to gnupload. He hasn't reacted > in 3 days. But the patch is obviou

Re: [PATCH] maintainer-makefile: fix syntax-check rule for "same.h" [was: [INSTALLED 2/2] ln: use linkat and symlinkat]

On Sun, Oct 28, 2018 at 12:59 PM Bernhard Voelker wrote: > On 10/28/18 1:25 PM, Jim Meyering wrote: > > Thanks for fixing that, but... > > > >> - @h='same.h' re='\ > + @h='same.h' re='\ > > > please use the "?&quo

Re: [PATCH] maintainer-makefile: fix syntax-check rule for "same.h" [was: [INSTALLED 2/2] ln: use linkat and symlinkat]

On Sun, Oct 28, 2018 at 12:22 PM Bernhard Voelker wrote: > > sorry, I forgot to include bug-gnulib, sending again ... > For reference, the original change in coreutils was published here: > https://lists.gnu.org/r/coreutils/2018-10/msg00032.html > > On 10/28/18 9:48 AM, Paul Eggert wrote: > > @@

Re: remove support for ancient platforms from mountlist, fsusage, getloadavg

On Thu, Oct 18, 2018 at 7:56 AM Bruno Haible wrote: > > Paul Eggert wrote: > > Thanks, those patches all look good to me. > > OK, pushed. > > There are still similar oldies (apollo, DGUX, NeXT) in getloadavg.c, that > are still there for no good reason. But they are not introducing significant > c

Re: two (and a half) more crashes in regex module

On Tue, Sep 18, 2018 at 3:21 PM Assaf Gordon wrote: > On 12/09/18 12:02 AM, Assaf Gordon wrote: > > $ echo 1 | grep -E "(\'|^)(\1|)" > > grep: regexec.c:1375: pop_fail_stack: Assertion `num >= 0' failed. > > Aborted > > I don't have a fix yet, but I reduced the crash to this interesti

Re: bug#32592: heap-use-after-free in regex module

On Thu, Sep 6, 2018 at 12:18 AM Paul Eggert wrote: > Jim Meyering wrote: > > I couldn't help but notice this nonsense right after the line > > you inserted: > > > >if (err == REG_NOMATCH) > > continue; > > } > > &

Re: bug#32592: heap-use-after-free in regex module

On Wed, Sep 5, 2018 at 6:28 PM Assaf Gordon wrote: > > Bruno alerted me off-list: > > On 05/09/18 07:19 PM, Bruno Haible wrote: > > Is the ChangeLog entry up-to-date? > > > > +* regexec.c (get_subexp): Update 'buf' after call to get_subexp_sub. > > +Additionally, check for allocation e

Re: bug#32592: heap-use-after-free in regex module

On Wed, Sep 5, 2018 at 6:08 PM Assaf Gordon wrote: > Assuming the gnulib bugfix is valid (in my previous email), > I suggest adding the following test to sed (after updating gnulib). Thank you, Assaf. Only tiny suggestions: sed-test-tweak.diff Description: Binary data

Re: bug#32592: heap-use-after-free in regex module (was: s with i modifier seems to work incorrectly)

On Wed, Sep 5, 2018 at 12:32 AM Assaf Gordon wrote: > > (adding gnulib) > > On 04/09/18 07:02 PM, Saito Takaaki wrote: > [... discussing a sed bug ...] > > However, a friend showed me a more complex case which is > > problematic even with sed 4.4 on ideone. The last two lines of the > > output (f

Re: finish the GNULIB_POSIXCHECK framework

On Sun, Aug 5, 2018 at 11:26 PM, Bruno Haible wrote: > With this framework in place, it is now possible to eliminate the > "checking whether ... is declared without a macro" checks when they > are not needed. > > 2018-08-05 Bruno Haible > > Optimize the "checking whether ... is declared

[PATCH] bootstrap: reinstate definition fo gnulib_mk.

FYI, I've just pushed this, with a typo in the subject line. >From 1688c519e2cfd2f65b75ce6ebd36388a18d7b70c Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 25 Jul 2018 00:08:39 -0700 Subject: [PATCH] bootstrap: reinstate definition fo gnulib_mk. That variable is used at least

Re: avoid FP syntax-check failure due to bootstrap

On Sun, Jul 1, 2018 at 6:42 AM, Paul Eggert wrote: > Jim Meyering wrote: > >> Subject: [PATCH] bootstrap: s/--option val/--option=val/ > > Thanks, that looks good to me. (I had run into the same problem but was > hoping someone else would have time to look into it) Thanks. Pushed.

avoid FP syntax-check failure due to bootstrap

m that particular syntax-check rule, albeit having to do that in at least a few other projects.] >From 3517bf807ade06d070d410cd2f8986603cb2f876 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sat, 30 Jun 2018 19:57:07 -0700 Subject: [PATCH] bootstrap: s/--option val/--option=val/ * bu

Re: error: jump skips variable initialization

On Mon, Jun 25, 2018 at 12:07 PM, Bruno Haible wrote: ... > OK, done as follows: > > 2018-06-25 Bruno Haible > > manywarnings: Don't enable -Wjump-misses-init warnings by default. > * build-aux/gcc-warning.spec: Add -Wjump-misses-init. > * m4/manywarnings.m4 (gl_MANYWARN

[PATCH] acl-internal.h: remove _GL_ATTRIBUTE_CONST on void function

FYI, I saw another coreutils build failure when configured with --enable-gcc-warnings and this addresses it: >From ed78f0e059003680af6476989c39c9ba18ae3fd0 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 25 Jun 2018 08:28:12 -0700 Subject: [PATCH] acl-internal.h: rem

Re: FYI: address coreutils' gcc9 build failures

On Sun, Jun 24, 2018 at 7:43 PM, Bruno Haible wrote: > Jim Meyering asks: >> I presume that by reporting this, you think gcc-4.8.5 is still worth >> supporting? > > Sure. This version of GCC is the default one on RHEL 7.4 / PowerPC, which is a > mainstream Linux distro

Re: FYI: address coreutils' gcc9 build failures

On Sun, Jun 24, 2018 at 6:36 PM, Bruno Haible wrote: > Jim Meyering wrote: >> diff --git a/lib/parse-datetime.y b/lib/parse-datetime.y >> index f14bb31dc..3d8666a4d 100644 >> --- a/lib/parse-datetime.y >> +++ b/lib/parse-datetime.y >> @@ -1766,6 +1766,11 @@

Re: error: jump skips variable initialization

On Sun, Jun 24, 2018 at 5:00 PM, Bruno Haible wrote: > Hi Jim, Paul, > >> parse-datetime.y: In function 'parse_datetime2': >> parse-datetime.y:1791:19: error: jump skips variable initialization \ >> [-Werror=jump-misses-init] Hi Bruno, Didn't this warning or one very much like it catch real bu

Fix canon-host-vs-GCC9 properly

Fix canon-host.? properly: >From e86c5da600df51198134e0e9641234bcbaeee852 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 24 Jun 2018 16:54:43 -0700 Subject: [PATCH] canon-host: take GCC9's advice rather than ignoring warning MIME-Version: 1.0 Content-Type: text/plain; chars

Re: FYI: address coreutils' gcc9 build failures

On Sun, Jun 24, 2018 at 4:20 PM, Pádraig Brady wrote: > On 24/06/18 16:10, Jim Meyering wrote: >> +/* Without this pragma, gcc version 9.0.0 20180616 suggests that >> + the canon_* functions might be candidateifor attribute 'malloc' */ >> +#if 9 <= __GNUC__ &

FYI: address coreutils' gcc9 build failures

to gnulib files, the build succeeded: >From 593c1703712ec68b1e59bd7f1764d990e030ec69 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 24 Jun 2018 11:31:50 -0700 Subject: [PATCH 1/3] manywarnings: accommodate GCC 9.0-pre: remove -Wchkp and -Wabi * build-aux/gcc-warning.spec: Add them here,

[PATCH] README-release: also run any check-very-expensive tests

FYI, I've just pushed this: >From 29596f8db284a461933f2cff775bc65399f2efbc Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Tue, 19 Jun 2018 15:47:53 -0700 Subject: [PATCH] README-release: also run any check-very-expensive tests * top/README-release: Adjust instructions so they run t

Re: gnupload and gpg2

On Sat, May 19, 2018 at 4:14 PM, Bruno Haible wrote: > Hi Jim, > >> The only thing I would have done differently would be to add >> "FIXME-2020" or similar to your comment > > Why 2020? I wrote: > > Ubuntu 2016.04 (which is supported until April 2021, > that is, 3 years from now), has `gpg --v

Re: gnupload and gpg2

On Sat, May 19, 2018 at 4:02 AM, Bruno Haible wrote: > There was no comment from Jim. So I pushed this: > > 2018-05-19 Bruno Haible > > gnupload: Fix "gpg-agent is not available in this session" error. > * build-aux/gnupload (GPG): Pick the right GNUPG executable to use. > > dif

Re: imperative vs. descriptive style

On Sun, May 6, 2018 at 3:11 AM, Paul Eggert wrote: > Bruno Haible wrote: > >> The GNU Coding Standards [1] don't favour either, although I have vague >> memories that 20 years ago, it advocated imperative style. > > > Yes, I have the same vague memory, and still prefer imperative style in many > c

Re: [PATCH 5/6] fts: three levels of leaf optimization

On Tue, Jul 25, 2017 at 12:28 AM, Paul Eggert wrote: > * lib/fts.c (enum leaf_optimization): New type with three values. > (S_MAGIC_AFS): New macro. Sort them. > (leaf_optimization): Rename from leaf_optimization_applies, and > return enum leaf_optimization instead of bool. All uses changed. > A

Re: [platform-testers] new snapshot available: sed-4.4.104-290c

On Tue, Mar 27, 2018 at 6:38 PM, Paul Eggert wrote: > On 03/27/2018 05:27 PM, Nelson H. F. Beebe wrote: >> >> test=${1##*/} >> >> I would strongly urge removal of such shell extensions. > > That syntax has been standard ever since POSIX formalized the shell in IEEE > Std 1003.2-1992 (I jus

Re: [platform-testers] new snapshot available: sed-4.4.104-290c

On Sat, Mar 24, 2018 at 3:53 AM, Eric Blake wrote: > On 03/23/2018 06:53 PM, Jim Meyering wrote: >> >> On Fri, Mar 23, 2018 at 4:23 PM, Assaf Gordon >> wrote: >>> >>> (adding bug-gnulib@ because of 'test-localename' failure) >>> >

Re: [platform-testers] new snapshot available: sed-4.4.104-290c

On Fri, Mar 23, 2018 at 4:23 PM, Assaf Gordon wrote: > (adding bug-gnulib@ because of 'test-localename' failure) > > Hello Jim, > > On Fri, Mar 23, 2018 at 02:15:05PM -0700, Jim Meyering wrote: >> sed snapshot: >> https://meyering.net/sed/sed-4.4.104-29

Re: [bug-diffutils] bug#30913: bug#30913: Releasing a build compatible withglibc-2.26+

On Fri, Mar 23, 2018 at 11:50 AM, Eric Blake wrote: > On 03/23/2018 01:44 PM, Paul Eggert wrote: > >>> From 0d111b0de328d31dd3444ceeec977a7aaa5bb0ed Mon Sep 17 00:00:00 2001 >> >> From: Paul Eggert >> Date: Fri, 23 Mar 2018 11:26:15 -0700 >> Subject: [PATCH] c-stack: port to recent GCC build >> >>

Re: [PATCH 1/2] fts: do not use the getcwdat module

On Wed, Mar 21, 2018 at 7:44 AM, Kamil Dudka wrote: > ... because there is no such module in gnulib > --- > lib/fts.c | 26 +- > 1 file changed, 5 insertions(+), 21 deletions(-) > > diff --git a/lib/fts.c b/lib/fts.c > index bfa73e31e..4195f6170 100644 > --- a/lib/fts.c >

Re: relicense some modules for use under GPLv2+

I approve/agree as well. On Feb 20, 2018 10:31, "Eric Blake" wrote: > On 02/19/2018 05:20 PM, Bruno Haible wrote: > >> Hi, >> >> Often gnulib has relicensed modules for use in LGPLv2+ packages (such as >> libvirt). >> >> Some modules have also be relicensed for use in "dual LGPLv3+ or GPLv2" >>

Re: nl_langinfo: new failure with glibc-2.26 and fedora 27

gt;> FAIL test-nl_langinfo.sh (exit status: 1) > > I could swear I had tested this, but apparently I had only tested the > 'langinfo' module, not the 'nl_langinfo' module. Fixed: > > > 2018-02-04 Bruno Haible > > nl_langinfo: Override the

nl_langinfo: new failure with glibc-2.26 and fedora 27

Hi Bruno, I wanted to update sed to latest gnulib, but found that the new nl_langinfo tests would fail on fedora 27 with glibc-2.26, where nl_langinfo (ALTMON_1) returns the empty string: FAIL: test-nl_langinfo.sh = test-nl_langinfo.c:95: assertion 'strlen (nl_langinfo (A

[PATCH] maint.mk: exempt "/proc/filesystems" from "file system" syntax check

tax check * top/maint.mk (sc_file_system): Don't complain about "/proc/filesystems". --- ChangeLog| 6 ++ top/maint.mk | 1 + 2 files changed, 7 insertions(+) diff --git a/ChangeLog b/ChangeLog index 56b7de8f9..340dc226c 100644 --- a/ChangeLog +++ b/ChangeLog @

Re: [PATCH v2] stat-time: silence -Wunused-parameter regression

On Tue, Jan 2, 2018 at 1:56 PM, Eric Blake wrote: > Commit 2c5d5587 causes warnings on non-Sun systems when compiled > under -Wunused-parameter; we've previously tweaked code in commit > 81eb8486 to avoid such warnings. Prefer an attribute rather than > a cast to void (the attribute is always oka

[PATCH] update-copyright: add code to handle more special cases

a/ChangeLog b/ChangeLog index d3cb40d53..b0f01dfef 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,13 @@ +2018-01-01 Jim Meyering + + update-copyright: add code to handle more special cases + After running "make update-copyright" this year, five files + required ad

Re: fix spurious gnulib test-faccessat failure

On Tue, Nov 28, 2017 at 7:58 AM, Jim Meyering wrote: > FYI, I've just pushed the following to gnulib. > I noticed this new parallel test failure when coreutils started > using the very latest from gnulib. > > test-faccessat.c: correct BASE definition to avoid p

fix spurious gnulib test-faccessat failure

FYI, I've just pushed the following to gnulib. I noticed this new parallel test failure when coreutils started using the very latest from gnulib. test-faccessat.c: correct BASE definition to avoid parallel test failure * tests/test-faccessat.c (BASE): Define using this file's name, not

Re: gnupload and gpp2

On Tue, Nov 7, 2017 at 3:16 AM, Phillip Lord wrote: > Jim Meyering writes: > >> On Mon, Nov 6, 2017 at 2:04 AM, Phillip Lord >> wrote: >>> Currently, gnupload defaults to GPG="gpg" which in turn defaults to gpg >>> 1. This is a little pa

Re: gnupload and gpp2

On Mon, Nov 6, 2017 at 2:04 AM, Phillip Lord wrote: > Currently, gnupload defaults to GPG="gpg" which in turn defaults to gpg > 1. This is a little painful as the handling of gpg-agent has changed > substantially between gpg1 and gpg2. I notice that a lot of online > documentation assumes gpg2 now

Re: [PATCH] fstatat: pacify GCC on unusual platform

On Sun, Nov 5, 2017 at 2:29 PM, Paul Eggert wrote: > * lib/fstatat.c (orig_fstatat) [!HAVE_WORKING_FSTATAT_ZERO_FLAG]: > Omit, as it’s unused in this case. Thanks. For the record, which platform required that?

Re: latest gcc vs lib/timespec.h:85

On Sun, Oct 29, 2017 at 4:27 PM, Paul Eggert wrote: > Jim Meyering wrote: >> >> Here's a proposed patch: > > I prefer 'assume' to 'assure' here, since it's a low-level time-comparison > primitive and lots of other code in the module already

<    1   2   3   4   5   6   7   8   9   10   >