FYI, I've just pushed this, too:
From 53a617f5e118ec5642daa3da45fcef0bf5593b12 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@fb.com
Date: Sun, 20 Oct 2013 11:32:58 -0700
Subject: [PATCH] error: add the printf attribute to a static function
* lib/error.c (error_tail): Add the printf
With very recent gcc and all warnings enabled for grep's subset of
gnulib, I was seeing warnings about functions that deserve pure, const
and gnu_printf attributes.
Here are patches to avoid those:
0001-fpending-obstack-strerror-override-use-pure-const-fu.patch
Description: Binary data
17 00:00:00 2001
From: Jim Meyering meyer...@fb.com
Date: Sat, 21 Sep 2013 09:11:49 -0700
Subject: [PATCH] timespec: use the new TIMESPEC_RESOLUTION in a few more
places
* lib/timespec-add.c (timespec_add): Also replace 9
with TIMESPEC_RESOLUTION - 1.
* lib/timespec-sub.c (timespec_sub
I had a little difficulty updating grep to the latest gnulib.
This patch was the the only change required on the gnulib side:
[yeah, I'll be reviving my mail server RSN]
From e86c48893fdd952286c530568860bd9acdf4be00 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@fb.com
Date: Mon, 5 Aug 2013
Paul Eggert wrote:
It's fine with me, too.
Fine with me, too.
Eric Blake wrote:
I am trying to fix a bug in libvirt where a child process deadlocked
because it called initgroups() in between fork and exec when the parent
was multithreaded; it turns out that looking up group membership
information requires a mutex, but if some other thread in the parent
Jim Meyering wrote:
Paul Eggert wrote:
On 05/12/2013 10:14 PM, Jim Meyering wrote:
I ran gcc's -fsanitize=address against coreutils, and two
sort tests failed due to buffer overruns. Both arose via
a bug in quotearg.c. Patch below. Two things remain to do:
1) find when the bug
I'll do #1, but I will get to #2.
From 5f14f49f770258fd81cea53602a94be0c0c4dffd Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@fb.com
Date: Sat, 11 May 2013 18:43:50 -0700
Subject: [PATCH] quotearg: do not read beyond end of buffer
* lib/quotearg.c (quotearg_buffer_restyled): Do not read
Eric Blake wrote:
Libvirt had a patch that attempted to do:
+#elif defined(SIOCSIFLLADDR) defined(HAVE_STRUCT_IFREQ) \
+defined(HAVE_DECL_LINK_ADDR)
but which was not flagged by the syntax checker as suspicious
(all HAVE_DECL_* symbols defined by autoconf are always defined
after
Stefano Lattarini wrote:
On 05/04/2013 08:32 PM, Paul Eggert wrote:
That looks OK; please apply. And thanks.
Thanks from me, too!
Bernhard Voelker wrote:
I'm having problems with the above test on different systems
for a while now. It aborts at different places.
Therefore, I've run it 1000 times like the following
for f in $( seq 1000 ) ; do \
./test-fdutimensat ; \
done 21 | grep -v Aborted
On a system I
Paul Eggert wrote:
+2013-04-29 Paul Eggert egg...@cs.ucla.edu
+
+ tests: don't assume getdtablesize () = 1000
+ * modules/cloexec-tests:
+ * modules/dup2-tests:
+ * modules/dup3-tests:
+ * modules/nonblocking-tests:
+ *
Dmitry Selyutin wrote:
Hello everyone!
First of all I'd like to apologize that I've been absent: I've been sent to
Italy to study Latin for this year to be able speak it. Since I've missed more
than month of study when I've come to Academy, I had to use all my efforts to
catch up with the
Assaf Gordon wrote:
Hello,
I'm trying to use gnulib in my project.
I would like to use some modules that seem to exist in the 'coreutils'
version of 'gnulib', but not otherwise.
specifically: strnumcmp and randread (but later perhaps others).
In coreutils, the files do exist:
===
$ cd
FYI, I hit one of these diagnostics a couple of months ago,
so improved them:
From cbd4dafd96be16e8e727663decb1002883813483 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@fb.com
Date: Sun, 27 Jan 2013 09:54:55 -0800
Subject: [PATCH] prefix-gnulib-mk: give better diagnostics
* build-aux
Pádraig Brady wrote:
On 01/28/2013 01:14 PM, Pádraig Brady wrote:
On 12/14/2012 04:17 AM, Jim Meyering wrote:
If we're omitting devfs, then should devtmpfs also be omitted?
I don't think devtmpfs should be marked as dummy
as there is storage associated with it.
I.E. you can write normal
Stefano Lattarini wrote:
Throwing in my two cents here ...
...
Thanks.
$(...) is not supported by even some modern systems, including solaris 10.
Actually, only by /bin/sh. Solaris 10 has a working Korn shell in
/bin/ksh and a working POSIX shell in /usr/xpg4/bin/sh. Requiring
a
Gary V. Vaughan wrote:
...
so it would be safer to probe for
and use a backslash safe echo here
Much better would be to just use printf. Safer, simpler and more portable!
Yes. For uses like this, echo has been deprecated
for well over a decade.
And here's another one :) What users (if
Eric Blake wrote:
On 01/17/2013 08:52 AM, John Darrington wrote:
Can gnulib's automake environment be used in a non-recursive manner?
That is to say can I include the gnulib modules from my project's
Makefile.am or is there no other way that using SUBDIRS=
Both coreutils and bison already
Paul Eggert wrote:
* lib/strftime.c [FPRINTFTIME]: Do not include ignore-value.h.
(cpy) [FPRINTFTIME]: Use plain fwrite, not ignore_value of fwrite,
since the stdio module arranges to silence that warning now.
* modules/fprintftime (Depends-on): Depend on stdio, not ignore-value.
...
-
Paul Eggert wrote:
On 01/04/2013 12:58 AM, Jim Meyering wrote:
AFAIK, that comment is still valid
I can put the comment back but I'd like to word it
so that I understand it -- currently I don't.
Could you explain a bit more about the problem?
First, I just now reread the C99 standard
Paul Eggert wrote:
On 01/04/2013 08:44 AM, Eric Blake wrote:
Do we even
know of platforms where fwrite will fail on ENOMEM without setting the
error indicator?
I don't know of any, no. I am assuming Jim ran into one
at some point, but if we don't know of any, perhaps we should
Back when
mistakenly matches the 99 in the middle of the *first* date, 1991:
Here's the fix:
From 25b6e62a48c9991f8166c490463cf73ebc874db4 Mon Sep 17 00:00:00 2001
From: Jim Meyering j...@meyering.net
Date: Thu, 3 Jan 2013 10:23:30 +0100
Subject: [PATCH] update-copyright: avoid copyright notice date corruption
Jim Meyering wrote:
Joseph S. Myers wrote:
On Wed, 2 Jan 2013, Eric Blake wrote:
The original was:
Copyright (C) 1995,97,99 Free Software Foundation, Inc.
and that pattern (4-digits followed by 2-digits, with gaps in the years,
but no spaces in the listing) is not currently tested
Paul Eggert wrote:
[Here's a proposed gnulib patch, to prepare for Automake changes.]
It is obsolete and is planned to be removed from Automake 1.14; see
http://lists.gnu.org/archive/html/automake/2012-12/msg00029.html.
* build-aux/po/Makefile.in.in (install-data, install-data-yes)
Ben Pfaff wrote:
Here is a revised version. It passes the included tests, so I'll
wait 72 hours for comments and then commit it if no one objects.
...
ChangeLog | 43
lib/c-asprintf.c | 35 +++
lib/c-snprintf.c
Jim Meyering wrote:
...
That looks like a fine patch.
It looks like this is Bruno's script, but it's small/safe enough
that if there's no objection by tomorrow, I'll push it then.
Thanks again. Pushed.
Eric Wong wrote:
Jim Meyering j...@meyering.net wrote:
Thanks. I've tweaked the log and added a matching ChangeLog entry.
Testing via df on my F18 laptop, diff -u (src/df-prev) (src/df)
shows no difference. What do people think of this entry from
that F18 system?
devtmpfs
Akim Demaille wrote:
Le 13 déc. 2012 à 18:06, Jim Meyering j...@meyering.net a écrit :
cvsu does not report that there are directories and files inside the
'D's. Is it wrong to simply cvs add everything that is there?
Just skipping CVS, but adding all the rest using find?
Say find . -name
Alexandre Duret-Lutz wrote:
* build-aux/x-to-1.in: Run $HELP2MAN via $PERL so that the user gets a
chance to use his preferred version of Perl. This is typically
required by Darwin users whose default /usr/bin/perl do not have all
the libraries required by help2man, and who need to use their
Akim Demaille wrote:
...
Did you intend to remove this comment?
I know they're also in --help output, but it's probably
best to leave them at the top, too.
-# Run this after each non-alpha release, to update the web documentation at
-# http://www.gnu.org/software/$pkg/manual/
I'm slightly
Akim Demaille wrote:
The Bison's documentation now uses images, including in HTML.
gendocs.sh properly sets up a directory with the images for all the
documentation formats. Unfortunately gnu-web-doc-update fails to add
all the new files, because it fails to discover new directories.
My
Akim Demaille wrote:
Le 13 déc. 2012 à 15:35, Jim Meyering j...@meyering.net a écrit :
Hi Akim!
Hi Jim!
Thanks for the investigation and report.
If using --types='?D' makes it work, I'd go with that:
that seems simpler than changing the external cvsu program.
OK. But it will require
Stefano Lattarini wrote:
Ah, we all git lovers still forced to deal with that living fossil
of CVS!
Wouldn't it be great if someone could convince the Savannah admin
to switch the web pages repository to a modern, distributed VCS?
If it weren't mostly abstracted/automated away, I would have
Eric Wong wrote:
Jim Meyering j...@meyering.net wrote:
Eric Wong wrote:
* lib/mountlist.c (ME_DUMMY_0):
additional dummy FS names for Linux systems.
- devpts PTY slave filesystem
- fusectl control filesystem for FUSE
- mqueue enumerates POSIX message queues
- rpc_pipefs
Simon Josefsson wrote:
I have pushed this -- it allows me to use gnupload with the GnuPG
private key on a smartcard to upload to ftp.gnu.org.
I've wanted that for a long time. Thanks a lot!
Eric Wong wrote:
* lib/mountlist.c (ME_DUMMY_0):
additional dummy FS names for Linux systems.
- devpts PTY slave filesystem
- fusectl control filesystem for FUSE
- mqueue enumerates POSIX message queues
- rpc_pipefs kernel - userspace bridge for NFS
- sysfs is for exporting
Paul Eggert wrote:
...
../../../lib/basename-lgpl.c:50:10: warning: cast discards
'__attribute__((const))' qualifier from pointer target type [-Wcast-qual]
return (char *) base;
This is harmless.
Perhaps basename-lgpl.c should add a suitably-protected
# pragma GCC diagnostic ignored
Eric Blake wrote:
On 11/19/2012 04:26 PM, matimatik wrote:
I cannot find #define for HAVE_RAW_DECL_GETS in it (moreover,
'grep -R HAVE_RAW_DECL_GETS .' in workdir doesn't show anything
relevant). But it does contain GNULIB_GETS='1'.
GNULIB_GETS doesn't appear anywhere in current gnulib
Dmitry V. Levin wrote:
On Fri, Nov 16, 2012 at 09:52:06PM +, James Youngman wrote:
Did anybody do any further work on whether it worked best to fix this
in gnulib or in findutils?
As I said, my proposal is to introduce a new FTS_ flag that would make
fts_open behave as before that
James Youngman wrote:
On Fri, Nov 16, 2012 at 10:33 PM, Paul Eggert egg...@cs.ucla.edu wrote:
On 11/16/12 14:10, Dmitry V. Levin wrote:
As I said, my proposal is to introduce a new FTS_ flag that would make
fts_open behave as before that change, and use this flag in findutils.
I haven't heard
:7: error: unused variable 'result' [-Werror=unused-variable]
int result = 0;
^
From 025f7741264a170d2a87c30370bc4b96b256f3b4 Mon Sep 17 00:00:00 2001
From: Jim Meyering j...@meyering.net
Date: Thu, 8 Nov 2012 23:03:57 -0800
Subject: [PATCH] tests/nap.h: avoid warning about unused
Paul Eggert wrote:
On 11/05/2012 02:02 PM, Eric Blake wrote:
Do we really want the ability to open a symlink as an fd
when using O_EXEC permissions, instead of following the
symlink into the file that it normally points to?
Opening the symlink with open (symlink, O_EXEC) should be
OK,
Paul Eggert wrote:
Thanks for the testing report.
I installed the following changes to gnulib, and they should propagate
to diffutils in due course. The one to test-sh-quote
should fix your problem with lintl. The one to test-raise.c
is a porting gotcha that may be independent of Solaris,
Eric Blake wrote:
...
-config_h_header ?= config\.h
This is the kingpin line - add a definition of config_h_header in your
cfg.mk, and then maint.mk can be used unchanged but with your
alternative spelling of your common header (and also make sure your
osinfo/osinfo_priv.h includes config.h
suggest the following.
Besides, adding a _ prefix is more name-space friendly.
From 4e0b109267214af6a5b56431a7403b6db4b8dddc Mon Sep 17 00:00:00 2001
From: Jim Meyering j...@meyering.net
Date: Sun, 28 Oct 2012 08:38:09 +0100
Subject: [PATCH] maint.mk: rename a new configurable variable
* top
Spotted these while investigating freebsd-vs-coreutils-w/latest-gnulib
link failures:
From 5ee63ec3af75a07c25f68bfda5fdb55947d06d11 Mon Sep 17 00:00:00 2001
From: Jim Meyering j...@meyering.net
Date: Mon, 15 Oct 2012 18:34:56 +0200
Subject: [PATCH] fchmodat.c, fchownat.c: compile-impeding typos
Paul Eggert wrote:
* lib/at-func.c: If GNULIB_SUPPORT_ONLY_AT_FDCWD, then support
this function only if its first argument is AT_FDCWD.
Emacs wants faccessat for AT_EACCESS but not for any first-arg
values other than AT_FDCWD, so it doesn't want all the openat
machinery with fchdir etc.
*
reported for FreeBSD 9 by Jim Meyering in
+ http://lists.gnu.org/archive/html/bug-gnulib/2012-10/msg00070.html.
+ * lib/chmodat.c, lib/chownat.c, lib/statat.c:
+ New files, which define FCHMODAT_INLINE etc.
+ * lib/fchmodat.c (FCHMODAT_INLINE):
+ * lib/fchownat.c (FCHOWNAT_INLINE
Richard W.M. Jones wrote:
Turning off coredumps reveals a load more problems. I wonder if the
latest glibc in Fedora Rawhide is broken?
test-dup2.c:173: assertion failed
# ASSERT (!is_inheritable (fd + 1));
test-dup3.c:108: assertion failed
# ASSERT (dup3 (fd, fd, o_flags) == -1);
Paul Eggert wrote:
On 10/02/2012 02:03 PM, Simon Josefsson wrote:
I have a use for the inttostr module in a library inside OATH Toolkit
that will be released under LGPLv2+.
Sure, that's fine with me.
That is fine with me, too.
Nikos Mavrogiannopoulos wrote:
On 09/27/2012 10:19 PM, Nikos Mavrogiannopoulos wrote:
Updated.
Any update on that? Do you plan to include it?
Yes, I'll apply it shortly. Thanks.
Nikos Mavrogiannopoulos wrote:
On 09/27/2012 10:19 PM, Nikos Mavrogiannopoulos wrote:
Updated.
Hello,
Any update on that? Do you plan to include it?
Hi Nikos,
I went to deal with the mechanics of adding it and noticed a few details.
What do you think about hash_pjw_no_mod or hash_pjw_bare
Reuben Thomas wrote:
I get the following error while trying to make a GNU Zile release:
/bin/bash: -c: line 1: syntax error near unexpected token `then'
/bin/bash: -c: line 1: `@if test -d ../release; then \'
make[2]: *** [release-prep] Error 1
I'm using bash 4.2.24(1)-release as shipped
Mats Erik Andersson wrote:
lördag den 29 september 2012 klockan 19:16 skrev Jim Meyering detta:
Mats Erik Andersson wrote:
fstatat.c:26:10: #include expects FILENAME or FILENAME
That appears to be due to a typo.
Can you confirm the following fix solves the problem?
Works well
the old code could have worked.
From d357bb12e2b267dbd4bdbd96f97851f609b9b4a3 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Sat, 29 Sep 2012 19:13:21 +0200
Subject: [PATCH] fstatat.c: fix a compile-impeding typo
* lib/fstatat.c (FSTATAT_INLINE): Fix typo: s/#include/#define
Paul Eggert wrote:
On 09/25/2012 06:19 AM, Nikos Mavrogiannopoulos wrote:
Would it be possible to relicense hash-pjw under LGPLv2+ or v3+?
Makes sense to me, since the same code is distributed elsewhere
in gnulib under LGPLv2+ -- see localename.c. Jim?
Yes, switching it to LGPLv2+ is fine
Akim Demaille wrote:
Le 24 sept. 2012 à 09:47, Jim Meyering a écrit :
You're welcome to leave it as is.
Attached the two updated patches, and another to propagate
the style where the body of ifeq and co. is indented.
IMHO, more important would be to remove the need to specify
RELEASE_TYPE
Akim Demaille wrote:
Le 25 sept. 2012 à 12:11, Akim Demaille a écrit :
Pushed.
Well, there are several issues with the patch. I'm on it right now.
Do not upgrade gnulib right now.
Here are the proposed fixes. I had only tested these patches
with the various targets of the release
Akim Demaille wrote:
Hi Jim!
Le 23 sept. 2012 à 16:19, Jim Meyering a écrit :
# member-check VARIABLE,VALID-VALUES
member-check = \
$(if $($(1)), \
$(if $(findstring $(_sp),$($(1
Akim Demaille wrote:
Le 22 sept. 2012 à 17:02, Jim Meyering a écrit :
How about something like this?
release-type =
\
$(subst :, ,
\
$(if $(RELEASE_TYPE
Akim Demaille wrote:
Le 21 sept. 2012 à 16:44, Jim Meyering a écrit :
Hi!
diff --git a/top/maint.mk b/top/maint.mk
index 87bbde9..e8ea768 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -91,13 +91,22 @@ my_distdir = $(PACKAGE)-$(VERSION)
# Old releases are stored here
Akim Demaille wrote:
Le 3 août 2012 à 11:41, Jim Meyering a écrit :
Akim Demaille wrote:
There is still the uploading step which is not bound to a make
target. I would remove the emit_upload_command completely, and
instead mention the upload target in README-release, including
Akim Demaille wrote:
Le 19 sept. 2012 à 19:43, Jim Meyering a écrit :
[Cc'ing Akim, in case he wants to do this to bison. If so,
with three projects using it, I'll move the module to gnulib. ]
Yes, I do want that :)
@@ -142,8 +151,20 @@ sub prefix ($)
# Unfortunately, as a result we
Richard W.M. Jones went through the (tedious!) process of reviewing
all of libguestfs wrt gnulib's latest syntax-check rules, and reported
many false positives. In a few cases, I found ways to avoid entire
classes of false positives:
1/4 maint.mk: relax sc_prohibit_strcmp, to avoid a false
From: Jim Meyering meyer...@redhat.com
* top/maint.mk (sc_prohibit_strcmp): Relax regexp, so as to match
all uses of #define, not just those that start in column 1.
Richard W.M. Jones reported a false positive in
http://thread.gmane.org/gmane.comp.emulators.guestfs/1902
---
ChangeLog| 8
From: Jim Meyering meyer...@redhat.com
* top/maint.mk (sc_prohibit_path_max_allocation): Avoid false-positive
match for symbols like UNIX_PATH_MAX. Reported by Richard W.M. Jones
in http://thread.gmane.org/gmane.comp.emulators.guestfs/1902
---
ChangeLog| 7 +++
top/maint.mk | 2 +-
2
I noticed that the tight-scope syntax-check rule has been skipped
since the conversion to non-recursive make.
This makes it possible for me to reenable it.
(another patch is required in coreutils)
From 4eb373492e2fb171314215a2d68baa0a47c34918 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer
Karl Berry wrote:
regexprops-generic. The last one seems to be a mistake,
it should be fdl
I seem to recall that the issue there was that regexprops-generic is
both documentation and code. Therefore neither GPL nor GFDL work, and
dual licensing seems like far too much trouble.
Simon Josefsson wrote:
k...@freefriends.org (Karl Berry) writes:
regexprops-generic. The last one seems to be a mistake,
it should be fdl
I seem to recall that the issue there was that regexprops-generic is
both documentation and code. Therefore neither GPL nor GFDL work, and
Ed Maste wrote:
I have four test failures when running the gnulib test suite (at 6418d7c961)
on FreeBSD, some of which are clear FreeBSD bugs. My test host is FreeBSD
9.1-PRERELEASE (r240164M).
One that isn't clear to me is:
test-canonicalize-lgpl.c:98: assertion failed
Abort trap (core
Eric Blake wrote:
I compiled on FreeBSD 8.2 (gcc 4.2.1), and when I updated to the latest
gnulib, I started to see the following in config.log when running
./configure CFLAGS=-g:
configure:53920: checking whether C compiler handles -Wuninitialized
configure:53939: gcc -std=gnu99 -c -g
Eric Blake wrote:
On 09/06/2012 12:07 AM, Jim Meyering wrote:
Eric Blake wrote:
I compiled on FreeBSD 8.2 (gcc 4.2.1), and when I updated to the latest
gnulib, I started to see the following in config.log when running
./configure CFLAGS=-g:
When you configure with one set of warning
Jim Meyering wrote:
...
Yes, it looks like if we're using both of those, we'll have to
add code to reject -Wuninitialized (maybe with a warning?) when
configuring without -O.
...
[here's simple PoC, i.e., it doesn't know about -O0,
but you get the idea ]
W = -Wuninitialized -Werror
CFLAGS
Eric Blake wrote:
On 09/05/2012 02:08 PM, Mats Erik Andersson wrote:
Dear all,
the module readutmp is broken for the standard use
read_utmp(..., READ_UTMP_USER_PROCESS | READ_UTMP_CHECK_PIDS)
for all releases of FreeBSD until 8.3, and all OpenBSD ever released.
Thanks for the report.
While investigating the rm-vs-slash-decorated-symlink-to-dir problem,
I noticed this:
From 9322cc5db3a6efe4c19f274512a28767872384e4 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 4 Sep 2012 11:31:09 +0200
Subject: [PATCH] fts: when there is no risk of overlap, use
below and a trivial don't-trim-trailing-slashes
adjustment to remove.c, it does this:
$ env rm -r s/
rm: cannot remove 's/': Not a directory
From 99376a06eed07ded17919384cf1d633e43ad1bd0 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 4 Sep 2012 11:36:38 +0200
Jim Meyering wrote:
...
Subject: [PATCH] fts: reduce two or more trailing spaces to just one, usually
Glad I noticed the typo in that summary before pushing:
s/spaces/slashes/
Stefano Lattarini wrote:
On 09/04/2012 12:21 PM, Jim Meyering wrote:
While investigating the rm-vs-slash-decorated-symlink-to-dir problem,
I noticed this:
From 9322cc5db3a6efe4c19f274512a28767872384e4 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 4 Sep 2012 11
Eric Blake wrote:
On 09/04/2012 04:57 AM, Eric Blake wrote:
* lib/fts.c (fts_open): Upon initialization, if a name ends in two
or more slashes, trim all but the final one. But if a name consists
solely of two or more slashes, reduce it to //, not to /.
For two slashes, that is correct.
] == '/')
+ while (1 len v[len - 1] == '/')
+--len;
Here's the revised commit:
From 3a9002d3cc63da7110f133b1040d2d2b0aad8305 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 4 Sep 2012 11:36:38 +0200
Subject: [PATCH] fts: reduce two or more
Eric Blake wrote:
On 09/04/2012 04:57 AM, Eric Blake wrote:
* lib/fts.c (fts_open): Upon initialization, if a name ends in two
or more slashes, trim all but the final one. But if a name consists
solely of two or more slashes, reduce it to //, not to /.
For two slashes, that is correct.
[cc'ing bug-gnulib]
This started with a useful coreutils patch by Eric,
http://thread.gmane.org/gmane.comp.gnu.coreutils.general/3164
The thing is, it belongs in nearly every project that
also provides the configure-time --enable-gcc-warnings option:
Mike Frysinger wrote:
On Sat, Sep 1,
Jim Meyering wrote:
Simon Josefsson wrote:
Eric Blake ebl...@redhat.com writes:
On 08/02/2012 04:49 PM, Paul Eggert wrote:
On 08/02/2012 03:40 PM, Eric Blake wrote:
/* Store *ST's access time into *TS. */
static inline void
get_stat_atime (struct stat const *st, struct timespec *ts)
I'd
Paul Eggert wrote:
On 08/28/2012 05:13 AM, Jim Meyering wrote:
Since that same test passes just fine on a Solaris 10 system
to which I have access, I'm going to ignore it for now.
The same test also passes on a Solaris 11 system
that I have access to, so perhaps it's something
specific
Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 28 Aug 2012 13:49:37 +0200
Subject: [PATCH] tests: test-vc-list-files-git.sh: skip if git is not
available
The real failure was here:
FAIL: test-localeconv (exit: 262
Eric Blake wrote:
$(_sc_search_regexp) already prefixes its errors with $(ME), so
failure on one of these rules looked like:
maint.mk: maint.mk: replace strcmp calls above with STREQ/STRNEQ
* top/maint.mk (sc_prohibit_strcmp, sc_unmarked_diagnostics)
(sc_prohibit_defined_have_decl_tests,
Andrew Warshall wrote:
I'm seeing the same issue with 8.18. Apparently xterm doesn't write
to /var/run/utmp by default, so getlogin () fails with errno ==
ENOENT. However, isatty (0) still succeeds. The attached patch
(based on, though not interchangeable with, the sed command at
Eric Blake wrote:
I needed gcc's clz to determine the most significant bit of a
number (useful for things like truncating to a power of 2),
and was surprised it is not a standardized function (the
opposite direction of finding the least significant bit is
...
+/* Expand the code which
Simon Josefsson wrote:
I got this error from syntax-check:
jas@latte:~/src/libidn$ make sc_vulnerable_makefile_CVE-2012-3386
vulnerable_makefile_CVE-2012-3386
/bin/sh: 2: Syntax error: ( unexpected
make: *** [sc_vulnerable_makefile_CVE-2012-3386] Fel 2
jas@latte:~/src/libidn$
The patch
Simon Josefsson wrote:
Jim Meyering j...@meyering.net writes:
Adding quotes is the solution, but you must then remove
one layer of backslash quoting:
Of course, thank you. What I was mostly surprised about was that nobody
else had run into this. I suppose bash doesn't trigger the problem
74f52eafbc39a6f9a5bcbd7266d60e3f1052d7e8 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Sun, 5 Aug 2012 10:42:53 +0200
Subject: [PATCH] build: temporarily disable -Wmissing-declarations
* configure.ac: Disable -Wmissing-declarations to avoid warnings
from gnulib's newly extern-inline
Paul Eggert wrote:
On 08/05/2012 06:27 AM, Jim Meyering wrote:
* configure.ac: Disable -Wmissing-declarations to avoid warnings
from gnulib's newly extern-inline functions.
This shouldn't be needed if your compiler is sufficiently
new, because timespec.h's _GL_INLINE_HEADER_BEGIN
Jim Meyering wrote:
Paul Eggert wrote:
On 08/05/2012 06:27 AM, Jim Meyering wrote:
* configure.ac: Disable -Wmissing-declarations to avoid warnings
from gnulib's newly extern-inline functions.
This shouldn't be needed if your compiler is sufficiently
new, because timespec.h's
Jim Meyering wrote:
Jim Meyering wrote:
Paul Eggert wrote:
On 08/05/2012 06:27 AM, Jim Meyering wrote:
* configure.ac: Disable -Wmissing-declarations to avoid warnings
from gnulib's newly extern-inline functions.
This shouldn't be needed if your compiler is sufficiently
new, because
Jim Meyering wrote:
Jim Meyering wrote:
Jim Meyering wrote:
Paul Eggert wrote:
On 08/05/2012 06:27 AM, Jim Meyering wrote:
* configure.ac: Disable -Wmissing-declarations to avoid warnings
from gnulib's newly extern-inline functions.
This shouldn't be needed if your compiler
Stefano Lattarini wrote:
On 08/03/2012 10:14 AM, Stefano Lattarini wrote:
On 08/02/2012 07:49 PM, Eric Blake wrote:
On 08/02/2012 11:00 AM, Eric Blake wrote:
On 08/02/2012 10:53 AM, Stefano Lattarini wrote:
* modules/gnumakefile [Makefile.am]: The makefiles generated by
Automake-NG always
tags will allow packages to customize
filtering, e.g., to enable all c++-related warnings, but to exclude
warnings that are deemed obsolescent or too strict.
Suggestions welcome.
From 51d2b564fe80e603f4fb801b7265db9c27ce91ac Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Wed
Akim Demaille wrote:
Le 1 août 2012 à 10:59, Bruno Haible a écrit :
Akim Demaille wrote:
I used […] for default values, by habit (e.g., ./configure),
but I can restore to (default: …) if you prefer.
This notation […] is not widespread enough, IMO, that people would
immediately understand
Akim Demaille wrote:
Le 29 juil. 2012 à 20:11, Jim Meyering a écrit :
- $(emit-commit-log) .ci-msg
- $(VC) commit -F .ci-msg -a
- rm .ci-msg
+ $(emit-commit-log) \
+ | (cd $(srcdir) $(VC) commit -F - -a)
I do like avoiding the temporary file, but this induces a down side
401 - 500 of 3390 matches
Mail list logo
