Re: announce-gen: minor issues

2012-05-23 Thread Jim Meyering
Akim Demaille wrote: Le 23 mai 2012 à 10:02, Akim Demaille a écrit : The two attached patches provide minor improvements to announce-gen. The first one was prompted by the fact that I had an error message whose origin was unclear. Hi Akim, Thanks for the patches! * build-aux/announce-gen:

Re: maint.mk: sed portability

2012-05-23 Thread Jim Meyering
Akim Demaille wrote: A simple sed syntax issue, and while at it, a small simplification. * top/maint.mk (gpg_key_ID): End blocks with a semicolon before the closing brace. (refresh-po): Fuse two sed invocations into one. Thanks! I've adjusted the log. maint.mk is big; saying that only the

Re: announce-gen: minor issues

2012-05-23 Thread Jim Meyering
Akim Demaille wrote: Hi Jim! Le 23 mai 2012 à 10:34, Jim Meyering a écrit : * build-aux/announce-gen: When parsing command line options, prefer announce-gen: option --release-type requires an argument to Option release-type requires an argument. This is an improvement, but for the fact

Re: [PATCH] gitlog-to-changelog: support the log message format used in Bison

2012-05-22 Thread Jim Meyering
Akim Demaille wrote: Hi Jim, What do you think about the attached proposal? It started here: http://lists.gnu.org/archive/html/bug-gnulib/2012-05/msg00217.html Le 15 mai 2012 à 10:02, Akim Demaille a écrit : Le 14 mai 2012 à 17:19, Akim Demaille a écrit :

Re: [PATCH] gitlog-to-changelog: support the log message format used in Bison

2012-05-22 Thread Jim Meyering
Akim Demaille wrote: Le 22 mai 2012 à 11:42, Jim Meyering a écrit : Hi Akim, Hi! That looks fine, with this change squashed in. Ok with you? Sure! That's perfect, thanks! Pushed ;-)

Re: [PATCH] ignore-value: remove deprecated ignore_ptr function

2012-05-14 Thread Jim Meyering
Bruno Haible wrote: Jim Meyering wrote on 2012-01-10: We deprecated ignore_ptr a year ago: http://thread.gmane.org/gmane.linux.utilities.util-linux-ng/3784/focus=3802 So I've removed it. ... +2012-01-10 Jim Meyering meyer...@redhat.com + +ignore-value: remove deprecated

Re: [PATCH] bootstrap: take advantage of POSIX shell features

2012-05-13 Thread Jim Meyering
Stefano Lattarini wrote: The 'bootstrap' script offered by Gnulib script already uses POSIX shell features (like $((...)) arithmetic expansions) that are not supported by legacy Bourne shells like Solaris 10 /bin/sh. This means that bootstrap must already be run using a proper POSIX shell,

Re: [PATCH] bootstrap: take advantage of POSIX shell features

2012-05-13 Thread Jim Meyering
Stefano Lattarini wrote: Hi Jim. On 05/13/2012 10:31 AM, Jim Meyering wrote: diff --git a/build-aux/bootstrap b/build-aux/bootstrap ... @@ -442,7 +442,7 @@ check_versions() { # GNU automake-ng) when asked their version. case $app in automake-ng|aclocal-ng) -app

Re: How can I import build-aux/po/Makefile.in.in

2012-05-08 Thread Jim Meyering
Eric Blake wrote: ... Meanwhile, no one ever reviewed my proposed doc patch: https://lists.gnu.org/archive/html/bug-gnulib/2012-04/msg00167.html Links to mailman-archived messages are hard to read the moment they contain a few @ (address@obfuscated) signs, so texinfo is much easier to read via

Re: [PATCH] warnings.m4: provide a means to specify the program to compile

2012-05-08 Thread Jim Meyering
Akim Demaille wrote: I have submitted this patch several times in this thread (starting at http://lists.gnu.org/archive/html/bug-gnulib/2012-04/msg00049.html), and for some reason it remains unnoticed, and uncommented. Please let me know what is wrong in my approach. I would like to wrap a

[PATCH 1/2] init.sh: don't let bash aliases interfere with tests

2012-05-08 Thread Jim Meyering
FYI, I've pushed these two patches: From a396e729684ec533c504dd3e619f669834821688 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Tue, 8 May 2012 10:55:21 +0200 Subject: [PATCH 1/2] init.sh: don't let bash aliases interfere with tests * tests/init.sh: Undefine any pre

Re: [PATCH] warnings.m4: provide a means to specify the program to compile

2012-05-08 Thread Jim Meyering
Jim Meyering wrote: Akim Demaille wrote: ... The attached patch enhances warnings.m4 in several ways: - gl_COMPILER_OPTION_IF allows to define more fine grain tests on the behavior of the compiler. Forcing the result to be an assignment to a variable (which is AC_SUBST'ed) does not seem

Re: cross-compilation guesses (12)

2012-05-05 Thread Jim Meyering
Bruno Haible wrote: This cross-compilation guess is also suboptimal: checking for d_ino member in directory struct... no since d_ino is known to work on glibc/Linux since ever: glibc/sysdeps/unix/sysv/linux/bits/dirent.h is essentially unchanged since 1997. 2012-05-05 Bruno Haible

Re: cross-compilation guesses (13)

2012-05-05 Thread Jim Meyering
Bruno Haible wrote: Another suboptimal cross-compilation guess is checking whether tzset clobbers localtime buffer... yes This fixes it. 2012-05-05 Bruno Haible br...@clisp.org tzset: Avoid guessing wrong when cross-compiling to glibc systems. * m4/tzset.m4

Re: cross-compilation guesses (15)

2012-05-05 Thread Jim Meyering
Bruno Haible wrote: Another suboptimal cross-compilation guess is checking for working nanosleep... cross-compiling This test has 3 possible results: - yes, it works, no override needed. - no (mishandles large arguments), means it works halfway, the override in lib/nanosleep.c

Re: cross-compilation guesses (5)

2012-05-03 Thread Jim Meyering
Bruno Haible wrote: Jim Meyering wrote: However, I would find the above code easier to read if it were written on fewer lines: case $host_os in *-gnu*) $1 ;; # Guess yes on glibc systems. *) $2 ;; # If we don't know, assume the worst. esac Will it also work if $1

Re: cross-compilation guesses (2)

2012-05-02 Thread Jim Meyering
Bruno Haible wrote: 2) On glibc systems, which are often used as cross-compilation targets (think of embedded systems (routers, map navigation devices, etc.)), the cross-compilation guesses should better be correct. I.e. when no problem is known on glibc systems or Linux, the

Re: cross-compilation guesses (8)

2012-05-02 Thread Jim Meyering
Bruno Haible wrote: When cross-compiling, canonicalize.m4 also guesses wrong: checking whether realpath works... guessing no This should fix it. Objections? This looks fine. Thanks. 2012-05-01 Bruno Haible br...@clisp.org canonicalize[-lgpl]: Avoid guessing no when

Re: cross-compilation guesses (7)

2012-05-02 Thread Jim Meyering
Bruno Haible wrote: When cross-compiling, I also see this wrong guess: checking whether gettimeofday clobbers localtime buffer... yes This proposed patch should improve it. OK to apply, Jim Paul? 2012-05-01 Bruno Haible br...@clisp.org gettimeofday: Avoid bad guess when

Re: cross-compilation guesses (6)

2012-05-02 Thread Jim Meyering
Bruno Haible wrote: When cross-compiling, configure also reports wrongly: checking whether lstat correctly handles trailing slash... no Here is a proposed patch. Jim, OK to apply? 2012-05-01 Bruno Haible br...@clisp.org lstat: Avoid guessing no when cross-compiling to glibc

Re: cross-compilation guesses (5)

2012-05-02 Thread Jim Meyering
Bruno Haible wrote: Configure outputs when cross-compiling: checking for GNU libc compatible malloc... no checking for GNU libc compatible realloc... no Here's a proposed patch for improving the guess for glibc targets. Again, the question is whether to modify the macro in Autoconf

Re: cross-compilation guesses (4)

2012-05-02 Thread Jim Meyering
get a slightly better perspective when viewing the diff ignoring space changes. diff --git a/m4/getgroups.m4 b/m4/getgroups.m4 index 796a831..a642a07 100644 --- a/m4/getgroups.m4 +++ b/m4/getgroups.m4 @@ -1,4 +1,4 @@ -# serial 17 +# serial 18 dnl From Jim Meyering. dnl A wrapper around

Re: RRI - copyright assignment mailed in

2012-04-27 Thread Jim Meyering
Aharon Robbins wrote: ... And I got an official email from the FSF legal elves that my paperwork was received. :-) In general, you(as a gnu maintainer) can check copyright assignment status with a command like like this: ssh fencepost.gnu.org grep -i 'gnulib.*robbins' \~gnuorg/copyright.list

Re: [PATCH] bootstrap: support Automake-NG in $buildreq

2012-04-26 Thread Jim Meyering
Stefano Lattarini wrote: * bootstrap (check_versions): Handle automake and aclocal from Automake-NG specially. They can be specified as respectively the automake-ng and aclocal-ng requirements. Signed-off-by: Stefano Lattarini stefano.lattar...@gmail.com --- build-aux/bootstrap | 17

Re: [libvirt] [PATCH] build: Fix version of gettext macros

2012-04-25 Thread Jim Meyering
Eric Blake wrote: On 04/25/2012 07:04 AM, Jim Meyering wrote: We need to fix gnulib to not force us to use gettext 0.18. I'll look into this. Here's what I'm playing with now; so far, it appears to make life happy for libvirt with its intentional AM_GNU_GETTEXT_VERSION([0.17]). Jim, does

Re: [libvirt] [PATCH] build: Fix version of gettext macros

2012-04-25 Thread Jim Meyering
Eric Blake wrote: [trimming cc's for now] On 04/25/2012 09:38 AM, Jim Meyering wrote: Another possible alternative: install the precise 0.17 Makefile.in.in via libvirt's gnulib-local, so that when gnulib-tool runs, we are back to bootstrap picking up the version that we know we want to use

Re: [PATCH] bootstrap: accommodate older libtool

2012-04-20 Thread Jim Meyering
Eric Blake wrote: RHEL 5 still ships with libtool 1.5.22, where libtoolize lacks the --install option but has that behavior by default. And gnulib's DEPENDENCIES file states that we still support that old of libtool as our minimum version. * build-aux/bootstrap (use_libtool): Cater to

Re: Fix to bootstrap

2012-04-19 Thread Jim Meyering
. + 2012-04-16 Akim Demaille a...@lrde.epita.fr and Jim Meyering meyer...@redhat.com Thanks for tracking that down. However, rather than handling just that one cd, how about ensuring that no use of cd in this script can cause such trouble? To do that, you would unset CDPATH somewhere near

Re: Problem with Digest::SHA and announce-gen

2012-04-19 Thread Jim Meyering
Reuben Thomas wrote: I have Digest::SHA installed, but I still get an error about being unable to find Digest::SHA1: $ perl -e 'use Digest::SHA;' $ perl build-aux/announce-gen Can't locate Digest/SHA1.pm in @INC (@INC contains: /home/rrt/local/x86_64-linux-gnu-thread-multi/lib/perl/5.14.2

Re: Use of gnulib's cfg.mk

2012-04-16 Thread Jim Meyering
Reuben Thomas wrote: On 14 April 2012 20:17, Reuben Thomas r...@sc3d.org wrote: On 14 April 2012 19:44, Bruno Haible br...@clisp.org wrote: Reuben Thomas wrote: I see that gnulib has its own cfg.mk which is used, for example, to skip some syntax-check checks on gnulib's own code. ... I

[PATCH] configmake: correct minor inconsistency in Makefile rule

2012-04-16 Thread Jim Meyering
5a206b3d9b45550b1c4a928cd51deaf1438cb4c8 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Mon, 16 Apr 2012 18:22:40 +0200 Subject: [PATCH] configmake: correct minor inconsistency in Makefile rule * modules/configmake (Makefile.am): All other rules like this one run the final mv -f ... in the same

Re: How can I import build-aux/po/Makefile.in.in

2012-04-16 Thread Jim Meyering
Akim Demaille wrote: Le 16 avr. 2012 à 12:16, Jim Meyering a écrit : diff --git a/build-aux/bootstrap b/build-aux/bootstrap index 31eb651..d749fe2 100755 --- a/build-aux/bootstrap +++ b/build-aux/bootstrap @@ -1,6 +1,6 @@ #! /bin/sh # Print a version string. -scriptversion=2012-02-11.09

Re: How can I import build-aux/po/Makefile.in.in

2012-04-16 Thread Jim Meyering
Akim Demaille wrote: Le 16 avr. 2012 à 12:16, Jim Meyering a écrit : diff --git a/build-aux/bootstrap b/build-aux/bootstrap index 31eb651..d749fe2 100755 --- a/build-aux/bootstrap +++ b/build-aux/bootstrap @@ -1,6 +1,6 @@ #! /bin/sh # Print a version string. -scriptversion=2012-02-11.09

Re: [PATCH] maint.mk: catch see @xref{}

2012-04-16 Thread Jim Meyering
Akim Demaille wrote: FWIW, it does catch things in Bison's documentation: texinfo_see_xref 8008:@option{--verbose} are specified, see @xref{Invocation, , Invoking 10255:See @pxref{Java Action Features}. 10271:left-hand side of assignments. See @pxref{Java Semantic Values} and 10288:that

Re: [PATCH] maint.mk: catch see @xref{}

2012-04-16 Thread Jim Meyering
Eric Blake wrote: On 04/16/2012 12:22 PM, Jim Meyering wrote: +++ b/top/maint.mk @@ -932,8 +932,11 @@ sc_prohibit_doubled_word: # A regular expression matching undesirable combinations of words like # can not; this matches them even when the two words appear on different # lines

Re: [PATCH] maint.mk: catch see @xref{}

2012-04-16 Thread Jim Meyering
Jim Meyering wrote: Eric Blake wrote: On 04/16/2012 12:22 PM, Jim Meyering wrote: +++ b/top/maint.mk @@ -932,8 +932,11 @@ sc_prohibit_doubled_word: # A regular expression matching undesirable combinations of words like # can not; this matches them even when the two words appear

Re: [PATCH] maint.mk: catch see @xref{}

2012-04-16 Thread Jim Meyering
Jim Meyering wrote: Jim Meyering wrote: Eric Blake wrote: On 04/16/2012 12:22 PM, Jim Meyering wrote: +++ b/top/maint.mk @@ -932,8 +932,11 @@ sc_prohibit_doubled_word: # A regular expression matching undesirable combinations of words like # can not; this matches them even when the two

Re: GCC 4.4 at least for mips has no -Wsuggest-attribute=pure

2012-04-04 Thread Jim Meyering
://gcc.gnu.org/gcc-4.6/changes.html that option was added in 4.6, not 4.3. I've pushed this: From d4cecf1ee37f6b611ef092c9c7fa3761d02ce2c3 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Wed, 4 Apr 2012 13:32:15 +0200 Subject: [PATCH] regex: correct #pragma guard expression

Re: large integer truncation in regex module

2012-03-26 Thread Jim Meyering
Gianluigi Tiesi wrote: On 26/03/2012 7.33, Jim Meyering wrote: Gianluigi Tiesi wrote: On 25/03/2012 6.58, Paul Eggert wrote: On 03/24/2012 09:28 PM, Gianluigi Tiesi wrote: While compiling regex module one android I've discovered a problem that on other 32bit compiler is only a warning

Re: large integer truncation in regex module

2012-03-25 Thread Jim Meyering
Gianluigi Tiesi wrote: On 25/03/2012 6.58, Paul Eggert wrote: On 03/24/2012 09:28 PM, Gianluigi Tiesi wrote: While compiling regex module one android I've discovered a problem that on other 32bit compiler is only a warning ... it's correct, but I think an ifdef may be used instead since

Re: should an empty pkgdata_DATA cause creation of $(pkgdatadir) by make install?

2012-03-23 Thread Jim Meyering
Stefano Lattarini wrote: ... [1] http://savannah.gnu.org/bugs/?group=automake (As a partial off-topic: is there any way to shut this down? Since we don't use the savannah tracker, allowing new issues to be opened there is only going to be cause of confusion or duplication). Yes. You (as

Re: Revised announce-gen patch

2012-03-21 Thread Jim Meyering
Reuben Thomas wrote: Implementing Jim's suggestions. From 3e6c32b5834341ee8d1870f7b85db546b1a1f2d8 Mon Sep 17 00:00:00 2001 From: Reuben Thomas r...@sc3d.org Date: Tue, 20 Mar 2012 20:17:22 + Subject: [PATCH] announce-gen: make it use Digest::SHA where available. *

announce-gen: require perl-5.9.3

2012-03-21 Thread Jim Meyering
Eric Wong wrote: How about using the generic Digest module instead? Something like this (totally untested) patch: diff --git a/build-aux/announce-gen b/build-aux/announce-gen index 3ca90a9..c453d44 100755 --- a/build-aux/announce-gen +++ b/build-aux/announce-gen @@ -29,8 +29,7 @@ my

Re: submodules again

2012-03-21 Thread Jim Meyering
Werner LEMBERG wrote: Folks, the default operation (a) of `bootstrap' is clear: 1. The `gnulib' submodule URL is in file `.gitmodules'. 2. No special submodule entry in `.git/config'. 3. A (submodule) clone of `gnulib' is created. 4. All files of `gnulib' are checked out. If I

Re: submodules again

2012-03-21 Thread Jim Meyering
Eric Blake wrote: On 03/21/2012 01:44 PM, Jim Meyering wrote: git-submodule's --reference option looks like it does what you want. However, balancing the repo duplication cost against the risk of error described in git-clone's --reference and --shared descriptions, so far, I have preferred

Re: Pushing tags in README-release

2012-03-20 Thread Jim Meyering
Reuben Thomas wrote: Unless I'm missing something, there's nothing that does git push --tags in README-release. Is that right? If so, I'll provide a patch. You don't want to push all tags. This pushes the just-created tag: * Push the NEWS-updating changes and the new tag: v=$(cat

Re: Fix build-aux/announce-gen for Perl 5.14

2012-03-20 Thread Jim Meyering
Reuben Thomas wrote: The following patch copes with a renamed module: It appears that it hasn't been renamed, but rather replaced, at least in Debian. http://wiki.debian.org/Teams/DebianPerlGroup/OpenTasks/Transitions/DigestSHA1ToDigestSHA From: Reuben Thomas r...@sc3d.org Date: Tue, 20

Re: new snapshot available: coreutils-8.15.74-be17e3

2012-03-18 Thread Jim Meyering
Hi Bruno, Bruno Haible wrote: [Removing platform-testers and the translation coordinator from the CC.] Thanks. I've adjusted my snapshot-announcement-creation script to add a Mail-Followup-To: header, so that won't happen again. Paul Eggert wrote: ... Bruno explained that this is a problem

Re: [PATCH] git-version-gen: initialize prefix

2012-03-18 Thread Jim Meyering
Andreas Oberritter wrote: Initialize (version-)prefix to prevent inheritance from the build environment during autoreconf. | sed: -e expression #1, char 9: unknown option to `s' | configure.ac:55: error: AC_INIT should be called with package and | version arguments | aclocal.m4:594:

Re: [PATCH] tests: exercise two recently-fixed bugs

2012-03-17 Thread Jim Meyering
Paul Eggert wrote: On 03/16/2012 02:50 PM, Jim Meyering wrote: the TABs (maybe required in glibc?) Yes, that's right. Currently I'm having problems getting mktime fixes back into glibc, and one of the issues is that we expanded tabs to spaces. What a hassle. I know the pain ;-) but would

Re: [PATCH] tests: exercise two recently-fixed bugs

2012-03-16 Thread Jim Meyering
Paul Eggert wrote: I think we should give a repeat count too large error here. The regex is being compiled to a different meaning than what the user intended. Yes, definitely. In testing, I noticed that we diagnose the range error in the regexp path, but not in the DFA one, but haven't

[PATCH] readtokens.c: adjust wording in a comment

2012-03-09 Thread Jim Meyering
FYI, trivial: From 97a6d2487ec73f5093e8ebd59b8b843d37ed64e4 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Fri, 9 Mar 2012 12:01:45 +0100 Subject: [PATCH] readtokens.c: adjust wording in a comment * lib/readtokens.c: Insert omitted that in a comment. --- ChangeLog

Re: copyright ranges in build-aux/ tools

2012-03-09 Thread Jim Meyering
Simon Josefsson wrote: I notice there are some gaps in copyright ranges in some build-aux tools, for example: csharpcomp.sh.in:# Copyright (C) 2003-2006, 2009-2012 Free Software Foundation, Inc. csharpexec.sh.in:# Copyright (C) 2003, 2005, 2009-2012 Free Software Foundation, Inc.

Re: copyright ranges in build-aux/ tools

2012-03-09 Thread Jim Meyering
Simon Josefsson wrote: Jim Meyering j...@meyering.net writes: Simon Josefsson wrote: I notice there are some gaps in copyright ranges in some build-aux tools, for example: csharpcomp.sh.in:# Copyright (C) 2003-2006, 2009-2012 Free Software Foundation, Inc. csharpexec.sh.in:# Copyright (C

Re: [PATCH] test-readtokens.c: avoid const-related compilation warnings

2012-03-08 Thread Jim Meyering
Bruno Haible wrote: Jim Meyering wrote: @@ -77,7 +77,7 @@ main (int argc, char **argv) if (STREQ (delim, \\0)) { - delim = ; + delim = (char *) ; delim_len = 1; } Instead of introducing this cast, how about making 'delim' a 'const char *'? I see no code

[PATCH] quotearg: the module must now include quote.h

2012-03-07 Thread Jim Meyering
FYI, Without this, a package using only the quotearg module would fail to compile due to the lack of the now-required quote.h. From 825091834f1fca679e1547665edcbc083be85c35 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Wed, 7 Mar 2012 15:44:33 +0100 Subject: [PATCH

[PATCH] frexp-nolibm-tests: include required test-frexp.h

2012-03-07 Thread Jim Meyering
compilation terminated. Here's the proposed fix: From 98ea8f52840376969518ff047b094f157a078d0e Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Wed, 7 Mar 2012 22:14:25 +0100 Subject: [PATCH] frexp-nolibm-tests: include required test-frexp.h * modules/frexp-nolibm-tests (Files

Re: [PATCH] frexp-nolibm-tests: include required test-frexp.h

2012-03-07 Thread Jim Meyering
Jim Meyering meyer...@redhat.com +frexp-nolibm-tests: include required test-frexp.h +* modules/frexp-nolibm-tests (Files): Add test-frexp.h, which +is included by test-frexp.c. +Also add tests/randomd.c, required due to test-frexp.h's use +of RANDOM

[PATCH] maint: don't specify XZ_OPT=-9ev in dist-related rule

2012-03-02 Thread Jim Meyering
FYI, From eb213779301aa663ab84ac947e8e181e9ad554d0 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Fri, 2 Mar 2012 18:35:12 +0100 Subject: [PATCH] maint: don't specify XZ_OPT=-9ev in dist-related rule Using xz's -9 option is warranted only if you have a very large tarball

Re: [PATCH] maint.mk: add per-line exclusions to prohibitions

2012-03-01 Thread Jim Meyering
1b98d11e35032bd2ceb1c4a67b66d4655100eeea Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Thu, 1 Mar 2012 23:13:34 +0100 Subject: [PATCH] maint.mk: avoid spurious failure of _sc_search_regexp-using tests * top/maint.mk: Initialize _sc_search_regexp parameters, so that envvar

Re: prohibit_strcmp

2012-02-24 Thread Jim Meyering
fbca75fddb6918c0667783a7805847fc3bf78578 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Fri, 24 Feb 2012 10:02:18 +0100 Subject: [PATCH] doc: clarify a comment in system.h * src/system.h (STRNCMP_LIT): Clarify comment. Suggested by Bruno Haible. --- src/system.h |2 +- 1 file

Re: prohibit_strcmp

2012-02-24 Thread Jim Meyering
Jim Meyering wrote: Akim Demaille wrote: Also, FWIW, in Bison there are many more strcmp, but they do not conform to the sc pattern. src/ielr.c:if (0 == strcmp (type, lalr)) src/ielr.c:else if (0 == strcmp (type, ielr)) src/ielr.c:else if (0 == strcmp (type, canonical-lr

Re: prohibit_strcmp

2012-02-24 Thread Jim Meyering
Akim Demaille wrote: Le 24 févr. 2012 à 10:08, Jim Meyering a écrit : Here's a complete patch, with the additional tweak of replacing the other occurrence of str''cmp with $(s_). Actually I don't think you need it. Ironically, you need it only when not factoring it, and this gives

Re: [PATCH] tests: add missing sys/types.h for ls speed-up test

2012-02-20 Thread Jim Meyering
Eric Blake wrote: On 02/19/2012 10:45 AM, Jim Meyering wrote: Jérémy Compostella wrote: Thank you for the report and the patch. Please tell us what type/version of compiler/system you're using. It's good to include that information, especially since ssize_t is supposed to be defined via

Re: copyright years breaking sync with automake

2012-02-18 Thread Jim Meyering
Karl Berry wrote: The following files are/were all synced from automake. They had their copyright years unified in gnulib. But not in automake. Can this be resolved one way or another, please? build-aux/ar-lib build-aux/compile build-aux/depcomp build-aux/elisp-comp

Re: gitlog-to-changelog option --tear-off

2012-02-18 Thread Jim Meyering
Werner Koch wrote: On Sun, 12 Feb 2012 22:48, j...@meyering.net said: Hard-coding --... My point was that we may not want to hard-code --. What if someone includes email with a -- line followed by a signature? ... Okay. Here comes the fixed patch: From

Re: README-release: more improvements

2012-02-11 Thread Jim Meyering
Reuben Thomas wrote: Happily, Jim’s objections to some of my earlier suggestions removed a great deal of the remaining patches I was going to suggest, so the following is quite simple: Thanks. Pushed.

[PATCH] bootstrap: don't exit 0 upon gnulib-tool failure

2012-02-11 Thread Jim Meyering
by as configure and make ran. Oops. Here's the fix: From de009b65198c00dbe0ecd796ce75d5d9f5346103 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Sat, 11 Feb 2012 10:57:28 +0100 Subject: [PATCH] bootstrap: don't exit 0 upon gnulib-tool failure * build-aux/bootstrap

Re: Patch to README-release

2012-02-09 Thread Jim Meyering
Reuben Thomas wrote: Ping? This is quite a simple patch, basically just a couple of punctuation fixes! Hi Reuben, The patch is ok (capitalize one letter and insert a newline), but is perhaps too small, especially since I think you have a few more affecting the same file. I've gone ahead and

Re: [PATCH 1/3] regex: merge glibc changes

2012-02-08 Thread Jim Meyering
Paul Eggert wrote: * lib/regcomp.c (init_dfa): Tighten overflow checks to test ...many patches... Thank you for handling that tedious task!

Re: [PATCH] maint: spelling fixes

2012-02-05 Thread Jim Meyering
Paul Eggert wrote: I pushed these gnulib spelling fixes as obvious and trivial. My fave was Free Softward Foundation. Thanks! What tool do you use for that? It would be nice to have a batch spell-checker that we could run periodically.

Re: [bug-idutils] [PATCH 1/9] tests: disable gnulib's get-rusage-as test

2012-02-04 Thread Jim Meyering
Bruno Haible wrote: Hi Jim, That test fails on Fedora 16 and I didn't have time to investigate. Here are details, and I'm Cc'ing bug-gnulib: $ ./test-get-rusage-as ../../gltests/test-get-rusage-as.c:56: assertion failed zsh: abort (core dumped) ./test-get-rusage-as Can you

Re: [bug-idutils] [PATCH 1/9] tests: disable gnulib's get-rusage-as test

2012-02-04 Thread Jim Meyering
-rusage-as.c (main): Assign the malloc() results to global variables. * tests/test-get-rusage-data.c (main): Likewise. Reported by Jim Meyering. Nice! Thanks for investigating and fixing that. I've undone the exclusion in idutils. And thanks to Claudio for keeping me honest ;-)

Re: [bug-idutils] [PATCH 1/9] tests: disable gnulib's get-rusage-as test

2012-02-03 Thread Jim Meyering
Claudio Fontana wrote: On Thu, Feb 2, 2012 at 8:38 AM, Jim Meyering j...@meyering.net wrote: From: Jim Meyering meyer...@redhat.com * bootstrap.conf (avoided_gnulib_modules): Disable the get-rusage-as test: it's failing. Hi Jim, why are you disabling this test? When I was maintaining

[PATCH] file-has-acl: suppress a warning from gcc -Wsuggest-attribute=const

2012-02-02 Thread Jim Meyering
FYI, From 93f8bee70d1bc611bead8a826edf0a932c2b8999 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Thu, 2 Feb 2012 09:12:13 +0100 Subject: [PATCH] file-has-acl: suppress a warning from gcc -Wsuggest-attribute=const * lib/file-has-acl.c (file_has_acl): This function

Re: AM_CPPFLAGS best practice

2012-02-02 Thread Jim Meyering
Eric Blake wrote: The manual (gnulib-tool.texi) recommends including both builddir and srcdir into AM_CPPFLAGS (aka INCLUDES if you are using automake 1.9), which makes sense, since some headers come straight from gnulib and live in srcdir, while other headers are generated based on configure

Re: [PATCH] maint.mk: also prohibit lower-case @var@

2012-02-02 Thread Jim Meyering
: also prohibit lower-case @var@ + * top/maint.mk (sc_makefile_at_at_check): Enhance check to cover + lower case, like @top_srcdir@. + 2012-02-02 Jim Meyering meyer...@redhat.com file-has-acl: suppress a warning from gcc -Wsuggest-attribute=const diff --git a/top/maint.mk b/top

Re: base64 decoding more tolerant to chars

2012-01-31 Thread Jim Meyering
Nikos Mavrogiannopoulos wrote: On 01/30/2012 10:29 PM, Jim Meyering wrote: Hi Nikos, Have you considered pre-filtering the data you pass to the base64-decoding function? We considered what you're proposing when adding the --ignore-garbage option to the command-line base64 program: Could

Re: base64 decoding more tolerant to chars

2012-01-30 Thread Jim Meyering
Nikos Mavrogiannopoulos wrote: This patch makes the base64 decoding tolerant on carriage returns, spaces and tabs. It is quite common to find PEM encoded files (base64 with new lines) containing such characters and having a tolerant decoder is a plus. Hi Nikos, Have you considered

Re: bug#10305: coreutils-8.14, rm -r fails with EBADF

2012-01-29 Thread Jim Meyering
severity 10305 wishlist tags 10305 + notabug thanks Eric Blake wrote: On 12/21/2011 11:42 AM, Paul Eggert wrote: On 12/21/11 08:27, Eric Blake wrote: maybe we should wrap opendir() so that the gnulib rpl_opendir() always opens a directory at the same time That sounds a bit drastic, but it

[PATCH] maint.mk: sc_prohibit_canonicalize_without_use: avoid false positive

2012-01-29 Thread Jim Meyering
This is a prerequisite for a coreutils patch I'm about to post: From bfb5863e350590d8fe9a643d840c7d0b5f3d934b Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Sun, 29 Jan 2012 22:30:20 +0100 Subject: [PATCH] maint.mk: sc_prohibit_canonicalize_without_use: avoid false

Re: Patches to README-release

2012-01-28 Thread Jim Meyering
Gary V. Vaughan wrote: Hi Jim, On 28 ม.ค. 2012, at 1:21, Jim Meyering j...@meyering.net wrote: Reuben Thomas wrote: Ping? The patches still apply cleanly to HEAD. On 22 December 2011 19:54, Reuben Thomas r...@sc3d.org wrote: -* Ensure that the desired

[PATCH] maint.mk: use more readable (yet functionally equivalent) quoting

2012-01-28 Thread Jim Meyering
FYI, From e55b2563934c2d4b9c20c0d678a922e871aa25f8 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Sat, 28 Jan 2012 10:16:25 +0100 Subject: [PATCH] maint.mk: use more readable (yet functionally equivalent) quoting It is common to quote a single quote in a single quoted

Re: Patches to README-release

2012-01-28 Thread Jim Meyering
Gary V. Vaughan wrote: Hi Jim, On 28 Jan 2012, at 15:27, Jim Meyering wrote: Gary V. Vaughan wrote: Hi Jim, On 28 ม.ค. 2012, at 1:21, Jim Meyering j...@meyering.net wrote: Reuben Thomas wrote: Ping? The patches still apply cleanly to HEAD. On 22 December 2011 19:54

Re: Patches to README-release

2012-01-28 Thread Jim Meyering
Gary V. Vaughan wrote: On 28 Jan 2012, at 15:27, Jim Meyering wrote: Gary V. Vaughan wrote: Hi Jim, On 28 ม.ค. 2012, at 1:21, Jim Meyering j...@meyering.net wrote: Reuben Thomas wrote: Ping? The patches still apply cleanly to HEAD. On 22 December 2011 19:54, Reuben

Re: Patches to README-release

2012-01-28 Thread Jim Meyering
Gary V. Vaughan wrote: Hi Jim, On 28 Jan 2012, at 16:28, Jim Meyering wrote: Gary V. Vaughan wrote: I'm wondering what purpose AC_PREREQ (etc) really serves if you're not using them to encode the versions of the autotools that are required to bootstrap a package in the way expected

Re: test-init.sh failure on AIX 7.1

2012-01-28 Thread Jim Meyering
Bruno Haible wrote: The recently added test-init.sh test fails on AIX 7.1: --- exp 2012-01-28 18:51:15.0 + +++ out 2012-01-28 18:51:15.0 + @@ -1,3 +1,3 @@ --- empty +++ in - +xyz + + xyz FAIL: test-init.sh ... Hi Bruno, Thanks for the analysis and

Re: update-copyright request and patch...

2012-01-27 Thread Jim Meyering
the FSF. For everyone's benefit, the FSF confirmed that it is fine to do so (case [gnu.org #719834]). Thanks. Here's an adjusted version of update-copyright that implements that. From 87d33f7e78fcafd860fa3a53a39d4ad669a53f00 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date

Re: update-copyright request and patch...

2012-01-27 Thread Jim Meyering
Jim Meyering wrote: Joel Brobecker wrote: Yep, this is what we did for this year. I just want to go one step further and just collapse all years into one single range, based on the fact that I have verified that we have made significant changes to at least one file each year since 1986

Re: Patches to README-release

2012-01-27 Thread Jim Meyering
Reuben Thomas wrote: Ping? The patches still apply cleanly to HEAD. On 22 December 2011 19:54, Reuben Thomas r...@sc3d.org wrote: A series of patches that attempt to improve a few minor formatting problems and also streamline some of the steps. ... From

Re: test-lock taking a long time?

2012-01-25 Thread Jim Meyering
8aa5b7111e46db425414ae33d5c07cef411e4630 Author: Jim Meyering meyer...@redhat.com Date: Mon Mar 21 09:45:01 2011 +0100 tests: skip annoyingly long gnulib lock tests * bootstrap.conf (avoided_gnulib_modules): Skip the lock tests. They take too long. diff --git a/bootstrap.conf b/bootstrap.conf index

[PATCH] tests: avoid spurious warning about gl_sockets_startup

2012-01-23 Thread Jim Meyering
how it always returns 0 for non-Windows systems. IMHO, it's fine just to ignore failure in tests/*.c. Since (void) works, I'm not bothering with ignore-value.h. From 722f6dd800d2885c71106aa4ac79c7ae265822ae Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Mon, 23 Jan 2012 15

Re: [PATCH 2/7] maint: remove empty lines at EOF

2012-01-21 Thread Jim Meyering
Eric Blake wrote: On 01/21/2012 04:14 AM, Jim Meyering wrote: From: Jim Meyering meyer...@redhat.com * man/autoconf.x: Remove empty line at EOF. * man/autoheader.x: Likewise. * man/autoscan.x: Likewise. * man/autoupdate.x: Likewise. * man/ifnames.x: Likewise. * tests/compile.at: Likewise

Re: [PATCH 2/8] maint: remove empty lines at EOF, but excluding modules/*

2012-01-21 Thread Jim Meyering
Eric Blake wrote: On 01/17/2012 11:44 AM, Jim Meyering wrote: * doc/INSTALL: Likewise. * doc/INSTALL.ISO: Likewise. * doc/INSTALL.UTF-8: Likewise. These files are generated through doc/Makefile. Also, on text files that consist of multiple paragraphs, I find it good (esthetic) to have

Re: [PATCH 2/8] maint: remove empty lines at EOF, but excluding modules/*

2012-01-21 Thread Jim Meyering
Jim Meyering wrote: Eric Blake wrote: On 01/17/2012 11:44 AM, Jim Meyering wrote: * doc/INSTALL: Likewise. * doc/INSTALL.ISO: Likewise. * doc/INSTALL.UTF-8: Likewise. These files are generated through doc/Makefile. Also, on text files that consist of multiple paragraphs, I find it good

Re: [PATCH 2/8] maint: remove empty lines at EOF, but excluding modules/*

2012-01-21 Thread Jim Meyering
Bruno Haible wrote: I too would prefer to use Paul's patch and thus to remove the doc/INSTALL* exemptions. Bruno, I know it's not your preference, but would that be ok with you. My objections were mostly esthetic, hence minor. You can decide to ignore my esthetic preferences. Thanks,

[PATCH] bootstrap: fail when bootstrap_post_import_hook fails

2012-01-21 Thread Jim Meyering
FYI, From 2f1a477706b06256ddca33739a771e3d97d011f1 Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Sat, 21 Jan 2012 18:12:30 +0100 Subject: [PATCH] bootstrap: fail when bootstrap_post_import_hook fails Otherwise, it's far too easy to miss diagnostics emitted between gnulib

Re: [Feature request] gitlog-to-changelog: don't cluster multiple ChangeLog entries under the same date line

2012-01-18 Thread Jim Meyering
Joel E. Denny wrote: On Tue, 17 Jan 2012, Jim Meyering wrote: Below is a patch that adds a --no-cluster option, which I believe does what Stefano wants. I want it too. OK to push? Hi Joel, Thanks. That looks fine, but please adjust the preceding comment to keep in sync with the new

Re: [PATCH 2/8] maint: remove empty lines at EOF, but excluding modules/*

2012-01-18 Thread Jim Meyering
Bruno Haible wrote: Paul Eggert wrote: The cat INSTALL argument is not that persuasive The other argument is that when viewing a file with vi and scrolling through it, the cursor interrupts the reading flow when it is placed on the last line and that line is not a blank one. But of course,

Re: [PATCH 2/8] maint: remove empty lines at EOF, but excluding modules/*

2012-01-18 Thread Jim Meyering
Karl Berry wrote: However, I am optimistic that I will be able to make matching changes upstream. Sorry, but for myself, I think it is a terrible waste of time to be thinking about this for fdl*.texi. The blank lines don't hurt anything Hi Karl, I know this hurts your

<    2   3   4   5   6   7   8   9   10   11   >