Re: autoreconf --force seemingly does not forcibly update everything

2024-04-10 Thread Nick Bowler
On 2024-04-10 16:36, Simon Josefsson wrote: > Is bootstrap intended to be reliable from within a tarball? I thought > the bootstrap script was not included in tarballs because it wasn't > designed to be ran that way, and the way it is designed may not give > expected results. Has this changed, so

Re: autoreconf --force seemingly does not forcibly update everything

2024-04-09 Thread Nick Bowler
On 2024-04-09 18:06, Sam James wrote: > Nick poses that a specific combination of tools is what is tested and > anything else invalidates it. But how does this work when building on > a system that was never tested on, or with different flags, or a > different toolchain? > > It's reasonable to say

Re: autoreconf --force seemingly does not forcibly update everything

2024-04-01 Thread Nick Bowler
On 2024-04-01 16:43, Guillem Jover wrote: > But if as a downstream distribution I explicitly request everything > to be considered obsolete via --force, then I really do want to get > whatever is in the system instead of in the upstream package. If I distribute a release package, what I have teste

[PATCH] readline: fix memory leak in replacement readline.

2023-05-30 Thread Nick Bowler
The getline function allocates memory that has to be freed by the caller regardless of whether or not the call succeeds. This is the case at least on current GNU libc getline, and also the case with Gnulib's own replacement getline implementation. Gnulib's readline replacement, which calls getlin

[PATCH] threadlib: fix case patterns for older Solaris.

2023-01-24 Thread Nick Bowler
The case pattern which matches solaris2.[1-9] etc. is not fully quoted, so the brackets get eaten by m4 and don't actually make it into the resulting configure script, giving just: case "$host_os" in solaris | solaris2.1-9 | solaris2.1-9.* | hpux*) which is obviously not correct. * m4/

Re: [PATCH] gnulib-tool: avoid 'if ! ...' in conditional dependencies.

2021-03-09 Thread Nick Bowler
On 2021-03-09, Paul Eggert wrote: > On 3/9/21 6:45 PM, Nick Bowler wrote: >> I routinely use heirloom-sh to suss out shell portability > > Does your project also have a problem on Solaris 10 because its /bin/sh > also doesn't grok "if !"? No idea. I do not pres

Re: [PATCH] gnulib-tool: avoid 'if ! ...' in conditional dependencies.

2021-03-09 Thread Nick Bowler
On 09/03/2021, Paul Eggert wrote: > On 3/9/21 6:29 PM, Nick Bowler wrote: >> This syntax is not portable in practice, as discussed in the Autoconf >> manual[1]. > > This shouldn't be a issue in configure scripts, since they should > arrange to use a good shell. If

[PATCH] gnulib-tool: avoid 'if ! ...' in conditional dependencies.

2021-03-09 Thread Nick Bowler
When using the conditional dependencies feature of Gnulib, several functions are emitted into configure scripts that use 'if ! ...'. This syntax is not portable in practice, as discussed in the Autoconf manual[1]. Because in this instance the construct is emitted into configure scripts, this has

Re: gl_CACHE_VAL_SILENT won't work correctly with upcoming autoconf 2.70

2020-03-13 Thread Nick Bowler
On 2020-03-13, Paul Eggert wrote: > On 3/13/20 3:04 PM, Nick Bowler wrote: >>AS_VAR_SET_IF([my_cv_no_printing], [my_cv_no_printing=hello]) > > I assume you meant > >AS_VAR_SET_IF([my_cv_no_printing], [], [my_cv_no_printing=hello]) Yes, thank you for the correction. Cheers, Nick

Re: gl_CACHE_VAL_SILENT won't work correctly with upcoming autoconf 2.70

2020-03-13 Thread Nick Bowler
Hi Bruno, On 13/03/2020, Bruno Haible wrote: > The underlying problem in Autoconf is the following: There is a macro > AC_CACHE_CHECK that does messaging, and a macro AC_CACHE_VAL whose > main purpose is to make a cache lookup, not messaging, but it > nevertheless outputs '(cached)' strings occas

Re: gnulib-tool --update fails w/ conditional-dependencies

2012-07-24 Thread Nick Bowler
On 2012-07-24 23:38 +0200, Bruno Haible wrote: > Nick Bowler wrote: [...] > > inctests is set to the empty string and the condition passes. > > Here's the problem: inctests should not be empty at this point. I'm > applying the attached fix (untested - please report

gnulib-tool --update fails w/ conditional-dependencies

2012-07-24 Thread Nick Bowler
nal-dependencies $GNULIB/gnulib-tool --update Reverting the aforementioned commit resolves the issue. Thanks, -- Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)

Re: AC_C_NORETURN macro?

2012-04-26 Thread Nick Bowler
ibute__ ((noreturn)). Though this may be fixed in the future, > problems would still appear with older versions. Thus we should use > _Noreturn directly, when supported. Another alternative is to simply make sure that you always include the GMP headers before including . Cheers, -- Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)

Questionable inline usage in gettext.h

2011-10-05 Thread Nick Bowler
cause it uses alloca (override using the always_inline attribute) Finally, regardless of whether or not the function actually gets inlined it's likely that this code will be duplicated at least in every translation unit which calls it since it has internal linkage. One wonders why these big functions aren't in their own .c file. Cheers, -- Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)