Re: [PATCH] Add 'safe-alloc' module

2009-02-21 Thread Bruno Haible
Hi David, Attached is an incremental patch with those changes. Thanks. With the confirmation by Karl that the copyright is assigned to the FSF both for Dan Berrange and for you, I've added your module, in two commits: 2009-02-21 David Lutterkort lut...@redhat.com Tests for module

Re: [PATCH] Add 'safe-alloc' module

2009-02-21 Thread David Lutterkort
On Sat, 2009-02-21 at 11:42 +0100, Bruno Haible wrote: Hi David, Attached is an incremental patch with those changes. Thanks. With the confirmation by Karl that the copyright is assigned to the FSF both for Dan Berrange and for you, I've added your module, in two commits:

Re: [PATCH] Add 'safe-alloc' module

2009-02-21 Thread Bruno Haible
David Lutterkort wrote: OK to commit that? Yes, absolutely. Committed. Another tiny change that I forgot to mention: A unit test (or any other program) needs an explicit 'return 0;' at the end of the main() function. In C99 and C++, when there is no return statement at the end of main(), the

Re: [PATCH] Add 'safe-alloc' module

2009-02-20 Thread Karl Berry
I was told that Red Hat has a blanket agreement with the FSF for copyright assignment. Whatever I did for this module, I did during work hours, so copyright belongs to Red Hat. I think that is also true for Dan (cc'd him so he can confirm that explicitly) Can somebody from the

[PATCH] Add 'safe-alloc' module

2009-02-19 Thread David Lutterkort
Hi, attached is a patch for a new module 'safe-alloc'. The module originated with libvirt[1] and was originally written by Dan Berrange. I touched it up for inclusion into gnulib. I've found them useful for some of my projects, and thought that putting them into gnulib would be much better than

Re: [PATCH] Add 'safe-alloc' module

2009-02-19 Thread Bruno Haible
Hi David, Thanks for proposing such a nice module! Uses of malloc/realloc really need a lot of attention and care, and I've also produced bug #7 (memory leak if realloc fails) more than once. For a module as basic as this one, in gnulib, I think it's essential that the copyright is with the FSF.

Re: [PATCH] Add 'safe-alloc' module

2009-02-19 Thread Matthew Woehlke
Bruno Haible wrote: For a module as basic as this one, in gnulib, I think it's essential that the copyright is with the FSF. Can you arrange with Daniel Berrange and/or his employer (Red Hat) that the copyright gets assigned? Please excuse my (mostly-ignorant) intrusion, but are you sure Red

Re: [PATCH] Add 'safe-alloc' module

2009-02-19 Thread Karl Berry
Please excuse my (mostly-ignorant) intrusion, but are you sure Red Hat does not already have an assignment on file? (I'm sure I heard somewhere that they do at least for certain GNU projects...) Indeed, Red Hat does, as an employer. I have been told that RH employees don't even

Re: [PATCH] Add 'safe-alloc' module

2009-02-19 Thread Micah Cowan
Karl Berry wrote: Please excuse my (mostly-ignorant) intrusion, but are you sure Red Hat does not already have an assignment on file? (I'm sure I heard somewhere that they do at least for certain GNU projects...) Indeed, Red Hat does, as an employer. I have been told that RH

Re: [PATCH] Add 'safe-alloc' module

2009-02-19 Thread David Lutterkort
Hi Bruno, On Thu, 2009-02-19 at 23:59 +0100, Bruno Haible wrote: Thanks for proposing such a nice module! All glory for this lies with Dan (and Jim Meyering for doing a preliminary review) For a module as basic as this one, in gnulib, I think it's essential that the copyright is with the