Re: [PATCH] exclude: avoid an unwarranted warning

2009-10-30 Thread Sergey Poznyakoff
Eric Blake e...@byu.net ha escrit: Like this? Yes, it was one of the ways Jim suggested earlier. See http://lists.gnu.org/archive/html/bug-gnulib/2009-08/msg00435.html Regards, Sergey

Re: [PATCH] exclude: avoid an unwarranted warning

2009-10-30 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Sergey Poznyakoff on 10/30/2009 10:52 AM: Eric Blake e...@byu.net ha escrit: Like this? Yes, it was one of the ways Jim suggested earlier. See http://lists.gnu.org/archive/html/bug-gnulib/2009-08/msg00435.html OK then, I've

[PATCH] exclude: avoid an unwarranted warning

2009-10-28 Thread Jim Meyering
:26:04 +0100 Subject: [PATCH] exclude: avoid an unwarranted warning * lib/exclude.c (excluded_file_name): Initialize rc before switch. --- ChangeLog |5 + lib/exclude.c |4 +++- 2 files changed, 8 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index 793ae50

Re: [PATCH] exclude: avoid an unwarranted warning

2009-10-28 Thread Bruno Haible
Jim Meyering wrote: There are other ways to avoid the warning that are cleaner Yes, I would have handled this one by adding a 'default: break;' alternative to the 'switch' statement. As a by-product of silencing the warning, it would also increase the robustness of the code. Bruno