Re: [PATCH] fix descriptions for AT_NO_AUTOMOUNT

2022-03-14 Thread Alejandro Colomar (man-pages)
>> >> Subject: [PATCH] fix descriptions for AT_NO_AUTOMOUNT >> [...] >> >> Signed-off-by: Pádraig Brady > > Makes sense to me. > But see a few minor comments below. But you missed the comments below :) Please fix them (see below). Thanks, Alex [...] >&g

Re: [PATCH] fix descriptions for AT_NO_AUTOMOUNT

2022-03-14 Thread Alejandro Colomar (man-pages)
On 3/14/22 19:02, Pádraig Brady wrote: > On 14/03/2022 13:24, Alejandro Colomar (man-pages) wrote: >> On 3/10/22 14:46, Pádraig Brady wrote: >>> Subject: [PATCH] fix descriptions for AT_NO_AUTOMOUNT >>> >>> Don't mention AT_NO_AUTOMOUNT for fstatat

Re: [PATCH] fix descriptions for AT_NO_AUTOMOUNT

2022-03-14 Thread Pádraig Brady
AT_NO_AUTOMOUNT flag before 4.11   fstatat() did imply AT_NO_AUTOMOUNT since 4.11 The attached patch clarifies this is the fstatat and statx man pages. sorry for the confusion, Pádraig --- Subject: [PATCH] fix descriptions for AT_NO_AUTOMOUNT Don't mention AT_NO_AUTOMOUNT for fstatat.2 a

Re: [PATCH] fix descriptions for AT_NO_AUTOMOUNT

2022-03-14 Thread Alejandro Colomar (man-pages)
ly AT_NO_AUTOMOUNT from 2.6.38 -> 4.11 >     I'm not sure it even honored the AT_NO_AUTOMOUNT flag before 4.11 >   fstatat() did imply AT_NO_AUTOMOUNT since 4.11 > > The attached patch clarifies this is the fstatat and statx man pages. > > sorry for the confusion, > Pádr

Re: [PATCH] fix descriptions for AT_NO_AUTOMOUNT

2022-03-10 Thread Paul Eggert
On 3/10/22 11:39, Pádraig Brady wrote: The changes are a net improvement I think since fewer interfaces are used. I would remove the AT_NO_AUTOMOUNT parameters to fstatat() though, since they're redundant it seems, and would only result in confusion if the patch is applied to remove that flag f

Re: [PATCH] fix descriptions for AT_NO_AUTOMOUNT

2022-03-10 Thread Pádraig Brady
On 10/03/2022 19:29, Paul Eggert wrote: On 3/10/22 05:46, Pádraig Brady wrote: After looking at the kernel code, it seems that:   fstatat() did _not_ imply AT_NO_AUTOMOUNT from 2.6.38 -> 4.11     I'm not sure it even honored the AT_NO_AUTOMOUNT flag before 4.11   fstatat() did imply AT_NO_

Re: [PATCH] fix descriptions for AT_NO_AUTOMOUNT

2022-03-10 Thread Paul Eggert
On 3/10/22 05:46, Pádraig Brady wrote: After looking at the kernel code, it seems that:   fstatat() did _not_ imply AT_NO_AUTOMOUNT from 2.6.38 -> 4.11     I'm not sure it even honored the AT_NO_AUTOMOUNT flag before 4.11   fstatat() did imply AT_NO_AUTOMOUNT since 4.11 Ouch, so this whole t

[PATCH] fix descriptions for AT_NO_AUTOMOUNT

2022-03-10 Thread Pádraig Brady
r the confusion, PádraigFrom d5c356f18b18cceb245ae9df175322760f32fb2a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A1draig=20Brady?= Date: Thu, 10 Mar 2022 13:37:11 + Subject: [PATCH] fix descriptions for AT_NO_AUTOMOUNT Don't mention AT_NO_AUTOMOUNT for fstatat.2 as it's implied s