Re: [PATCH] gnulib-tool.py: Don't emit empty Automake snippets.

2024-03-20 Thread Bruno Haible
Collin Funk wrote: > Apparently str.isspace() will return False for empty strings: > > print('\t'.isspace()) > True > print('\n'.isspace()) > True > print(''.isspace()) > False Oh, indeed. It's actually documented like this. > I've changed those conditions to the following: > >if

Re: [PATCH] gnulib-tool.py: Don't emit empty Automake snippets.

2024-03-20 Thread Collin Funk
Hi Bruno, On 3/19/24 3:00 AM, Bruno Haible wrote: > ... which tests whether the combination of the two snippets contains some > character that is not newline, not space, and not tab. I think I found the reason that these lines are printed. Apparently str.isspace() will return False for empty

Re: [PATCH] gnulib-tool.py: Don't emit empty Automake snippets.

2024-03-19 Thread Collin Funk
Hi Bruno, Bruno Haible writes: > ... which tests whether the combination of the two snippets contains some > character that is not newline, not space, and not tab. Oops... That is embarrassing. I wrote that right before going to sleep. I think I ended up imagining it was: grep '^[^

Re: [PATCH] gnulib-tool.py: Don't emit empty Automake snippets.

2024-03-19 Thread Bruno Haible
Hi Collin, > The shell script checks if an Automake snippet is non-empty by doing this: > > if grep '[^]' "$tmp"/amsnippet1 "$tmp"/amsnippet2 > /dev/null ; then ... which tests whether the combination of the two snippets contains some character that is not newline, not space, and not tab.

[PATCH] gnulib-tool.py: Don't emit empty Automake snippets.

2024-03-19 Thread Collin Funk
I finally figured out why these lines are printed in Emacs gnulib.mk.in: +## begin gnulib module manywarnings +ifeq (,$(OMIT_GNULIB_MODULE_manywarnings)) + +endif +## end gnulib module manywarnings + The same thing happens for the 'warnings' module as well. This patch fixes these added lines