Le lundi 15 septembre 2008 à 21:21 +0200, Paolo Bonzini a écrit :
The poll-tests module that is now available in the GnuLib repository
currently fail on OpenBSD:
Unconnected socket test... failed (huh, connect succeeded?)
Connected sockets test... failed (huh, connect succeeded?)
Yoann Vandoorselaere wrote:
Le lundi 15 septembre 2008 à 21:21 +0200, Paolo Bonzini a écrit :
The poll-tests module that is now available in the GnuLib repository
currently fail on OpenBSD:
Unconnected socket test... failed (huh, connect succeeded?)
Connected sockets test... failed (huh,
This solved the 'unconnected socket test':
Unconnected socket test... passed
Connected sockets test... failed (expecting POLLHUP after shutdown)
General socket test with fork... failed (expecting POLLHUP after shutdown)
Yes, it was not meant to fix the others.
Paolo
ot;;
google_ad_channel = "8427791634";
google_color_border = "FF";
google_color_bg = "FF";
google_color_link = "006792";
google_color_url = "006792";
google_color_text = "00";
//-->
Re: [PATCH] testsuite for poll(2)
Eric
Paolo Bonzini wrote:
Ok, will do so (s/HAVE_IO_H/__MSVCRT__).
But __MSVCRT__ is specific to mingw: the MSVC compiler does not define it.
(See also http://predef.sourceforge.net/) Some people use wrapper scripts
that make MSVC usable for autoconf based projects (cccl, cc-msvc.sh or similar).
Bruno Haible wrote:
Paolo Bonzini wrote:
Ok, will do so (s/HAVE_IO_H/__MSVCRT__).
But __MSVCRT__ is specific to mingw: the MSVC compiler does not define it.
OK to commit this patch?
I am not sure if __MSVCRT__ should be defined by the compiler, or rather
by the library (in which case
It is minimal in that it only tests one descriptor at a time. But it
has several tests for both sockets and pipes (and if compiled with
-DINTERACTIVE, TTYs too), so while it does not cover a lot of code in
the poll emulation it does cover all the subtleties.
In particular it highlighted a
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Paolo Bonzini on 9/12/2008 7:11 AM:
It is minimal in that it only tests one descriptor at a time. But it
has several tests for both sockets and pipes (and if compiled with
-DINTERACTIVE, TTYs too), so while it does not cover a lot of
Eric Blake wrote:
According to Paolo Bonzini on 9/12/2008 7:11 AM:
It is minimal in that it only tests one descriptor at a time. But it
has several tests for both sockets and pipes (and if compiled with
-DINTERACTIVE, TTYs too), so while it does not cover a lot of code in
the poll emulation
Le vendredi 12 septembre 2008 à 15:11 +0200, Paolo Bonzini a écrit :
It is minimal in that it only tests one descriptor at a time. But it
has several tests for both sockets and pipes (and if compiled with
-DINTERACTIVE, TTYs too), so while it does not cover a lot of code in
the poll emulation
Thanks Yoann!
- enum { TRUE, FALSE } will fail to compile on WIN32, better use
stdbool, or :
See patch at end of message.
- The code need to be linked to -lws2_32 to avoid undefined symbols, yet
the dependency is not pulled automatically.
Also fixed in the patch by using the sockets
Le vendredi 12 septembre 2008 à 15:49 +0200, Paolo Bonzini a écrit :
- enum { TRUE, FALSE } will fail to compile on WIN32, better use
stdbool, or :
See patch at end of message.
- The code need to be linked to -lws2_32 to avoid undefined symbols, yet
the dependency is not pulled
test-poll.o: In function `open_server_socket':
/home/yoann/dev/prelude/git/gnulib/poll/gltests/test-poll.c:91:
undefined reference to `_inet_aton'
test-poll.o: In function `connect_to_socket':
/home/yoann/dev/prelude/git/gnulib/poll/gltests/test-poll.c:121:
undefined reference to
Here is the final patch I pushed for Windows compatibility of tests. It
does not test much because the socket syscalls are not compatible
enough, but it compiles at least (using the Debian mingw32 and wine
packages).
Paolo
commit b03b6bfb8daa20dceff4593229f0df2c68c37e6e
Author: Paolo Bonzini
Eric Blake wrote:
Paolo Bonzini bonzini at gnu.org writes:
Here is the final patch I pushed for Windows compatibility of tests. It
does not test much because the socket syscalls are not compatible
enough, but it compiles at least (using the Debian mingw32 and wine
packages).
But it
15 matches
Mail list logo