Re: [PATCH 1/2] copy-file-range: new module

2019-06-28 Thread Bruno Haible
Florian Weimer wrote: > > In the NEWS entry, Florian writes: > > > >Applications which use the > >copy_file_range function will have to be run on kernels which implement > >the copy_file_range system call. > > > > I find this misleading. Coreutils will want to continue to use > >

Re: [PATCH 1/2] copy-file-range: new module

2019-06-28 Thread Florian Weimer
* Bruno Haible: > Pádraig Brady wrote: >> https://sourceware.org/ml/libc-alpha/2019-06/msg00873.html > > In the NEWS entry, Florian writes: > >Applications which use the >copy_file_range function will have to be run on kernels which implement >the copy_file_range system call. > > I

Re: [PATCH 1/2] copy-file-range: new module

2019-06-28 Thread Bruno Haible
Pádraig Brady wrote: > https://sourceware.org/ml/libc-alpha/2019-06/msg00873.html In the NEWS entry, Florian writes: Applications which use the copy_file_range function will have to be run on kernels which implement the copy_file_range system call. I find this misleading. Coreutils

Re: [PATCH 1/2] copy-file-range: new module

2019-06-28 Thread Pádraig Brady
On 07/06/19 09:04, Paul Eggert wrote: > Although I agree with both of Bruno's reasons, on further thought it makes > sense > for Gnulib to provide a stub instead of an emulation for this particular > function. > > The primary use for copy_file_range is to copy files more efficiently than a >

Re: [PATCH 1/2] copy-file-range: new module

2019-06-07 Thread Paul Eggert
Although I agree with both of Bruno's reasons, on further thought it makes sense for Gnulib to provide a stub instead of an emulation for this particular function. The primary use for copy_file_range is to copy files more efficiently than a read+write loop. However, the read+write loop will

Re: [PATCH 1/2] copy-file-range: new module

2019-06-05 Thread Bruno Haible
Florian Weimer wrote: > This is not a valid implementation of copy_file_range anymore. Please > see the discussion here: > > > > If you ship this in gnulib, you should at least call this function by a > different name. I disagree,

Re: [PATCH 1/2] copy-file-range: new module

2019-06-05 Thread Florian Weimer
* Paul Eggert: > +/* Emulation of copy_file_range. > + Copyright 2017-2019 Free Software Foundation, Inc. > + > + This program is free software: you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation;

[PATCH 1/2] copy-file-range: new module

2019-06-05 Thread Paul Eggert
* MODULES.html.sh: Add copy-file-range. * lib/copy-file-range.c, m4/copy-file-range.m4: * modules/copy-file-range: New files. * lib/unistd.in.h (copy_file_range): Declare. * m4/unistd_h.m4 (gl_UNISTD_H_DEFAULTS): Set up GNULIB_COPY_FILE_RANGE and HAVE_COPY_FILE_RANGE. * modules/unistd (unistd.h):