Re: [V3 PATCH] Implement SM3 hash algorithm in gnulib

2017-10-29 Thread Bruno Haible
Hi Jia, > I don't have this issue. Maybe /usr/include/gcrypt.h doesn't exist in > your environment? Correct, I don't have /usr/include/gcrypt.h in my environment. > Also, could you try to compile crypto/gc and see whether it has the > same failure? The testdir for module crypto/gc works fine

Re: [V3 PATCH] Implement SM3 hash algorithm in gnulib

2017-10-28 Thread Jia Zhang
Hi Bruno, I sent a new submission based on the latest master branch for a clear review without sm3 basis. Plz refer to "[PATCH] sm3: support to compile with libgcrypt". Let's continue the discussion over it. Thanks, Jia 于 2017/10/29 上午9:54, Jia Zhang 写道: > > > 于 2017/10/29 上午4:25, Bruno

Re: [V3 PATCH] Implement SM3 hash algorithm in gnulib

2017-10-28 Thread Bruno Haible
Hi Jia, > Here is the V3 changelog: > > - Correct @LIB_CRYPTO@ build issue in m4/sm3.m4. Thanks for the update. The module 'crypto/sm3' passes the test, so I pushed that part of the patch in your name. The module 'crypto/gc-sm3' does not pass the test: $ ./gnulib-tool --create-testdir

[V3 PATCH] Implement SM3 hash algorithm in gnulib

2017-10-28 Thread Jia Zhang
Hi Bruno, Here is the V3 changelog: - Correct @LIB_CRYPTO@ build issue in m4/sm3.m4. - Merge patch 4 and 5 together. - Make the commit header more readable for patch 2,3,4, and add the short file change descriptions. Thanks, Jia From 12be745f4a86ef73340ef88b7156fae262f70b84 Mon Sep 17