Re: Don't assume that UNICODE is not defined

2020-05-30 Thread Bruno Haible
Steve Lhomme wrote: > Microsoft.com doesn't document the function as LoadLibrary anymore. There is > LoadLibraryA and LoadLibraryW. > https://docs.microsoft.com/en-us/windows/win32/api/libloaderapi/nf-libloaderapi-loadlibrarya >

Re: Don't assume that UNICODE is not defined

2020-05-30 Thread Steve Lhomme
> On May 30, 2020 4:31 PM Bruno Haible wrote: > > > Steve Lhomme wrote: > > Why not use the proper call in the first place rather than use a define ? > > It could be useful in a generic header used by all to make sure everyone > > uses the right thing. But since you need to edit each file it

Re: Don't assume that UNICODE is not defined

2020-05-30 Thread Bruno Haible
Steve Lhomme wrote: > Why not use the proper call in the first place rather than use a define ? > It could be useful in a generic header used by all to make sure everyone > uses the right thing. But since you need to edit each file it would be > cleaner not to use any define at all and use the

Re: Don't assume that UNICODE is not defined

2020-05-30 Thread Steve Lhomme
don't need to do this stuff; nor do we > need to do it in the tests/ directory. Only the gnulib/lib/ directory may > reasonably be used with -DUNICODE, therefore only the gnulib/lib/ directory > needs this workaround. > > > 2020-05-30 Bruno Haible > > Don't assume that UNICODE

Re: Don't assume that UNICODE is not defined

2020-05-30 Thread Steve Lhomme
I think that's the other way around. _UNICODE is meant to be used with tchar.h. I found 41 instances in a recent SDK. UNICODE is the more generic term to chose between ANSI or WIDE API calls (if you don't force them directly). I found 4123 instances in the same SDK. So IMO the proper way is to

Re: Don't assume that UNICODE is not defined

2020-05-30 Thread Jeffrey Walton
On Sat, May 30, 2020 at 5:16 AM Bruno Haible wrote: > > I wrote: > > some types depend on > > whether UNICODE is defined or not [1]. > > Some functions also depend whether UNICODE is defined or not. > > Since UWP applications are meant to defined the macro UNICODE, but we want > Gnulib to produce

Don't assume that UNICODE is not defined

2020-05-30 Thread Bruno Haible
NICODE, therefore only the gnulib/lib/ directory needs this workaround. 2020-05-30 Bruno Haible Don't assume that UNICODE is not defined. Many Windows API functions are defined differently (redirecting to a function with suffix 'W') if the application defines the macro U