Re: Exception to space-tab rule

2011-03-14 Thread Jim Meyering
Reuben Thomas wrote: make syntax-check is complaining about space-tabs (sc_space_tab) in a sort of file where this is perfectly permissable: a .diff file. Why do I have a diff file in version control? Because I'm patching gnulib. Of course, I can add this to VC_LIST_ALWAYS_EXCLUDE_REGEX, but

Re: Exception to space-tab rule

2011-03-14 Thread Reuben Thomas
On 14 March 2011 14:23, Jim Meyering j...@meyering.net wrote: -    exit (1); -  exit (0); +    return 1; +  return 1; Was that intentional? i.e. should second return be return 0? -- http://rrt.sc3d.org

Re: Exception to space-tab rule

2011-03-14 Thread Jim Meyering
Reuben Thomas wrote: On 14 March 2011 14:23, Jim Meyering j...@meyering.net wrote: -    exit (1); -  exit (0); +    return 1; +  return 1; Was that intentional? i.e. should second return be return 0? Not at all. Thank you! I've fixed it locally.

Re: Exception to space-tab rule

2011-03-14 Thread Eric Blake
On 03/14/2011 08:23 AM, Jim Meyering wrote: However, I find that adding a whole new .x-sc_* file just to exempt an exceptional source file from one of the many syntax checks is a disproportionate burden. It has always bothered me to do that. So finally, here's a proposed maint.mk patch to

Exception to space-tab rule

2011-03-13 Thread Reuben Thomas
make syntax-check is complaining about space-tabs (sc_space_tab) in a sort of file where this is perfectly permissable: a .diff file. Why do I have a diff file in version control? Because I'm patching gnulib. Of course, I can add this to VC_LIST_ALWAYS_EXCLUDE_REGEX, but maybe .diff files should