Re: Fix crash in gnulib-tool.py under Python 2.6 and lower

2018-10-14 Thread Darshit Shah
* Tim Rühsen [181014 15:07]: > On 13.10.18 23:19, Darshit Shah wrote: > > Well, I don't think there will be a Python 4 for a very long time. The major > > version number changes only for a large backwards incompatibility. It's > > taken > > them ~10 years and people still not on Python 3. > > >

Re: Fix crash in gnulib-tool.py under Python 2.6 and lower

2018-10-14 Thread Tim Rühsen
On 13.10.18 23:19, Darshit Shah wrote: > Well, I don't think there will be a Python 4 for a very long time. The major > version number changes only for a large backwards incompatibility. It's taken > them ~10 years and people still not on Python 3. > > Anyways, I don't think this will break even

Re: Fix crash in gnulib-tool.py under Python 2.6 and lower

2018-10-13 Thread Gisle Vanem
Darshit Shah wrote: +# If using Python 2, ensure that at least version 2.7 is used. Older versions +# are not supported +if not PYTHON3 or sys.version_info[1] < 7: +print("Python version must be atleast 2.7. Exiting.") Shouldn't this be: if not PYTHON3 and sys.version_info[1] < 7: --

Re: Fix crash in gnulib-tool.py under Python 2.6 and lower

2018-10-13 Thread Darshit Shah
That's good to hear! :-) However in that case, let me point out that there is already a significant amount of code and checks in there for Python 2 compatibility. Removing even some of them might help with the overall maintainability of the codebase. And for Wget2, we will change our base

Re: Fix crash in gnulib-tool.py under Python 2.6 and lower

2018-10-13 Thread Darshit Shah
Well, I don't think there will be a Python 4 for a very long time. The major version number changes only for a large backwards incompatibility. It's taken them ~10 years and people still not on Python 3. Anyways, I don't think this will break even with v4. Since the check is only for ensuring the

Re: Fix crash in gnulib-tool.py under Python 2.6 and lower

2018-10-13 Thread Bruno Haible
Hi Darshit, > gnulib-tool.py will currently crash immediately on start if the underlying > Python version is 2.6 or lower. It's intentional that it supports only Python 3. See https://lists.gnu.org/archive/html/bug-gnulib/2017-09/msg00123.html Bruno

Re: Fix crash in gnulib-tool.py under Python 2.6 and lower

2018-10-13 Thread Tim Rühsen
On 13.10.18 21:28, Darshit Shah wrote: > gnulib-tool.py will currently crash immediately on start if the underlying > Python version is 2.6 or lower. The immediate crash that is seen occurs during > the check for the Python version. The check uses a syntax which was only > introduced in 2.7. I

Fix crash in gnulib-tool.py under Python 2.6 and lower

2018-10-13 Thread Darshit Shah
gnulib-tool.py will currently crash immediately on start if the underlying Python version is 2.6 or lower. The immediate crash that is seen occurs during the check for the Python version. The check uses a syntax which was only introduced in 2.7. I haven't checked, but I believe that the rest of