Re: Friendlier gnulib-tool error messages with multiple incompatible modules

Bruno Haible wrote: >> +func_wrap () >> +{ >> + prefix=$2 >> + plen=`echo "$prefix" |wc -c` >> + if test -z "$3"; then >> +len=80 >> + fi >> + len=`expr $len - $plen` >> + echo "$1" |sed -e "s#.\\{1,$len\\} #&\\n$prefix#g" -e "s#^#$prefix&#" >> +} > > This is an interesting use of 'sed'

Re: Friendlier gnulib-tool error messages with multiple incompatible modules

Hi Derek, > Anyone mind if I commit the attached patch? It makes `gnulib-tool > --update --lgpl' list all incompatible modules instead of breaking after > the first one This use-case is not very convincing, because 1) gnulib-tool is not documented to accept the option --lgpl together with

Re: Friendlier gnulib-tool error messages with multiple incompatible modules

Ralf Wildenhues wrote: > * Derek Price wrote on Thu, Sep 25, 2008 at 05:10:31PM CEST: >> --- gnulib-tool revision 1.307 >> +++ gnulib-tool working copy > >> +func_push () >> +{ >> + var=$1 >> + shift >> + for e; do > > The more portable way really is > for e > do > > not > for e; do Ok

Re: Friendlier gnulib-tool error messages with multiple incompatible modules

* Derek Price wrote on Thu, Sep 25, 2008 at 05:10:31PM CEST: > --- gnulib-tool revision 1.307 > +++ gnulib-tool working copy > +func_push () > +{ > + var=$1 > + shift > + for e; do The more portable way really is for e do not for e; do sorry for not stating that clearly the first time.

Re: Friendlier gnulib-tool error messages with multiple incompatible modules

Ralf Wildenhues wrote: > a couple of nits, if I may: The attached patch addresses all of Ralf's nits, fixes a few minor bugs, and contains a few additional simplifications of the new functions. Any objections? Regards, Derek -- Derek R. Price Solutions Architect Ximbiot, LLC

Re: Friendlier gnulib-tool error messages with multiple incompatible modules

Hi Derek, a couple of nits, if I may: * Derek Price wrote on Thu, Sep 25, 2008 at 12:11:27AM CEST: > --- gnulib-tool.orig 2008-09-24 17:48:53.0 -0400 > +++ gnulib-tool 2008-09-24 18:02:27.0 -0400 > +# Treat the shell variable with name $1 like a space delimited stack and >

Friendlier gnulib-tool error messages with multiple incompatible modules

Hey all, Anyone mind if I commit the attached patch? It makes `gnulib-tool --update --lgpl' list all incompatible modules instead of breaking after the first one, like so: $ ../gnulib/gnulib-tool --update --lgpl gnulib-tool: *** incompatible license on modules: gnulib-tool: *** areadlink-with-si