Re: Missing '_Noreturn'

2020-07-27 Thread Paul Eggert
pposed to be about DFAs not _Noreturn. So I installed the attached. Despite the Subject: line, the actual problem was an excess _Noreturn, not a missing _Noreturn. >From 5a68b3ffd9f676668d917f06df93ca486c0f6b3e Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Mon, 27 Jul 2020 12:57:45 -070

Re: Missing '_Noreturn'

2020-07-27 Thread Gisle Vanem
Paul Eggert wrote: -extern void dfawarn (const char *); +extern _Noreturn void dfawarn (const char *); That can't be right, as dfawarn typically does return. Does the following work around the compiler bug? If not we can use stronger medicine. diff --git a/tests/test-dfa-match-aux.c

Re: Missing '_Noreturn'

2020-07-27 Thread Florian Weimer
* Paul Eggert: > On 7/26/20 3:10 PM, Gisle Vanem wrote: >> Here's an error though: >> >>   test-dfa-match-aux.c >>   test-dfa-match-aux.c(39): error C2381: 'dfawarn': redefinition; >>   '__declspec(noreturn)' or '[[noreturn]]' differs >>   lib\dfa.h(125): note: see declaration of 'dfawarn' >

Re: Missing '_Noreturn'

2020-07-26 Thread Bruno Haible
Gisle Vanem wrote: > Thanks Paul for a fast patch. 10 minutes! > > Here's an error though: > >test-dfa-match-aux.c >test-dfa-match-aux.c(39): error C2381: 'dfawarn': redefinition; >'__declspec(noreturn)' or '[[noreturn]]' differs >lib\dfa.h(125): note: see declaration of

Re: Missing '_Noreturn'

2020-07-26 Thread Paul Eggert
On 7/26/20 3:10 PM, Gisle Vanem wrote: Here's an error though:   test-dfa-match-aux.c   test-dfa-match-aux.c(39): error C2381: 'dfawarn': redefinition;   '__declspec(noreturn)' or '[[noreturn]]' differs   lib\dfa.h(125): note: see declaration of 'dfawarn' That's a bug in MSVC. _Noreturn

Missing '_Noreturn'

2020-07-26 Thread Gisle Vanem
Thanks Paul for a fast patch. 10 minutes! Here's an error though: test-dfa-match-aux.c test-dfa-match-aux.c(39): error C2381: 'dfawarn': redefinition; '__declspec(noreturn)' or '[[noreturn]]' differs lib\dfa.h(125): note: see declaration of 'dfawarn' which I fixed by: --- a/lib/dfa.h