Re: OmniOS CI failure for test-fnmatch-5.sh

2024-05-21 Thread Bruno Haible
Hi Collin, > Looking into the __illumos__ macro it appears to be relatively new. > The original bug report is 3 years old [1]. The change was added to > OmniOS in version r15038s in 2021 [2]. Yes, I also noticed it: My copy of Solaris 11 OmniOS (r151036) does not have it, as can be seen by $ :

Re: OmniOS CI failure for test-fnmatch-5.sh

2024-05-21 Thread Collin Funk
Hi Bruno, On 5/21/24 2:13 PM, Bruno Haible wrote: >> I pushed the attached patch adding the #if defined __illumos__. > > It apparently has the desired effect. So, let me do the same thing with > the test-trim3.sh test, that fails like this: > > FAIL: test-trim3.sh > === > > ../..

Re: OmniOS CI failure for test-fnmatch-5.sh

2024-05-21 Thread Bruno Haible
Collin Funk wrote: > I pushed the attached patch adding the #if defined __illumos__. It apparently has the desired effect. So, let me do the same thing with the test-trim3.sh test, that fails like this: FAIL: test-trim3.sh === ../../gltests/test-trim.c:150: assertion 'strcmp (res

Re: OmniOS CI failure for test-fnmatch-5.sh

2024-05-21 Thread Collin Funk
On 5/21/24 1:39 AM, Bruno Haible wrote: >> I was taking a look at the CI stuff you wrote. Nice work, it seems >> really helpful. > > Thanks for helping! The goal here being to get all FAILs either fixed > or declared as XFAIL, this really helps. Sounds like a good plan. I can help with fixing the

Re: OmniOS CI failure for test-fnmatch-5.sh

2024-05-21 Thread Bruno Haible
Hi Collin, > I was taking a look at the CI stuff you wrote. Nice work, it seems > really helpful. Thanks for helping! The goal here being to get all FAILs either fixed or declared as XFAIL, this really helps. > The tests pass with that one check #ifdef'd out. Here is the diff I > used: > > $ di

OmniOS CI failure for test-fnmatch-5.sh

2024-05-21 Thread Collin Funk
Hi Bruno, I was taking a look at the CI stuff you wrote. Nice work, it seems really helpful. I saw this test failure: FAIL: test-fnmatch-5.sh === ../../gltests/test-fnmatch.c:898: assertion 'fnmatch ("x[[:punct:]]y", "x\241\301y", 0) == 0' failed Stack trace: 0x410355 main