Collin Funk wrote:
> I've attached an updated patch.
Thanks! Applied.
Bruno
On 3/23/24 4:49 AM, Bruno Haible wrote:
> If the variable has 3 possible values (None, False, True), then writing
> 'if value == True:' is the simpler way. Why would one use a conversion to
> bool, i.e. 3-values to 2-values conversion? It would only make things
> more complicated.
Yes, I agree
Collin Funk wrote:
> I'm used to writing this:
>
> if value:
> print('1')
> else:
> print('2')
>
> instead of this:
>
> if value == True:
> print('1')
> elif value == False:
> print('2')
If the variable has 2 possible values, then writing 'if value:' is the
simpler way of
On 3/23/24 3:54 AM, Bruno Haible wrote:
> But this part of your patch is a no-op, since
>
> >>> None == True
> False
> >>> None == False
> False
>
> No?
Oops... Yes you are right.
I'm used to writing this:
if value:
print('1')
else:
print('2')
instead of this:
if value ==
Hi Collin,
> This patch handles some issues with --vc-files/--no--vc-files.
> gnulib-tool.py would always print this in the actioncmd message at the
> top of files. The proper behavior would be to check if vc_files ==
> None before treating it as a bool.
But this part of your patch is a no-op,
