On 14/11/2023 18:42, Bruno Haible wrote:
I can't find the time to think through the detailed results that you listed.
I hope you can do that.
No worries, hopefully I wont end up being to much of a bother.
But in summary, my point was "the patch is odd, because it uses MIN in one
place and
Sevan Janiyan wrote:
> On 10/11/2023 02:41, Sevan Janiyan wrote:
> > On 09/11/2023 23:48, Bruno Haible wrote:
> >> The patch tests MAC_OS_X_VERSION_MIN_REQUIRED in one place and
> >> MAC_OS_X_VERSION_MAX_ALLOWED in the other place. What if someone compiles
> >> for a range that includes both 10.4
On 10/11/2023 02:41, Sevan Janiyan wrote:
On 09/11/2023 23:48, Bruno Haible wrote:
The patch tests MAC_OS_X_VERSION_MIN_REQUIRED in one place and
MAC_OS_X_VERSION_MAX_ALLOWED in the other place. What if someone compiles
for a range that includes both 10.4 and 10.5? That is,
On 09/11/2023 23:48, Bruno Haible wrote:
The patch tests MAC_OS_X_VERSION_MIN_REQUIRED in one place and
MAC_OS_X_VERSION_MAX_ALLOWED in the other place. What if someone compiles
for a range that includes both 10.4 and 10.5? That is,
MAC_OS_X_VERSION_MIN_REQUIRED is MAC_OS_X_VERSION_10_4
and
Sevan Janiyan wrote:
> @@ -676,11 +678,21 @@ int libsigsegv_version = LIBSIGSEGV_VERSION;
>
> # elif defined __powerpc__
>
> +#if MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_X_VERSION_10_5
> /* See the definitions of
> - 'ucontext_t' and 'struct __darwin_ucontext' in ,
> - 'struct
Sevan Janiyan wrote:
> On 30/11/2021 01:12, Bruno Haible wrote:
> > I suspect that it merely compiles, but does not actually work on Mac
> > OS X 10.4.x.
> >
> > You can find out by running "make check", to see whether the unit
> > tests pass.
>
>
> Running "make check" results in 2 test
On 06/11/2023 13:54, Sevan Janiyan wrote:
Sorry about the noise, I suspect the patch is invalid for Leopard.
I will follow up with a new patch which splits the case for 10.5 &
older, if that is the case, once I've done more testing.
Attached patch splits the powerpc case to Leopard and newer
On 06/11/2023 03:09, Sevan Janiyan wrote:
Updated version of the patch attached.
Sorry about the noise, I suspect the patch is invalid for Leopard.
I will follow up with a new patch which splits the case for 10.5 &
older, if that is the case, once I've done more testing.
Sevan
On 30/11/2021 01:12, Bruno Haible wrote:
I suspect that it merely compiles, but does not actually work on Mac
OS X 10.4.x.
You can find out by running "make check", to see whether the unit
tests pass.
Running "make check" results in 2 test failures without the use of
libsigsegv.
Hello Sevan,
> Attached patch fixes support for building lib/sigsegv.c in PowerPC Mac
> OS X. Tested on OS X 10.4.11.
>
> Amended definition sources in comment using
> https://opensource.apple.com/source/xnu/xnu-792.24.17/bsd/sys/_types.h.auto.html
>
10 matches
Mail list logo