Eric Blake wrote on 2007-08-22:
* lib/stdio_.h (getdelim, getline): Declare.
Small improvement of the doc: Say that getline reads a line. Return not
Returns (GNU style conventions). List the identifiers in the prototype.
2007-09-29 Bruno Haible [EMAIL PROTECTED]
* lib/stdio_.h
Eric Blake wrote:
Here's what I'm committing; I think it addresses all your points.
2007-08-22 Eric Blake [EMAIL PROTECTED]
Getline touchups.
* lib/getdelim.c (getdelim): Revert regression that required *n to
be 0 when *lineptr is NULL. Preserve errno across
Eric Blake [EMAIL PROTECTED] wrote:
According to Eric Blake on 8/22/2007 6:04 PM:
According to Bruno Haible on 8/22/2007 3:02 PM:
Hi Eric,
Thanks for working on this, and for the unit tests. The patch - excluding
the one of getdelim.c - is nearly perfect. But I see three problems:
Thanks
Jim Meyering [EMAIL PROTECTED] writes:
[is this ok with you, Simon? ]
Yes, please add it.
/Simon
Simon Josefsson [EMAIL PROTECTED] wrote:
Jim Meyering [EMAIL PROTECTED] writes:
[is this ok with you, Simon? ]
Yes, please add it.
Committed.
Eric Blake [EMAIL PROTECTED] writes:
According to Jim Meyering on 8/19/2007 2:18 PM:
Eric Blake [EMAIL PROTECTED] wrote:
I could go either way, although I'm leaning toward doing it now;
I agree. Doing it now is fine.
How about this for the patch, then? Simon, this is your module. The
Eric Blake [EMAIL PROTECTED] wrote:
2007-08-21 Eric Blake [EMAIL PROTECTED]
Move getline and getdelim into stdio.h, per POSIX 200x.
...
Thanks for doing that.
I've adjusted coreutils accordingly:
http://git.sv.gnu.org/gitweb/?p=coreutils.git
Hi Eric,
Thanks for working on this, and for the unit tests. The patch - excluding
the one of getdelim.c - is nearly perfect. But I see three problems:
1) You define the shell variable HAVE_DECL_GETDELIM depending whether the
function exists, not whether the function is declared. But for
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruno Haible on 8/22/2007 3:02 PM:
Hi Eric,
Thanks for working on this, and for the unit tests. The patch - excluding
the one of getdelim.c - is nearly perfect. But I see three problems:
Thanks for catching the nits. Please feel
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Eric Blake on 8/22/2007 6:04 PM:
According to Bruno Haible on 8/22/2007 3:02 PM:
Hi Eric,
Thanks for working on this, and for the unit tests. The patch - excluding
the one of getdelim.c - is nearly perfect. But I see three problems:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Jim Meyering on 8/19/2007 2:18 PM:
Eric Blake [EMAIL PROTECTED] wrote:
I could go either way, although I'm leaning toward doing it now;
I agree. Doing it now is fine.
How about this for the patch, then? Simon, this is your module.
Eric Blake [EMAIL PROTECTED] writes:
I could go either way, although I'm leaning toward doing it now; I'll wait
for anyone else to speak their mind.
I also lean towards doing it now, since I think it unlikely that
POSIX will change much before becoming official in this area,
and anyway its use
Eric Blake [EMAIL PROTECTED] wrote:
I could go either way, although I'm leaning toward doing it now;
I agree. Doing it now is fine.
Eric Blake wrote:
Now that POSIX 200x is standardizing getline and getdelim as part of
stdio.h, should we get rid of getline.h and beef up stdio_.h, then
adjust all the callers (such as yesno.c) to assume this?
Hmm, can't we wait until the POSIX standard with these changes is official?
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruno Haible on 8/18/2007 4:36 PM:
Eric Blake wrote:
Now that POSIX 200x is standardizing getline and getdelim as part of
stdio.h, should we get rid of getline.h and beef up stdio_.h, then
adjust all the callers (such as yesno.c) to
15 matches
Mail list logo
