Re: canonicalize_filename_mode memory usage

2009-12-19 Thread Jim Meyering
Eric Blake wrote: Sergey Poznyakoff gray at gnu.org.ua writes: A user of tar reported a suboptimal memory usage by the canonicalize_filename_mode. Attached is the patch he proposed. Any comments? Who do we use as --author and/or reporter in the git commit? The patch first appeared on

Re: canonicalize_filename_mode memory usage

2009-12-19 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 12/19/2009 7:55 AM: For that matter, the temporary variable actual_size is not even needed. I'd write the patch as just a 2-line addition: if (rname_limit != dest + 1) rname = xrealloc (rname, dest - rname + 1);

canonicalize_filename_mode memory usage

2009-12-17 Thread Sergey Poznyakoff
Hello, A user of tar reported a suboptimal memory usage by the canonicalize_filename_mode. Attached is the patch he proposed. Any comments? Regards, Sergey This patch corrects highly non-optimal memory allocation by canonicalize_filename_mode(), which got exposed with: 2009-08-07 Sergey

Re: canonicalize_filename_mode memory usage

2009-12-17 Thread Eric Blake
Sergey Poznyakoff gray at gnu.org.ua writes: A user of tar reported a suboptimal memory usage by the canonicalize_filename_mode. Attached is the patch he proposed. Any comments? Who do we use as --author and/or reporter in the git commit? The patch first appeared on the tar list in an

Re: canonicalize_filename_mode memory usage

2009-12-17 Thread Sergey Poznyakoff
Eric Blake e...@byu.net ha escrit: Who do we use as --author and/or reporter in the git commit? The patch first appeared on the tar list in an email by Solar Designer, but it is not clear whether he wrote it, or whether we should attribute yet some other person. It was reported by Solar